Possible misplaced #endif in wifi middleware...

[EdSutter]

I'm working with IMXRT1170EVKB and SDK_25_03_00 and stumbled on this.

Referring to function wifi_core_task() in middleware/wifi_nxp/wifidriver/wifi.c...

At line 1914 the code is...

#if defined(RW610)
        (void)wifi_imu_lock();
#else
        /* Protect the SDIO from other parallel activities */
        (void)wifi_sdio_lock();

        (void)wlan_process_int_status(mlan_adap);
#endif

#if defined(RW610)
        wifi_imu_unlock();
#else
        wifi_sdio_unlock();
#endif

 I admit that I am still learning this driver, but it sure seems like the top #endif is mistakenly commenting out the call to wlan_process_int_status if RW610 is defined.  Note that if RW610 is defined, then the code is simply...

        (void)wifi_imu_lock();
        wifi_imu_unlock();

which seems a bit suspicious.

[DanielRuvalcaba]

Hi,

Thank you for your post.

By any chance, did you find any problem with this implementation?

Regards,

Daniel.

[EdSutter]

I did not (my configuration does not have the RW610 defined); this is strictly an observation.

[DanielRuvalcaba · Accepted solution]

Hi,

Thank you for confirming this is not affecting. I still will notify the corresponding team.

Regards,

Daniel.