IMX8MP and sec-dsim.c support

取消
显示结果 
显示  仅  | 搜索替代 
您的意思是: 

IMX8MP and sec-dsim.c support

4,162 次查看
tylernol
Contributor IV

hi there,

 I am attempting to bring up a panel connected via MIPI DSI to the imx8MP . While looking at the source for the DSI bridge driver, I noticed that the driver has "disappeared" from the fslc branch. 

This is the last occurrance I see : https://github.com/Freescale/linux-fslc/commits/5.15-2.2.x-imx/drivers/gpu/drm/bridge/sec-dsim.c

I am currently using this branch:

linux-imx_5.10.72_2.2.0

where has the driver moved to in more current branches? I see some activity to consolidate with a Samsung version. 

 

 thanks!

 

 

 

0 项奖励
回复
4 回复数

4,074 次查看
tylernol
Contributor IV

this appears to be fine. Determined that there was bug in the clock enable sequencing, so commands were not being sent out. 

0 项奖励
回复

4,146 次查看
Bio_TICFSL
NXP TechSupport
NXP TechSupport

Hello,

You need to check if your kernel is available from the new git:

https://github.com/nxp-imx

Regards

4,140 次查看
tylernol
Contributor IV

the driver still exists here, good! The line I am curious about is unchanged, so I will ask here.  https://github.com/nxp-imx/linux-imx/blob/29549c7073bf72cfb2c4614d37de45ec36b60475/drivers/gpu/drm/b...

```

if (packet.payload_length) {		/* Long Packet case */
		reinit_completion(&dsim->pl_tx_done);

		/* write packet payload */
		sec_mipi_dsim_write_pl_to_sfr_fifo(dsim,
						   packet.payload,
						   packet.payload_length);

		/* write packet header */
		sec_mipi_dsim_write_ph_to_sfr_fifo(dsim,
						   packet.header,
						   use_lpm);

		ret = wait_for_completion_timeout(&dsim->ph_tx_done,
						  MIPI_FIFO_TIMEOUT);
		if (!ret) {
			dev_err(dsim->dev, "wait payload tx done time out\n");
			return -EBUSY;
		}
	}
```

we are resetting 

dsim->pl_tx_done

 however we are waiting on :

wait_for_completion_timeout(&dsim->ph_tx_done,

 is this correct? Does the hw generate interrupts for both the pl_tx and the ph_tx for long packets? 

0 项奖励
回复

1,781 次查看
persandberg
Contributor III

Hi,

I was wondering the same thing. Have you solved this? Why is it waiting for ph_tx_done instead of pl_tx_done.

0 项奖励
回复
%3CLINGO-SUB%20id%3D%22lingo-sub-1637461%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3EIMX8MP%20%E5%92%8C%20%E9%AB%98%E6%95%88%E5%AF%86%E7%A0%81%E5%AD%A6%E6%A0%87%E5%87%86(SEC)-dsim.c%E6%94%AF%E6%8C%81%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-1637461%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3E%E6%82%A8%E5%A5%BD%EF%BC%8C%3C%2FP%3E%3CP%3E%E6%88%91%E6%AD%A3%E8%AF%95%E5%9B%BE%E8%B0%83%E5%87%BA%E4%B8%80%E4%B8%AA%E9%80%9A%E8%BF%87%20MIPI%20DSI%20%E8%BF%9E%E6%8E%A5%E5%88%B0%20imx8MP%20%E7%9A%84%E9%9D%A2%E6%9D%BF%E3%80%82%E5%9C%A8%E6%9F%A5%E7%9C%8B%20DSI%20%E6%A1%A5%E6%8E%A5%E9%A9%B1%E5%8A%A8%E7%A8%8B%E5%BA%8F%E7%9A%84%E6%BA%90%E4%BB%A3%E7%A0%81%E6%97%B6%EF%BC%8C%E6%88%91%E6%B3%A8%E6%84%8F%E5%88%B0%E8%AF%A5%E9%A9%B1%E5%8A%A8%E7%A8%8B%E5%BA%8F%E5%B7%B2%E4%BB%8E%20fslc%20%E5%88%86%E6%94%AF%22%E6%B6%88%E5%A4%B1%E4%BA%86%22%20%E3%80%82%20%3C%2FP%3E%3CP%3E%E8%BF%99%E6%98%AF%E6%88%91%E7%9C%8B%E5%88%B0%E7%9A%84%E6%9C%80%E5%90%8E%E4%B8%80%E7%A7%8D%E6%83%85%E5%86%B5%EF%BC%9A%3CA%20href%3D%22https%3A%2F%2Fgithub.com%2FFreescale%2Flinux-fslc%2Fcommits%2F5.15-2.2.x-imx%2Fdrivers%2Fgpu%2Fdrm%2Fbridge%2Fsec-dsim.c%22%20target%3D%22_blank%22%20rel%3D%22nofollow%20noopener%20noreferrer%22%3Ehttps%3A%2F%2Fgithub.com%2FFreescale%2Flinux-fslc%2Fcommits%2F5.15-2.2.x-imx%2Fdrivers%2Fgpu%2Fdrm%2Fbridge%2Fsec-dsim.c%3C%2FA%3E%3C%2FP%3E%3CP%3E%E6%88%91%E7%9B%AE%E5%89%8D%E6%AD%A3%E5%9C%A8%E4%BD%BF%E7%94%A8%E8%AF%A5%E5%88%86%E6%94%AF%EF%BC%9A%3C%2FP%3E%3CP%3Elinux-imx_5.10.72_2.2.0%3C%2FP%3E%3CP%3E%E5%9C%A8%E6%9B%B4%E5%A4%9A%E7%9A%84%E5%88%86%E6%94%AF%E4%B8%AD%EF%BC%8C%E9%A9%B1%E5%8A%A8%E7%A8%8B%E5%BA%8F%E7%A7%BB%E5%8A%A8%E5%88%B0%E4%BA%86%E5%93%AA%E9%87%8C%EF%BC%9F%E6%88%91%E7%9C%8B%E5%88%B0%E4%BA%86%E4%B8%80%E4%BA%9B%E6%B4%BB%E5%8A%A8%EF%BC%8C%E5%B8%8C%E6%9C%9B%E4%B8%8E%E4%B8%89%E6%98%9F%E7%89%88%E6%9C%AC%E8%BF%9B%E8%A1%8C%E6%95%B4%E5%90%88%E3%80%82%20%3C%2FP%3E%3CBR%20%2F%3E%3CP%3E%E8%B0%A2%E8%B0%A2%E6%82%A8%EF%BC%81%3C%2FP%3E%3CBR%20%2F%3E%3CBR%20%2F%3E%3CBR%20%2F%3E%3C%2FLINGO-BODY%3E%3CLINGO-SUB%20id%3D%22lingo-sub-2263507%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%20translate%3D%22no%22%3ERe%3A%20IMX8MP%20and%20sec-dsim.c%20support%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-2263507%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3E%E6%82%A8%E5%A5%BD%EF%BC%8C%3C%2FP%3E%3CP%3E%E6%88%91%E4%B9%9F%E5%9C%A8%E6%83%B3%E5%90%8C%E6%A0%B7%E7%9A%84%E9%97%AE%E9%A2%98%E3%80%82%E4%BD%A0%E8%A7%A3%E5%86%B3%E4%BA%86%E8%BF%99%E4%B8%AA%E9%97%AE%E9%A2%98%E5%90%97%EF%BC%9F%E4%B8%BA%E4%BB%80%E4%B9%88%E7%AD%89%E5%BE%85%E7%9A%84%E6%98%AF%20ph_tx_done%EF%BC%8C%E8%80%8C%E4%B8%8D%E6%98%AF%20pl_tx_done%E3%80%82%3C%2FP%3E%3C%2FLINGO-BODY%3E%3CLINGO-SUB%20id%3D%22lingo-sub-1642451%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%20translate%3D%22no%22%3ERe%3A%20IMX8MP%20and%20sec-dsim.c%20support%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-1642451%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3E%E7%9C%8B%E6%9D%A5%E6%B2%A1%E6%9C%89%E9%97%AE%E9%A2%98%E3%80%82%E7%A1%AE%E5%AE%9A%E6%97%B6%E9%92%9F%E5%90%AF%E7%94%A8%E6%8E%92%E5%BA%8F%E4%B8%AD%E5%AD%98%E5%9C%A8%E9%94%99%E8%AF%AF%EF%BC%8C%E5%9B%A0%E6%AD%A4%E6%B2%A1%E6%9C%89%E5%8F%91%E9%80%81%E5%91%BD%E4%BB%A4%E3%80%82%20%3C%2FP%3E%3C%2FLINGO-BODY%3E%3CLINGO-SUB%20id%3D%22lingo-sub-1638177%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%20translate%3D%22no%22%3ERe%3A%20IMX8MP%20and%20sec-dsim.c%20support%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-1638177%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3E%E5%8F%B8%E6%9C%BA%E8%BF%98%E5%9C%A8%EF%BC%8C%E5%BE%88%E5%A5%BD%EF%BC%81%E6%88%91%E5%A5%BD%E5%A5%87%E7%9A%84%E9%82%A3%E6%9D%A1%E7%BA%BF%E6%B2%A1%E6%9C%89%E5%8F%98%E5%8C%96%EF%BC%8C%E6%89%80%E4%BB%A5%E6%88%91%E6%83%B3%E5%9C%A8%E8%BF%99%E9%87%8C%E9%97%AE%E4%B8%80%E4%B8%8B%E3%80%82%20%20%3CA%20href%3D%22https%3A%2F%2Fgithub.com%2Fnxp-imx%2Flinux-imx%2Fblob%2F29549c7073bf72cfb2c4614d37de45ec36b60475%2Fdrivers%2Fgpu%2Fdrm%2Fbridge%2Fsec-dsim.c%23L695%22%20target%3D%22_blank%22%20rel%3D%22nofollow%20noopener%20noreferrer%22%3Ehttps%3A%2F%2Fgithub.com%2Fnxp-imx%2Flinux-imx%2Fblob%2F29549c7073bf72cfb2c4614d37de45ec36b60475%2Fdrivers%2Fgpu%2Fdrm%2Fbridge%2Fsec-dsim.c%23L695%3C%2FA%3E%3C%2FP%3E%3CP%3E%60%60%60%3C%2FP%3E%3CPRE%20translate%3D%22no%22%3Eif%20(packet.payload_length)%20%7B%09%09%2F*%20Long%20Packet%20case%20*%2F%0A%09%09reinit_completion(%26amp%3Bdsim-%26gt%3Bpl_tx_done)%3B%0A%0A%09%09%2F*%20write%20packet%20payload%20*%2F%0A%09%09sec_mipi_dsim_write_pl_to_sfr_fifo(dsim%2C%0A%09%09%09%09%09%09%20%20%20packet.payload%2C%0A%09%09%09%09%09%09%20%20%20packet.payload_length)%3B%0A%0A%09%09%2F*%20write%20packet%20header%20*%2F%0A%09%09sec_mipi_dsim_write_ph_to_sfr_fifo(dsim%2C%0A%09%09%09%09%09%09%20%20%20packet.header%2C%0A%09%09%09%09%09%09%20%20%20use_lpm)%3B%0A%0A%09%09ret%20%3D%20wait_for_completion_timeout(%26amp%3Bdsim-%26gt%3Bph_tx_done%2C%0A%09%09%09%09%09%09%20%20MIPI_FIFO_TIMEOUT)%3B%0A%09%09if%20(!ret)%20%7B%0A%09%09%09dev_err(dsim-%26gt%3Bdev%2C%20%22wait%20payload%20tx%20done%20time%20out%5Cn%22)%3B%0A%09%09%09return%20-EBUSY%3B%0A%09%09%7D%0A%09%7D%3CBR%20%2F%3E%60%60%60%3C%2FPRE%3E%3CP%3E%E6%88%91%E4%BB%AC%E6%AD%A3%E5%9C%A8RESET%3C%2FP%3E%3CPRE%20translate%3D%22no%22%3Edsim-%26gt%3Bpl_tx_done%3C%2FPRE%3E%3CP%3E%E7%84%B6%E8%80%8C%EF%BC%8C%E6%88%91%E4%BB%AC%E6%AD%A3%E5%9C%A8%E7%AD%89%E5%BE%85......%EF%BC%9A%3C%2FP%3E%3CPRE%20translate%3D%22no%22%3Ewait_for_completion_timeout(%26amp%3Bdsim-%26gt%3Bph_tx_done%2C%3C%2FPRE%3E%3CP%3E%E8%BF%99%E6%98%AF%E5%90%A6%E6%AD%A3%E7%A1%AE%EF%BC%9F%E5%AF%B9%E4%BA%8E%E9%95%BF%E6%95%B0%E6%8D%AE%E5%8C%85%EF%BC%8CHW%20%E6%98%AF%E5%90%A6%E5%90%8C%E6%97%B6%E4%B8%BA%20pl_tx%20%E5%92%8C%20ph_tx%20%E4%BA%A7%E7%94%9F%E4%B8%AD%E6%96%AD%EF%BC%9F%20%3C%2FP%3E%3C%2FLINGO-BODY%3E%3CLINGO-SUB%20id%3D%22lingo-sub-1638065%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%20translate%3D%22no%22%3ERe%3A%20IMX8MP%20and%20sec-dsim.c%20support%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-1638065%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3E%E4%BD%A0%E5%A5%BD%3C%2FP%3E%0A%3CP%3E%E6%82%A8%E9%9C%80%E8%A6%81%E6%A3%80%E6%9F%A5%E6%82%A8%E7%9A%84%E5%86%85%E6%A0%B8%E6%98%AF%E5%90%A6%E5%8F%AF%E4%BB%8E%E6%96%B0%E7%89%88%20git%20%E8%8E%B7%E5%8F%96%EF%BC%9A%3C%2FP%3E%0A%3CP%3E%3CA%20href%3D%22https%3A%2F%2Fgithub.com%2Fnxp-imx%22%20target%3D%22_blank%22%20rel%3D%22nofollow%20noopener%20noreferrer%22%3Ehttps%3A%2F%2Fgithub.com%2Fnxp-imx%3C%2FA%3E%3C%2FP%3E%0A%3CP%3E%E6%AD%A4%E8%87%B4%3C%2FP%3E%3C%2FLINGO-BODY%3E