How to change Bluetooth state (BLE to BT) in marshmallow ?.

[ThanarajS]

Hi All,

   We are trying to Up the Bluetooth (BT) in marshmallow. But its always take BLE Only mode.How to re-direct this proccess to BT only mode.

   Bluetooth stae is moving 10 to 14, We need only BT state 10 to 11. How to TURN ON BT MODE ?

CURRENT_LOG::

01-02 00:46:26.283 441 778 D BluetoothManagerService: enable(): mBluetooth =null mBinding = false
01-02 00:46:26.283 441 778 D BluetoothManagerService: enable returning
01-02 00:46:26.283 441 458 D BluetoothManagerService: Message: 1
01-02 00:46:26.284 441 458 D BluetoothManagerService: MESSAGE_ENABLE: mBluetooth = null
01-02 00:46:26.296 441 458 I ActivityManager: Start proc 1012:com.android.bluetooth/1002 for service com.android.bluetooth/.btservice.AdapterService
01-02 00:46:26.299 153 332 W audio_hw_primary: out_set_parameters routing=2, ret 0, out -1243027712
01-02 00:46:26.310 153 331 W audio_hw_primary: ret -32, pcm write 768 error wait error: hw 0x501c0 app 0x507c0 avail 0x0
01-02 00:46:26.310 153 331 W audio_hw_primary: : Unknown error -32
01-02 00:46:26.824 1012 1012 D AdapterServiceConfig: Adding HeadsetService
01-02 00:46:26.828 1012 1012 D AdapterServiceConfig: Adding A2dpService
01-02 00:46:26.830 1012 1012 D AdapterServiceConfig: Adding HidService
01-02 00:46:26.830 1012 1012 D AdapterServiceConfig: Adding HealthService
01-02 00:46:26.830 1012 1012 D AdapterServiceConfig: Adding PanService
01-02 00:46:26.830 1012 1012 D AdapterServiceConfig: Adding GattService
01-02 00:46:26.831 1012 1012 D AdapterServiceConfig: Adding BluetoothMapService
01-02 00:46:26.909 1012 1012 I bt_bluedroid:
01-02 00:46:26.909 1012 1012 I bt_bluedroid: =================> Open bluetooth stack start module->name=Bluetooth Stack
01-02 00:46:26.909 1012 1012 I bt_bluedroid:
01-02 00:46:26.909 1012 1012 I bt_bluedroid: ===================> Open bluetooth stack end
01-02 00:46:26.929 441 458 D BluetoothManagerService: Message: 20
01-02 00:46:26.929 441 458 D BluetoothManagerService: Added callback: android.bluetooth.IBluetoothManagerCallback$Stub$Proxy@f87b940:true
01-02 00:46:26.930 1012 1012 D BluetoothAdapterState: make() - Creating AdapterState
01-02 00:46:26.936 1012 1024 I BluetoothAdapterState: Entering OffState
01-02 00:46:26.940 1012 1012 I bt_bluedroid: init
01-02 00:46:26.940 1012 1012 I bt_bluedroid:
01-02 00:46:26.940 1012 1012 I bt_bluedroid: ================> bluetooth.c: init function
01-02 00:46:26.955 1012 1025 I bt_stack_manager:
01-02 00:46:26.955 1012 1025 I bt_stack_manager: ++++++=============== BT_UTILS_MODULE init successfully
01-02 00:46:26.963 1012 1025 I bt_stack_manager:
01-02 00:46:26.963 1012 1025 I bt_stack_manager: ===================== BTIF_CONFIG_MODULE init successfully
01-02 00:46:26.970 1012 1025 I bt_main :
01-02 00:46:26.970 1012 1025 I bt_main : ============================> HCI LAYER got interface completed hci=-1350437239
01-02 00:46:26.970 1012 1025 I bt_bte_conf: bte_load_ble_conf attempt to load ble stack conf from /etc/bluetooth/ble_stack.conf
01-02 00:46:26.972 1012 1025 E bt_osi_config: config_new unable to open file '/etc/bluetooth/ble_stack.conf': No such file or directory
01-02 00:46:26.972 1012 1025 I bt_bte_conf: bte_load_ble_conf file >/etc/bluetooth/ble_stack.conf< not found
01-02 00:46:26.972 1012 1025 I bt_stack_config: init attempt to load stack conf from /etc/bluetooth/bt_stack.conf
01-02 00:46:26.973 1012 1025 I bt_btif_core:
01-02 00:46:26.973 1012 1025 I bt_btif_core: ===================== bte_main_boot_entry completed successfully
01-02 00:46:26.973 1012 1025 I bt_btif_core:
01-02 00:46:26.973 1012 1025 I bt_btif_core: =================== PROPERTY_BT_BDADDR_PATH getting /data/misc/bluetooth/bdaddr address 0 0 0 0 0 0
01-02 00:46:26.976 1012 1025 I bt_stack_manager:
01-02 00:46:26.976 1012 1025 I bt_stack_manager: ===================== btif_init_bluetooth init successfully
01-02 00:46:26.976 1012 1012 I bt_bluedroid: get_profile_interface socket
01-02 00:46:26.976 1012 1012 I bt_bluedroid:
01-02 00:46:26.976 1012 1012 I bt_bluedroid: ====================> get_profile_interface socket
01-02 00:46:26.976 1012 1012 I bt_bluedroid:
01-02 00:46:26.976 1012 1012 I bt_bluedroid: ================> bluetooth.c: get_adapter_property function type=2
01-02 00:46:26.977 1012 1012 I bt_bluedroid:
01-02 00:46:26.977 1012 1012 I bt_bluedroid: ================> bluetooth.c: get_adapter_property function type=1
01-02 00:46:26.978 1012 1028 I bt_btif_core:
01-02 00:46:26.978 1012 1028 I bt_btif_core: ===============> btif_core.c:bt_jni_msg_ready p_msg->event=40961
01-02 00:46:26.978 1012 1028 I bt_btif_core: btif_jni_associate Associating thread to JVM
01-02 00:46:26.979 1012 1028 I bt_btif_core:
01-02 00:46:26.979 1012 1028 I bt_btif_core: ===============> btif_core.c:bt_jni_msg_ready p_msg->event=40961
01-02 00:46:26.992 1012 1012 I bt_bluedroid: get_profile_interface sdp
01-02 00:46:26.992 1012 1012 I bt_bluedroid:
01-02 00:46:26.992 1012 1012 I bt_bluedroid: ====================> get_profile_interface sdp
01-02 00:46:26.999 441 441 D BluetoothManagerService: BluetoothServiceConnection: com.android.bluetooth.btservice.AdapterService
01-02 00:46:26.999 441 458 D BluetoothManagerService: Message: 40
01-02 00:46:27.000 441 458 D BluetoothManagerService: MESSAGE_BLUETOOTH_SERVICE_CONNECTED: 1
01-02 00:46:27.002 1012 1023 I bt_bluedroid: config_hci_snoop_log
01-02 00:46:27.004 441 458 D BluetoothManagerService: Calling onBluetoothServiceUp callbacks
01-02 00:46:27.004 441 458 D BluetoothManagerService: Broadcasting onBluetoothServiceUp() to 5 receivers.
01-02 00:46:27.011 1012 1028 D BluetoothAdapterProperties: Address is:00:23:A7:80:70:81
01-02 00:46:27.011 1012 1028 I bt_btif_core:
01-02 00:46:27.011 1012 1028 I bt_btif_core: ===============> btif_core.c:bt_jni_msg_ready p_msg->event=40961
01-02 00:46:27.013 441 441 D BluetoothManagerService: Bluetooth Adapter name changed to EVK_MX6SL
01-02 00:46:27.013 441 441 D BluetoothManagerService: Stored Bluetooth name: EVK_MX6SL
01-02 00:46:27.018 1012 1028 D BluetoothAdapterProperties: Name is: EVK_MX6SL
01-02 00:46:27.021 1012 1024 D BluetoothAdapterState: Current state: OFF, message: 0
01-02 00:46:27.026 1012 1024 D BluetoothAdapterProperties: Setting state to 14
01-02 00:46:27.026 1012 1024 I BluetoothAdapterState: Bluetooth adapter state changed: 10-> 14
01-02 00:46:27.027 441 458 D BluetoothManagerService: Message: 60
01-02 00:46:27.027 441 458 D BluetoothManagerService: MESSAGE_BLUETOOTH_STATE_CHANGE: prevState = 10, newState=14
01-02 00:46:27.027 441 458 D BluetoothManagerService: BLE State Change Intent: 10 -> 14
01-02 00:46:27.029 1012 1024 D BluetoothBondStateMachine: make
01-02 00:46:27.042 1012 1012 I BtGatt.JNI: classInitNative(L912): classInitNative: Success!
01-02 00:46:27.043 1012 1024 I BluetoothAdapterState: Entering PendingCommandState
01-02 00:46:27.050 1012 1029 I BluetoothBondStateMachine: StableState(): Entering Off State
01-02 00:46:27.051 1012 1012 D BluetoothAdapterService: getAdapterService() - returning com.android.bluetooth.btservice.AdapterService@7b58a9c
01-02 00:46:27.053 1012 1012 D BtGatt.DebugUtils: handleDebugAction() action=null
01-02 00:46:27.054 1012 1012 D BtGatt.GattService: Received start request. Starting profile...
01-02 00:46:27.054 1012 1012 D BtGatt.GattService: start()
01-02 00:46:27.059 1012 1012 I bt_bluedroid: get_profile_interface gatt
01-02 00:46:27.059 1012 1012 I bt_bluedroid:
01-02 00:46:27.059 1012 1012 I bt_bluedroid: ====================> get_profile_interface gatt
01-02 00:46:27.060 1012 1012 D BluetoothAdapterService: getAdapterService() - returning com.android.bluetooth.btservice.AdapterService@7b58a9c
01-02 00:46:27.060 1012 1012 D BtGatt.AdvertiseManager: advertise manager created
01-02 00:46:27.061 441 454 I ActivityManager: Waited long enough for: ServiceRecord{fcd61a1 u0 com.android.calendar/.alerts.InitAlarmsService}
01-02 00:46:27.069 1012 1012 V BluetoothAdapterState: isTurningOff()=false
01-02 00:46:27.070 1012 1012 V BluetoothAdapterState: isTurningOn()=false
01-02 00:46:27.070 1012 1012 V BluetoothAdapterState: isBleTurningOn()=true
01-02 00:46:27.077 1012 1012 V BluetoothAdapterState: isBleTurningOff()=false
01-02 00:46:27.079 1012 1024 D BluetoothAdapterState: Current state: PENDING_COMMAND, message: 4
01-02 00:46:27.079 1012 1024 I bt_bluedroid: enable
01-02 00:46:27.079 1012 1024 I bt_bluedroid:
01-02 00:46:27.079 1012 1024 I bt_bluedroid: ================> bluetooth.c: enable function
01-02 00:46:27.079 1012 1025 I bt_stack_manager:
01-02 00:46:27.079 1012 1025 I bt_stack_manager: ================ Stack initialized successfully
01-02 00:46:27.079 1012 1025 D bt_stack_manager: event_start_up_stack is bringing up the stack.
01-02 00:46:27.080 1012 1025 I bt_stack_manager:
01-02 00:46:27.080 1012 1025 I bt_stack_manager: =============== BTIF_CONFIG_MODULE module_start_up completed successfully
01-02 00:46:27.094 1012 1025 I bt_main :
01-02 00:46:27.094 1012 1025 I bt_main : =========== bte_main_enable BTSNOOP_MODULE start up successfully
01-02 00:46:27.094 1012 1025 I bt_hci : start_up
01-02 00:46:27.094 1012 1025 I bt_hci :
01-02 00:46:27.094 1012 1025 I bt_hci : =================================> hci_layer start_up fuction
01-02 00:46:27.107 1012 1025 I bt_vendor: alloc value 0xaf81fced
01-02 00:46:27.107 1012 1025 I bt_vendor: Redpine vendor init got called here!!!
01-02 00:46:27.144 1012 1025 I bt_vendor: Mutyam****protocol enable
01-02 00:46:27.144 1012 1025 I bt_vendor:
onebox_hdev_open: device `hci0' already running
01-02 00:46:28.144 1012 1025 I bt_vendor:
01-02 00:46:28.144 1012 1025 I bt_vendor: =================================> Before userial vendor init
01-02 00:46:28.144 1012 1025 I bt_vendor:
01-02 00:46:28.144 1012 1025 I bt_vendor: =================================> Before vendor call back init
01-02 00:46:28.144 1012 1025 I bt_vendor:
01-02 00:46:28.144 1012 1025 I bt_vendor: =================================> After vendor call back init
01-02 00:46:28.145 1012 1025 I bt_vendor:
01-02 00:46:28.145 1012 1025 I bt_vendor: =======> BT rsi vendor opcode 0
01-02 00:46:28.145 1012 1025 I bt_vendor:
01-02 00:46:28.145 1012 1025 I bt_vendor: =======> BT rsi vendor opcode 0
01-02 00:46:28.145 1012 1025 D bt_hci : start_up starting async portion
01-02 00:46:28.145 1012 1032 I bt_hci : event_finish_startup
01-02 00:46:28.145 1012 1032 I bt_hci_h4: hal_open
01-02 00:46:28.145 1012 1032 I bt_vendor:
01-02 00:46:28.145 1012 1032 I bt_vendor: =======> BT rsi vendor opcode 3
01-02 00:46:28.145 1012 1032 I bt_vendor:
01-02 00:46:28.145 1012 1032 I bt_vendor: =============> Before userial vendor open
01-02 00:46:28.150 1012 1032 I bt_vendor: device fd = 49 open
01-02 00:46:28.152 1012 1032 I bt_vendor:
01-02 00:46:28.152 1012 1032 I bt_vendor: =======> BT rsi vendor opcode 1
01-02 00:46:28.152 1012 1032 I bt_vendor: firmware callback
01-02 00:46:28.152 1012 1032 I bt_hci : firmware_config_callback
01-02 00:46:28.152 1012 1025 I bt_main :
01-02 00:46:28.152 1012 1025 I bt_main : =========== bte_main_enable HCI_MODULE start up successfully
01-02 00:46:28.159 1012 1032 W bt_hci : filter_incoming_event command complete event with no matching command. opcode: 0xc03.
01-02 00:46:28.168 1012 1040 I bt_btu : btu_task pending for preload complete event
01-02 00:46:28.168 1012 1040 I bt_btu_task: Bluetooth chip preload is complete
01-02 00:46:28.168 1012 1040 I bt_btu : btu_task received preload complete event
01-02 00:46:28.180 1012 1040 I bt_btu_task:
01-02 00:46:28.180 1012 1040 I bt_btu_task: ========================> btu_task.c:btu_init_core completed
01-02 00:46:28.183 1012 1040 I bt_btu_task:
01-02 00:46:28.183 1012 1040 I bt_btu_task: ========================> btu_task.c:BTE_InitStack completed
01-02 00:46:28.183 1012 1040 I bt_btu_task:
01-02 00:46:28.183 1012 1040 I bt_btu_task: ========================> btu_task.c:bta_sys_init completed
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_HCI
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_L2CAP
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_RFCOMM
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_AVDT
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_AVRC
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_A2D
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_BNEP
01-02 00:46:28.183 1012 1040 I : BTE_InitTraceLevels -- TRC_BTM
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_GAP
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_PAN
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_SDP
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_GATT
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_SMP
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_BTAPP
01-02 00:46:28.184 1012 1040 I : BTE_InitTraceLevels -- TRC_BTIF
01-02 00:46:28.184 1012 1040 I bt_btu_task:
01-02 00:46:28.184 1012 1040 I bt_btu_task: =================> bt jni thread initialization is ok
01-02 00:46:28.184 1012 1028 I bt_btif_core:
01-02 00:46:28.184 1012 1028 I bt_btif_core: ===============> btif_core.c:bt_jni_msg_ready p_msg->event=40961
01-02 00:46:28.184 1012 1028 I bt_btif_core:
01-02 00:46:28.184 1012 1028 I bt_btif_core: ==================> btif_task: received trigger stack init event
01-02 00:46:28.184 1012 1028 I bt_btif_core:
01-02 00:46:28.184 1012 1028 I bt_btif_core: =================> BTA_EnableBluetooth before
01-02 00:46:29.395 153 332 W audio_hw_primary: no standby

By default its moving to BLE mode.We don't want that So where I have to re-direct to BT Mode(state 10  to 11).

Please give solution for this issue.

Thanks in Advance.

[namratanalawade]

Anybody? Please help on above issue

[namratanalawade]

Hello everyone, 

I'm also using the same chipset RS9113 over SDIO interface. While bring up of BT/BLE i'm getting the below error- 

##########################################

01-01 00:01:40.123 1131 1145 I bt_hci : start_up
01-01 00:01:40.131 1131 1145 E bt_vendor: vendor_open unable to open libbt-vendor.so: dlopen failed: library "libbt-vendor.so" not found
--------- beginning of crash
01-01 00:01:40.131 1131 1145 F libc : system/bt/hci/src/vendor.c:94: send_command: assertion "lib_interface != NULL" failed
01-01 00:01:40.132 1131 1145 F libc : Fatal signal 6 (SIGABRT), code -6 in tid 1145 (bluedroid wake/)
01-01 00:01:40.233 154 154 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
01-01 00:01:40.233 154 154 F DEBUG : Build fingerprint: 'Freescale/evk_6sl/evk_6sl:6.0.1/2.0.0-ga-rc5/20160613:userdebug/release-keys'
01-01 00:01:40.233 154 154 F DEBUG : Revision: '0'
01-01 00:01:40.233 154 154 F DEBUG : ABI: 'arm'
01-01 00:01:40.233 154 154 F DEBUG : pid: 1131, tid: 1145, name: bluedroid wake/ >>> com.android.bluetooth <<<
01-01 00:01:40.233 154 154 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
01-01 00:01:40.261 154 154 F DEBUG : Abort message: 'system/bt/hci/src/vendor.c:94: send_command: assertion "lib_interface != NULL" failed'
01-01 00:01:40.262 154 154 F DEBUG : r0 00000000 r1 00000479 r2 00000006 r3 a381a978
01-01 00:01:40.263 154 154 F DEBUG : r4 a381a980 r5 a381a930 r6 00000002 r7 0000010c
01-01 00:01:40.263 154 154 F DEBUG : r8 b6cf0ec0 r9 00000000 sl 00000001 fp ab9f9fb4
01-01 00:01:40.263 154 154 F DEBUG : ip 00000006 sp a381a360 lr b6cb6fc5 pc b6cb93c0 cpsr 400f0010
01-01 00:01:40.296 154 154 F DEBUG :
01-01 00:01:40.296 154 154 F DEBUG : backtrace:
01-01 00:01:40.296 154 154 F DEBUG : #00 pc 000423c0 /system/lib/libc.so (tgkill+12)
01-01 00:01:40.297 154 154 F DEBUG : #01 pc 0003ffc1 /system/lib/libc.so (pthread_kill+32)
01-01 00:01:40.297 154 154 F DEBUG : #02 pc 0001c61f /system/lib/libc.so (raise+10)
01-01 00:01:40.297 154 154 F DEBUG : #03 pc 000197c1 /system/lib/libc.so (__libc_android_abort+34)
01-01 00:01:40.297 154 154 F DEBUG : #04 pc 000174b8 /system/lib/libc.so (abort+4)
01-01 00:01:40.298 154 154 F DEBUG : #05 pc 0001b233 /system/lib/libc.so (__libc_fatal+16)
01-01 00:01:40.298 154 154 F DEBUG : #06 pc 00019849 /system/lib/libc.so (__assert2+20)
01-01 00:01:40.298 154 154 F DEBUG : #07 pc 000edab1 /system/lib/hw/bluetooth.default.so
01-01 00:01:40.298 154 154 F DEBUG : #08 pc 000ec4f3 /system/lib/hw/bluetooth.default.so
01-01 00:01:40.298 154 154 F DEBUG : #09 pc 000ee785 /system/lib/hw/bluetooth.default.so
01-01 00:01:40.299 154 154 F DEBUG : #10 pc 000ee9b3 /system/lib/hw/bluetooth.default.so (module_start_up+78)
01-01 00:01:40.299 154 154 F DEBUG : #11 pc 00038197 /system/lib/hw/bluetooth.default.so (bte_main_enable+50)
01-01 00:01:40.299 154 154 F DEBUG : #12 pc 00064241 /system/lib/hw/bluetooth.default.so
01-01 00:01:40.299 154 154 F DEBUG : #13 pc 000f3929 /system/lib/hw/bluetooth.default.so
01-01 00:01:40.300 154 154 F DEBUG : #14 pc 000f291b /system/lib/hw/bluetooth.default.so
01-01 00:01:40.300 154 154 F DEBUG : #15 pc 000f387b /system/lib/hw/bluetooth.default.so
01-01 00:01:40.300 154 154 F DEBUG : #16 pc 0003f8c3 /system/lib/libc.so (__pthread_start(void*)+30)
01-01 00:01:40.300 154 154 F DEBUG : #17 pc 00019e55 /system/lib/libc.so (__start_thread+6)
01-01 00:01:40.919 154 154 F DEBUG :
01-01 00:01:40.919 154 154 F DEBUG : Tombstone written to: /data/tombstones/tombstone_00
01-01 00:01:40.919 154 154 E DEBUG : AM write failed: Broken pipe
01-01 00:01:40.921 446 463 I BootReceiver: Copying /data/tombstones/tombstone_00 to DropBox (SYSTEM_TOMBSTONE)
01-01 00:01:41.022 163 163 I Zygote : Process 1131 exited due to signal (6)
01-01 00:01:41.030 446 855 I ActivityManager: Process com.android.bluetooth (pid 1131) has died
01-01 00:01:41.031 446 464 E BluetoothManagerService: MESSAGE_BLUETOOTH_SERVICE_DISCONNECTED: 1
01-01 00:01:41.031 446 464 D BluetoothManagerService: Broadcasting onBluetoothServiceDown() to 4 receivers.
01-01 00:01:41.033 446 855 W ActivityManager: Scheduling restart of crashed service com.android.bluetooth/.gatt.GattService in 1000ms
01-01 00:01:41.033 446 855 W ActivityManager: Scheduling restart of crashed service com.android.bluetooth/.btservice.AdapterService in 1000ms
01-01 00:01:41.233 446 464 D BluetoothManagerService: MESSAGE_RESTART_BLUETOOTH_SERVICE: Restart IBluetooth service
01-01 00:01:41.254 446 464 I ActivityManager: Start proc 1160:com.android.bluetooth/1002 for service com.android.bluetooth/.btservice.AdapterService
01-01 00:01:41.430 1160 1160 D AdapterServiceConfig: Adding HeadsetService
01-01 00:01:41.430 1160 1160 D AdapterServiceConfig: Adding A2dpService
01-01 00:01:41.431 1160 1160 D AdapterServiceConfig: Adding HidService
01-01 00:01:41.431 1160 1160 D AdapterServiceConfig: Adding HealthService
01-01 00:01:41.431 1160 1160 D AdapterServiceConfig: Adding PanService
01-01 00:01:41.431 1160 1160 D AdapterServiceConfig: Adding GattService
01-01 00:01:41.432 1160 1160 D AdapterServiceConfig: Adding BluetoothMapService
01-01 00:01:41.446 446 464 D BluetoothManagerService: Added callback: android.bluetooth.IBluetoothManagerCallback$Stub$Proxy@feb0e05:true
01-01 00:01:41.447 1160 1160 D BluetoothAdapterState: make() - Creating AdapterState

##########################################

Can anybody pls tell which files to modify and how ? or share the modified files ?

Any immediate help would really be highly appreciated. Please help stuck on this for a long while !!