KEA128 CAN

cancel
Showing results for 
Show  only  | Search instead for 
Did you mean: 

KEA128 CAN

548 Views
lzhjxgz
Contributor I

我用KDS3.0生成库代码,生的CAN代码PE_ISR(CAN1_TxInterrupt),

ErrorFlags = MSCAN_PDD_GetRxStatusInterruptFlags(MSCAN_BASE_PTR); /* Read the status register */

if (
    ((ErrorFlags & MSCAN_PDD_RX_BUS_OFF) != MSCAN_PDD_RX_BUS_OFF)||         ((ErrorFlags & MSCAN_PDD_TX_BUS_OFF) != MSCAN_PDD_TX_BUS_OFF)
  )
  { /* Is bus-off detected? */
 
      DeviceDataPrv->Stats.BusOffs++;  /* Increase BusOffs interrupt counter */
      CAN1_OnBusOff(DeviceDataPrv->UserData); /* Invoke user event */
    }
MSCAN_PDD_RX_BUS_OFF为0x30,查看手册中 MSCAN_CANRFLG ,bit5-4中为0b11时总线离线,但代码中判断不为0b11则为离线。

LDD_TError CAN1_GetError(LDD_TDeviceData *DeviceDataPtr, LDD_CAN_TErrorMask *ErrorMaskPtr)
{
CAN1_TDeviceData *DeviceDataPrv = (CAN1_TDeviceData *)DeviceDataPtr;

/* {Default RTOS Adapter} Critical section begin, general PE function is used */
EnterCritical();
*ErrorMaskPtr = DeviceDataPrv->ErrorMask; /* Return last value of error mask */
DeviceDataPrv->ErrorMask = 0x00U;
/* {Default RTOS Adapter} Critical section end, general PE function is used */
ExitCritical();
return ERR_OK;
}

DeviceDataPrv->ErrorMask = 0x00U;,查看代码ErrorMask 为内存中数据,为什么ErrorMask 清零后总线可以立刻恢复。

Labels (1)
0 Kudos
Reply
1 Reply

453 Views
Alice_Yang
NXP TechSupport
NXP TechSupport

HI @lzhjxgz 

Thanks for your patience.

1.Regarding “MSCAN_PDD_RX_BUS_OFF为0x30,查看手册中 MSCAN_CANRFLG ,bit5-4中为0b11时总线离线,但代码中判断不为0b11则为离线”,

->> I agree with you — the Bus‑Off detection logic in the code is indeed opposite to what is described in the hardware manual.
Please the code manually and check whether it works correctly. I will also report this issue to the internal team.

2. For  second question, I think there is no relationship between clearing ErrorMask and the CAN bus being restored. The Bus‑Off recovery is handled entirely by the hardware mechanism.

 

Thank you.

 

BR

Alice

0 Kudos
Reply
%3CLINGO-SUB%20id%3D%22lingo-sub-2333124%22%20slang%3D%22zh-CN%22%20mode%3D%22CREATE%22%3EKEA128%20CAN%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-2333124%22%20slang%3D%22zh-CN%22%20mode%3D%22CREATE%22%3E%3CP%3EI%20used%20KDS3.0%20to%20generate%20the%20library%20code%2C%20the%20raw%20CAN%20code%20PE_ISR(CAN1_TxInterrupt).%3C%2FP%3E%3CP%3EErrorFlags%20%3D%20MSCAN_PDD_GetRxStatusInterruptFlags(MSCAN_BASE_PTR)%3B%20%2F*%20Read%20the%20status%20register%20*%2F%3C%2FP%3E%3CDIV%3Eif%20(%3C%2FDIV%3E%3CDIV%3E%20%20%20%20((ErrorFlags%20%26amp%3B%20MSCAN_PDD_RX_BUS_OFF)%20!%20%3D%20MSCAN_PDD_RX_BUS_OFF)%7C%7C%20((ErrorFlags%20%26amp%3B%20MSCAN_PDD_TX_BUS_OFF)%20!%20%3D%20MSCAN_PDD_TX_BUS_OFF)%3C%2FDIV%3E%3CDIV%3E%20%20)%3C%2FDIV%3E%3CDIV%3E%20%20%7B%20%2F*%20Is%20bus-off%20detected%3F%20*%2F%3C%2FDIV%3E%3CDIV%3E%26nbsp%3B%3C%2FDIV%3E%3CDIV%3E%3CSPAN%3E%20%20%20%20%20%20DeviceDataPrv-%20%26gt%3BStats.BusOffs%2B%2B%3B%20%2F*%20Increase%20BusOffs%20interrupt%20counter%20*%2F%3C%2FSPAN%3E%3C%2FDIV%3E%3CDIV%3E%20%20%20%20%20%20CAN1_OnBusOff(DeviceDataPrv-%20%26gt%3BUserData)%3B%20%2F*%20Invoke%20user%20event%20*%2F%3C%2FDIV%3E%3CDIV%3E%20%20%20%20%7D%3C%2FDIV%3E%3CDIV%3EMSCAN_PDD_RX_BUS_OFF%20is%200x30%2C%20check%20the%20manual%20%3CSPAN%20class%3D%22%22%3EMSCAN_CANRFLG%3C%2FSPAN%3E%2C%20bit5-4%20is%200b11%20when%20the%20bus%20is%20offline%2C%20but%20the%20code%20determines%20that%20it%20is%20offline%20if%20it%20is%20not%200b11.%3C%2FDIV%3E%3CDIV%3E%3CP%3ELDD_TError%20CAN1_GetError(LDD_TDeviceData%20*DeviceDataPtr%2C%20LDD_CAN_TErrorMask%20*ErrorMaskPtr)%20%3CBR%20%2F%3E%7B%20%3CBR%20%2F%3ECAN1_TDeviceData%20*DeviceDataPrv%20%3D%20(CAN1_%20TDeviceData%20*)DeviceDataPtr%3B%3C%2FP%3E%3CP%3E%2F*%20%7BDefault%20RTOS%20Adapter%7D%20Critical%20section%20begin%2C%20general%20PE%20function%20is%20used%20*%2F%20%3CBR%20%2F%3EEnterCritical()%3B%20%3CBR%20%2F%3E*ErrorMaskPtr%20%3D%20DeviceDataPrv-%20%26gt%3BErrorMask%3B%20%2F*%20Return%20last%20value%20of%20error%20mask%20*%2F%20DeviceDataPrv-%20ErrorMask%20%3D%200x00U%3B%20%20Return%20last%20value%20of%20error%20mask%20*%2F%20%3CBR%20%2F%3EDeviceDataPrv-%20%26gt%3BErrorMask%20%3D%200x00U%3B%20%3CBR%20%2F%3E%2F*%20%7BDefault%20RTOS%20Adapter%7D%20Critical%20section%20end%2C%20general%20PE%20function%20is%20used%20*%2F%20%3CBR%20%2F%3EExitCritical()%3B%20%3CBR%20%2F%3Ereturn%20ERR_OK%3B%20%3CBR%20%2F%3E%7D%3C%2FP%3E%3CP%3EDeviceDataPrv-%20%26gt%3BErrorMask%20%3D%200x00U%3B%2C%20check%20the%20code%20ErrorMask%20for%20in-memory%20data%2C%20why%20the%20bus%20can%20be%20restored%20immediately%20after%20ErrorMask%20is%20cleared.%3C%2FP%3E%3C%2FDIV%3E%3C%2FLINGO-BODY%3E%3CLINGO-LABS%20id%3D%22lingo-labs-2333124%22%20slang%3D%22zh-CN%22%20mode%3D%22CREATE%22%3E%3CLINGO-LABEL%3EKinetis%20EA%20Series%20MCUs%3C%2FLINGO-LABEL%3E%3C%2FLINGO-LABS%3E%3CLINGO-SUB%20id%3D%22lingo-sub-2336746%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%20translate%3D%22no%22%3ERe%3A%20KEA128%20CAN%3C%2FLINGO-SUB%3E%3CLINGO-BODY%20id%3D%22lingo-body-2336746%22%20slang%3D%22en-US%22%20mode%3D%22CREATE%22%3E%3CP%3EHI%26nbsp%3B%3CA%20href%3D%22https%3A%2F%2Fcommunity.nxp.com%2Ft5%2Fuser%2Fviewprofilepage%2Fuser-id%2F260710%22%20target%3D%22_blank%22%3E%40lzhjxgz%3C%2FA%3E%26nbsp%3B%3C%2FP%3E%0A%3CDIV%3E%0A%3CP%3EThanks%20for%20your%20patience.%3C%2FP%3E%0A%3CP%3E1.Regarding%20%E2%80%9C%3CSPAN%3EMSCAN_PDD_RX_BUS_OFF%E4%B8%BA0x30%EF%BC%8C%E6%9F%A5%E7%9C%8B%E6%89%8B%E5%86%8C%E4%B8%AD%26nbsp%3B%3C%2FSPAN%3E%3CSPAN%20class%3D%22%22%3EMSCAN_CANRFLG%3C%2FSPAN%3E%3CSPAN%3E%26nbsp%3B%EF%BC%8Cbit5-4%E4%B8%AD%E4%B8%BA0b11%E6%97%B6%E6%80%BB%E7%BA%BF%E7%A6%BB%E7%BA%BF%EF%BC%8C%E4%BD%86%E4%BB%A3%E7%A0%81%E4%B8%AD%E5%88%A4%E6%96%AD%E4%B8%8D%E4%B8%BA0b11%E5%88%99%E4%B8%BA%E7%A6%BB%E7%BA%BF%3C%2FSPAN%3E%E2%80%9D%2C%3C%2FP%3E%0A%3CP%3E-%26gt%3B%26gt%3B%20I%20agree%20with%20you%20%E2%80%94%20the%20Bus%E2%80%91Off%20detection%20logic%20in%20the%20code%20is%20indeed%20opposite%20to%20what%20is%20described%20in%20the%20hardware%20manual.%3CBR%20%2F%3EPlease%20the%20code%20manually%20and%20check%20whether%20it%20works%20correctly.%20I%20will%20also%20report%20this%20issue%20to%20the%20internal%20team.%3C%2FP%3E%0A%3CP%3E2.%20For%26nbsp%3B%20second%20question%2C%20I%20think%20there%20is%20no%20relationship%20between%20clearing%20%3CCODE%3EErrorMask%3C%2FCODE%3E%20and%20the%20CAN%20bus%20being%20restored.%20The%20Bus%E2%80%91Off%20recovery%20is%20handled%20entirely%20by%20the%20hardware%20mechanism.%3C%2FP%3E%0A%3CBR%20%2F%3E%0A%3CP%3EThank%20you.%3C%2FP%3E%0A%3CBR%20%2F%3E%0A%3CP%3EBR%3C%2FP%3E%0A%3CP%3EAlice%3C%2FP%3E%0A%3C%2FDIV%3E%3C%2FLINGO-BODY%3E