Hi,
First of all, Freescale, I hate your datasheets !
But I like the forum, anyway... 
I'm living interesting problem with I2C and EEPROM AT24C512BN.
If I debug test routine below, it works, "count" be equal to "okunan".
If I directly run the code, it fails at EE_ReadBuffer function. The function returns 0.
Code:
Test routine: count = 0x89654321; // unsigned long
Init_i2c(); if(EE_WriteBuffer(0, &count, 4, I2C_ADR_EEPROM0)) DispMsg(MSG_FILL, 0); else DispMsg(MSG_ERROR_CODE, 1); if(EE_ReadBuffer(0, &okunan, 4, I2C_ADR_EEPROM0)) DispMsg(MSG_FILL, 0); else DispMsg(MSG_ERROR_CODE, 2); if(count == okunan) DispMsg(MSG_FILL, 0); else DispMsg(MSG_ERROR_CODE, 3);
If I change the i2c_start() function such as below: It start working in debug or not.
Code:
void i2c_start(void){ IIC1S_SRW = 0; // R/W bit = 0; IIC1C_IICEN = 0; IIC1C = 0b10011000; IIC1C_MST = 1; // generate START condition}I don't understand the problem due to the datasheet doesn't explain I2C module well.
Regards,
BP.
Code:
void Init_i2c(void){ // Bus = 18.432MHz; // mul=4, ICR=0x0D => SCL Div=48, i2c_ Bus Freq = 96Khz, SDA Hold Time = 600ns IIC1F = 0b10001101; IIC1S_SRW = 0; // R/W bit = 0; // Enable i2c module // not generate ACK by master after transfer; // TX mode // Slave mode actually; IIC1C = 0b10011000; }void i2c_start(void){ IIC1C_MST = 1; // generate START condition}void i2c_stop(void){ IIC1C_MST = 0; // generate STOP condition; }void i2c_restart(void){ IIC1C_RSTA = 1; // generate RESTART condition}void i2c_sendbyte(unsigned char data){ IIC1C_TX = 1; // transmit IIC1D = data; while(!IIC1S_IICIF); // wait until Transfer to complete; IIC1S_IICIF = 1;}char i2c_getack(void){ return(!IIC1S_RXAK); // ACK gelmiş ise 1 döner, gelmemişse 0}unsigned char i2c_getbyte(char send_ack){ unsigned char data; IIC1C_TX = 0; // set up to receive; IIC1C_TXAK = send_ack—0:1; data = IIC1D; // dummy read; while(!IIC1S_IICIF); // wait until Transfer to complete; IIC1S_IICIF = 1; data = IIC1D; // read right data; return(data);}/////////////////////////////////////////////////////////////////////////////////// EEPROM RUTINLERI Atmel AT24C512BN-SH-B veya ST M24512-RM/////////////////////////////////////////////////////////////////////////////////unsigned char EE_WaitForACK(unsigned char external_adr){ unsigned char counter = 100; unsigned char ack; unsigned char ControlByte = 0b10100000; // Yazma modu, A2, A1, A0 = 0 ControlByte |= ((external_adr << 1) & 0b00001110); do { i2c_start(); i2c_sendbyte(ControlByte); ack = i2c_getack(); // i2cgetack, ack alınmış ise 1 döner! i2c_stop(); --counter; // her deneme 175uS sürüyor, 29 deneme > 5ms yapar. } while(!ack && (counter != 0)); return(ack);}unsigned char EE_ReadBuffer(unsigned int Adr, unsigned char* Data, unsigned int size, unsigned char external_adr){ // Control Byte = 1 0 1 0 A2 A1 A0 R/W. unsigned char ControlByte = 0b10100000; // Yazma modu, A2, A1, A0 = 0 unsigned char AddrHigh = (Adr >> 8) & 0xFF; unsigned char AddrLow = (Adr & 0xFF); ControlByte |= ((external_adr << 1) & 0b00001110); i2c_start(); // Control Byte = 1 0 1 0 A2 A1 A0 R/W i2c_sendbyte(ControlByte); if(!i2c_getack()) { i2c_stop(); return(0); } // Address High Byte i2c_sendbyte(AddrHigh); if(!i2c_getack()) { i2c_stop(); return(0); } // Address Low Byte i2c_sendbyte(AddrLow); if(!i2c_getack()) { i2c_stop(); return(0); } // Read i2c_restart(); // Control Byte to read ControlByte |= 0b00000001; // Okuma modu i2c_sendbyte(ControlByte); if(!i2c_getack()) { i2c_stop(); return(0); } do { *Data++ = i2c_getbyte(size != 1); } while(--size); i2c_stop(); return(1);}char EE_WriteBuffer(unsigned int Adr, unsigned char* Data, unsigned int size, unsigned char external_adr){ unsigned int _PAGE = 0xFFFF; // önceki page do { unsigned int CURRENT_PAGE = Adr & 0b1111111110000000; // page size 128 byte if(CURRENT_PAGE != _PAGE) { // Control Byte = 1 0 1 0 A2 A1 A0 R/W. unsigned char ControlByte = 0b10100000; // Yazma modu, A2, A1, A0 = 0 unsigned char AddrHigh = (Adr >> 8) & 0xFF; unsigned char AddrLow = (Adr & 0xFF); ControlByte |= ((external_adr << 1) & 0b00001110); if(_PAGE != 0xFFFF) { i2c_stop(); if(!EE_WaitForACK(external_adr)) return(0); } i2c_start(); // Control Byte = 1 0 1 0 A2 A1 A0 R/W. i2c_sendbyte(ControlByte); if(!i2c_getack()) { i2c_stop(); return(0); } // Address High Byte i2c_sendbyte(AddrHigh); if(!i2c_getack()) { i2c_stop(); return(0); } // Address Low Byte i2c_sendbyte(AddrLow); if(!i2c_getack()) { i2c_stop(); return(0); } _PAGE = CURRENT_PAGE; } //if(CURRENT_PAGE != _PAGE) i2c_sendbyte(*Data++); if(!i2c_getack()) { i2c_stop(); return(0); } Adr++; } while(--size); i2c_stop(); return(EE_WaitForACK(external_adr));}Message Edited by BasePointer on 2007-09-12 04:50 PM
Just to give you and Idea on what it takes to make this module to roll data out without a problem in Poll mode.
I am using some software semaphores so the code may not be easily portable but I am sharing this code so that you get to see some of what works. This is the same module as the one you are using the bit names have a small modification but it should be simple to make sense of the names. I left most of my comments in the code and I hope they help,. 10K pull up values are going to give you problems. I go for 5Ks if I were you.
I avoid do, while statements as they generate brclr/sets and those instructions tend to get stuck depending on the condition required. I always like the routine to return and error code and exit.
Regards,
Ed
//*****************************************************************//
//Inputs: char ID,char Read_Write,char NumberBytes
//Outputs: IIC_Accepted
//Inputs: char ID,char Read_Write,char NumberBytes
//Outputs: IIC_Accepted
// Calling format : ack_flag=Send_IIC_Address(Control1,RW1,Total_Bytes)
//*****************************************************************//
char Send_IIC_Address(char ID,char Read_Write,char NumberBytes)
{
char IIC_Accepted;
IIC_Accepted=0;
if(Slave_Flag==0)// if driver intends to be in Master mode
{
IBIF=1;
TX_RX_=1; // from master to slave
MS_SL_=1; // send START on clean slate
}
ID=ID<<1;
if(MS_SL_==1 && TX_RX_==1)
{
IIC_Delay(1000000);//spacing between start and char.
// should not be needed to ensure byte reception
//*****************************************************************//
char Send_IIC_Address(char ID,char Read_Write,char NumberBytes)
{
char IIC_Accepted;
IIC_Accepted=0;
if(Slave_Flag==0)// if driver intends to be in Master mode
{
IBIF=1;
TX_RX_=1; // from master to slave
MS_SL_=1; // send START on clean slate
}
ID=ID<<1;
if(MS_SL_==1 && TX_RX_==1)
{
IIC_Delay(1000000);//spacing between start and char.
// should not be needed to ensure byte reception
// continuity.
if(Packet_Status==0)//
{
IIC_DATA_ARRAY[0]=NumberBytes;
IIC_Byte_Counter=0;
Send(ID | Read_Write);
}
//IBDR=ID | Read_Write;// or the SRW bit with Address ID.
//IIC_Delay(100);// worked polled at 900 at 968usec from end of last to begin of next.
// worked polled at 500 at 59usec from ID to first byte.
if(RXAK==0)
{
IIC_Accepted=PORTB;
IIC_Accepted=IIC_Accepted & 0xF7;
PORTB=IIC_Accepted;// Turn on LED4 to indicate packet is transfer.
if(Packet_Status==0)//
{
IIC_DATA_ARRAY[0]=NumberBytes;
IIC_Byte_Counter=0;
Send(ID | Read_Write);
}
//IBDR=ID | Read_Write;// or the SRW bit with Address ID.
//IIC_Delay(100);// worked polled at 900 at 968usec from end of last to begin of next.
// worked polled at 500 at 59usec from ID to first byte.
if(RXAK==0)
{
IIC_Accepted=PORTB;
IIC_Accepted=IIC_Accepted & 0xF7;
PORTB=IIC_Accepted;// Turn on LED4 to indicate packet is transfer.
if(Read_Write==1)
Slave_Flag=0;// master mode
IIC_Accepted=1;//Everything is cool let's get running
// Packet_Status=1; // handled in the interrupt when polled here
}
else
MS_SL_=0;// sending stop
}
else
{
IBEN=0;
IBEN=1;// Bus is gone crazy
MS_SL_=1;// sending START
}
return IIC_Accepted;// if char =0 no response from slave node.
}
Slave_Flag=0;// master mode
IIC_Accepted=1;//Everything is cool let's get running
// Packet_Status=1; // handled in the interrupt when polled here
}
else
MS_SL_=0;// sending stop
}
else
{
IBEN=0;
IBEN=1;// Bus is gone crazy
MS_SL_=1;// sending START
}
return IIC_Accepted;// if char =0 no response from slave node.
}
**************************************************************************************************************
//Description. Send packet will send a series of packets with
//incremental data n to n-1 where n-1=Number_Bytes-1 bytes.
char Send_Packet_Polled(char Number_Bytes)
{// send
char Byte_Counter=0;
char error_flag;
char Return_Val=0;
char Number_Fail=0;
char Number_Pass=0;
char chase_flag=1;
while(chase_flag==1)
{
Return_Val=Send_IIC_Address(0x0E,0,4);//wp0xe
if (Return_Val==1)// good case.
{
Number_Pass++;
chase_flag=false;
}else
{
Number_Fail++;
Byte_Counter=0;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}
//incremental data n to n-1 where n-1=Number_Bytes-1 bytes.
char Send_Packet_Polled(char Number_Bytes)
{// send
char Byte_Counter=0;
char error_flag;
char Return_Val=0;
char Number_Fail=0;
char Number_Pass=0;
char chase_flag=1;
while(chase_flag==1)
{
Return_Val=Send_IIC_Address(0x0E,0,4);//wp0xe
if (Return_Val==1)// good case.
{
Number_Pass++;
chase_flag=false;
}else
{
Number_Fail++;
Byte_Counter=0;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}
}// end of while char_flag
for (Byte_Counter=0;Byte_Counter<=Number_Bytes
{
// working with 7 but no second packet was moved to else.
if(IBIF==1)
{
if(RXAK==0)
{
//400 456 uSec works on packet only
//500 568 uSec works
//600 because START always given a macth hard to code
if(MS_SL_==1)
{
if(TX_RX_=1)
{
IIC_Delay(900000);/// could do a while (IBIF==1)
IBDR=Byte_Counter; // to generate brclr instruction.
IIC_Delay(60);//100= 56usec working
// 60=10usec spacing between bytes. Real
Byte_Counter++; // 55=8usec and not working real
// 60 EM does not
// 70 no
// 100
// 200
}
}
else
{
Byte_Counter=Number_Bytes+1;
return Byte_Counter;
}
}// end of else RXAK==0;
if(RXAK==1)
{
error_flag=1;// abnormal condition
Byte_Counter=Number_Bytes+1;
MS_SL_=0;// send stop
IBIE=0;
TX_RX_=1;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}// end of if no ack from slave
}// end of if(IBIF==1) case.
else
{//
Byte_Counter = Number_Bytes-1;
}// end of if(IBIF==0) case.
// end of good case
if(Byte_Counter == Number_Bytes-1)
{
error_flag=0;//normal condition
Byte_Counter=Number_Bytes+1;// end this loop
MS_SL_=0;// send stop
IBIE=0;
TX_RX_=1;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}
}// end of send Number_Bytes polled for loop.
{
// working with 7 but no second packet was moved to else.
if(IBIF==1)
{
if(RXAK==0)
{
//400 456 uSec works on packet only
//500 568 uSec works
//600 because START always given a macth hard to code
if(MS_SL_==1)
{
if(TX_RX_=1)
{
IIC_Delay(900000);/// could do a while (IBIF==1)
IBDR=Byte_Counter; // to generate brclr instruction.
IIC_Delay(60);//100= 56usec working
// 60=10usec spacing between bytes. Real
Byte_Counter++; // 55=8usec and not working real
// 60 EM does not
// 70 no
// 100
// 200
}
}
else
{
Byte_Counter=Number_Bytes+1;
return Byte_Counter;
}
}// end of else RXAK==0;
if(RXAK==1)
{
error_flag=1;// abnormal condition
Byte_Counter=Number_Bytes+1;
MS_SL_=0;// send stop
IBIE=0;
TX_RX_=1;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}// end of if no ack from slave
}// end of if(IBIF==1) case.
else
{//
Byte_Counter = Number_Bytes-1;
}// end of if(IBIF==0) case.
// end of good case
if(Byte_Counter == Number_Bytes-1)
{
error_flag=0;//normal condition
Byte_Counter=Number_Bytes+1;// end this loop
MS_SL_=0;// send stop
IBIE=0;
TX_RX_=1;
return Byte_Counter;// Returns Number_Bytes-1 as completion flag
}
}// end of send Number_Bytes polled for loop.
}// end of send Packet Polled.
