Patch suggestion for linux-imx busfreq-imx8mq driver

cancel
Showing results for 
Show  only  | Search instead for 
Did you mean: 

Patch suggestion for linux-imx busfreq-imx8mq driver

Jump to solution
417 Views
wouher
Contributor II

Hi NXP,

Please consider the patch below for linux-imx. I tested this on branch lf-6.6.52-2.2.0 (imx8mm/imx8mn hardware), but it also applies on older branches.

When switching DDR frequency, the busfreq driver will always make a print to the kernel log buffer via printk().
In a use case where the DDR frequency switches often, this leads to spamming the log buffer.
We encountered this exact case, and all other messages from the dmesg buffer are pushed out as a consequence.

Using pr_debug() will depend on the definition of DEBUG and will not spam dmesg by default.

diff --git a/drivers/soc/imx/busfreq-imx8mq.c b/drivers/soc/imx/busfreq-imx8mq.c
index 5e36962285ef..9914d19183be 100644
--- a/drivers/soc/imx/busfreq-imx8mq.c
+++ b/drivers/soc/imx/busfreq-imx8mq.c
@@ -205,9 +205,9 @@ static void reduce_bus_freq(void)
}

if (audio_bus_freq_mode)
- printk(KERN_DEBUG "ddrc freq set to audio bus mode\n");
+ pr_debug("ddrc freq set to audio bus mode\n");
if (low_bus_freq_mode)
- printk(KERN_DEBUG "ddrc freq set to low bus mode\n");
+ pr_debug("ddrc freq set to low bus mode\n");
}

static void reduce_bus_freq_handler(struct work_struct *work)
@@ -296,7 +296,7 @@ static int set_high_bus_freq(int high_bus_freq)
cur_bus_freq_mode = BUS_FREQ_HIGH;

if (high_bus_freq_mode)
- printk(KERN_DEBUG "ddrc freq set to high bus mode\n");
+ pr_debug("ddrc freq set to high bus mode\n");

return 0;
}

Labels (1)
0 Kudos
Reply
1 Solution
385 Views
JosephAtNXP
NXP TechSupport
NXP TechSupport

Hi,

Thank you for your interest in NXP Semiconductor products,

Thanks for the suggestion, I will pass it down to the software team.

Regards

View solution in original post

0 Kudos
Reply
1 Reply
386 Views
JosephAtNXP
NXP TechSupport
NXP TechSupport

Hi,

Thank you for your interest in NXP Semiconductor products,

Thanks for the suggestion, I will pass it down to the software team.

Regards

0 Kudos
Reply