Possible BUG REPORT against 5.0 USB Stack, file usb_audio.c, at line 767

cancel
Showing results for 
Show  only  | Search instead for 
Did you mean: 

Possible BUG REPORT against 5.0 USB Stack, file usb_audio.c, at line 767

480 Views
johnstrohm
Contributor III

In file Freescale_BM_USB_Stack_v5.0/Src/usb_core/device/sources/classes/audio/usb_audio.c, at line 767, you have (reformatted for readability):

    error = audio_obj_ptr->class_specific_callback.callback((uint8_t)GET_CUR_COPY_PROTECT_CONTROL,

                                                            audio_obj_ptr->current_interface,

                                                            data,

                                                            size,

                                                            audio_obj_ptr->class_specific_callback.arg);

EVERY other call to the class_specific_callback that involves audio_obj_ptr->current_interface is of the form:

    error = audio_obj_ptr->class_specific_callback.callback(audio_obj_ptr->current_interface,

                                                            cmd,

                                                            data,

                                                            size,

                                                            audio_obj_ptr->class_specific_callback.arg);

It appears to me that the call at line 767 is incorrect, and should instead be:

    error = audio_obj_ptr->class_specific_callback.callback(audio_obj_ptr->current_interface,

                                                            (uint8_t)GET_CUR_COPY_PROTECT_CONTROL,

                                                            data,

                                                            size,

                                                            audio_obj_ptr->class_specific_callback.arg);

Labels (2)
Tags (3)
0 Kudos
1 Reply

365 Views
Jorge_Gonzalez
NXP Employee
NXP Employee

Hello John:

It seems you are correct, thanks a lot for reporting this. I will report it to our USB stack developers.

Regards!

Jorge Gonzalez

0 Kudos