Pfuze100: set suspend mode and voltage callbacks not implemented

[SebastienFabre]

Hello,

In regulator_ops structure, set_suspend_mode and set_suspend_voltage callbacks can be set to respectively "set regulator suspend operating mode" and "set regulator suspend voltage". These callbacks can be called with values retrieved from device tree.

Why these callbacks are not implemented in pfuze100-regulator.c? Is there another way to set suspend mode and voltage ?

I found an old patch (https://lwn.net/Articles/558258/) that implements the regulator with set_suspend_voltage callback but it has not been integrated.

Best regards,

Sébastien

[igorpadykov]

Hi Sebastien

patch was sent to mainline linux (linux-kernel@vger.kernel.org) and one can post question

on kernel mail list   http://vger.kernel.org/vger-lists.html

NXP uses different linux, difference is described on

https://community.nxp.com/t5/i-MX-Processors/difference-between-Yocto-Community-BSP-and-Freescale-BS...

Best regards
igor

[SebastienFabre]

Hi Igor,

I have found some responses about the first version of the patch and it was not about the set_suspend_voltage callback: https://marc.info/?t=137335165300001&r=1&w=2. The second version of the patch no more contains the callback: https://marc.info/?t=137360353000002&r=1&w=3. The patch finally integrated in mainline is the following: https://github.com/torvalds/linux/commit/3784b6d64dc52ed3fbebad61a85ab9b7a687a167#diff-86d36cb6f577d....

These callbacks are also not present for pfuze100 regulator in linux-imx and linux-fslc(-imx). Is there a reason not to add them?

According to the document about PF0100, output voltage during standby mode and switching operating mode seems to not be configurable using OTP.

Best regards,

Sébastien

[igorpadykov]

Hi Sébastien

these kernels are different as explaned on below links and maintained by different teams

https://www.yoctoproject.org/pipermail/meta-freescale/2018-August/023214.html

https://www.yoctoproject.org/pipermail/meta-freescale/2018-August/023172.html

https://lists.yoctoproject.org/g/meta-freescale/topic/imx6dl_dunfell_and_kernel/80897983?p=,,,20,0,0...

So question "why it is not implemented on some kernel" should be posted on appropriate

mail list, for example for "linux-fslc" to meta-fsl-arm mailing list:

https://lists.yoctoproject.org/g/meta-freescale

Best regards
igor