Using K64F, SDK 2.8, apparent bug in fsl_i2c_edma.c version 2.08.
Found by running Eclipse built-in code analysis on my project; note error below:
Line 421 is clearly wrong but I don't know what it SHOULD be.
Perhaps NXP should also use static analysis tools...
Please confirm this bug and provide a solution,
Thanks,
Best Regards, Dave
@danielchen- Can you please confirm:
- the responsible developer has reviewed the code and recommended to simply remove the line with no other changes.
Thanks!
Best Regards, Dave
Yes.
@danielchen- "Seems redundant" is not a great answer.
Don't you think it would be best to check with the developer what was intended here?
Thanks,
Best Regards, Dave
Hi @davenadler
This redundant line is introduced unexpectedly. Will remove this code. Sorry for the inconvenience.
Thanks again.
Regards
Daniel
Hi Dave:
Thanks for your feedback. It seems a redundant line. Because base is reassigned to
s_i2cEdmaPrivateHandle[instance].base in following line.
/* Set the base for the handle. */
base = base;
/* Set the handle for EDMA. */
handle->dmaHandle = edmaHandle;
s_i2cEdmaPrivateHandle[instance].base = base;
s_i2cEdmaPrivateHandle[instance].handle = handle;
Regards
Daniel