EULA checksum is bad for release imx-5.4.24-2.1.0.xml

[JohnKlug]

If one starts by downloading this version of poky/imx:

repo init -u https://source.codeaurora.org/external/imx/imx-manifest -b imx-linux-zeus -m imx-5.4.24-2.1.0.xml

The meta-imx repo had bad md5sums for the license.

The old license (V11) was:
228c72f2a91452b8a03c4cab30f30ef9 EULA.txt

The new license is:
1b4db4b25c3a1e422c0c0ed64feb65d2 EULA.txt

You can find the old license in the following recipes:

/meta-bsp/recipes-security/ml-security/ml-security_1.0.2.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-multimedia/imx-codec/imx-codec_4.5.5.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-multimedia/imx-sw-pdm/imx-sw-pdm_1.0.0.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9" 
./meta-bsp/recipes-multimedia/imx-vpuwrap/imx-vpuwrap_4.5.5.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-multimedia/imx-parser/imx-parser_4.5.5.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/imx-seco/imx-seco-libs_git.bb:LIC_FILES_CHKSUM = "file://EULA.txt;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/imx-seco/imx-seco_3.6.3.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9" 
./meta-bsp/recipes-bsp/imx-vpu-hantro-vc/imx-vpu-hantro-vc_1.1.0.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/imx-vpu/imx-vpu_5.4.39.3.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/imx-vpu-hantro/imx-vpu-hantro_1.18.0.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9" 
./meta-bsp/recipes-bsp/firmware-imx/firmware-imx-8.8.inc:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/isp-imx/isp-imx_4.0.8.2.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-bsp/isp-imx/basler-camera_1.0.2.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/conf/layer.conf:FSL_EULA_FILE_MD5SUM_LA_OPT_NXP_SOFTWARE_LICENSE_V11 = "228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-graphics/imx-gpu-viv/imx-gpu-viv_6.4.0.p2.4-aarch64.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-graphics/imx-gpu-viv/imx-gpu-viv_6.4.0.p2.4-aarch32.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.8.7.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"
./meta-bsp/recipes-graphics/imx-gpu-g2d/imx-gpu-g2d_6.4.0.p2.4.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9" 
./meta-sdk/recipes-fsl/m4-demos/imx-m7-demos_2.8.0.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9" 
./meta-sdk/recipes-fsl/m4-demos/imx-m4-demos_2.8.0.bb:LIC_FILES_CHKSUM = "file://COPYING;md5=228c72f2a91452b8a03c4cab30f30ef9"

For instance the firmware file build fails.

ERROR: firmware-imx-1_8.8-r0 do_populate_lic: QA Issue: firmware-imx: The LIC_FILES_CHKSUM does not match for file:///home/jenkins/workspace/mlinux/mtcap3-nxp/poky-build/sources/meta-imx/meta-bsp/../EULA.txt;md5=228c72f2a91452b8a03c4cab30f30ef9
firmware-imx: The new md5 checksum is 1b4db4b25c3a1e422c0c0ed64feb65d2
firmware-imx: Here is the selected license text:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
LA_OPT_NXP_Software_License v13 June 2020

[JohnKlug · Accepted solution]

The problem was a local problem.

In the build script I copied over this file with local changes:

meta-imx/meta-bsp/conf/layer.conf.

This took out this update:

https://source.codeaurora.org/external/imx/meta-imx/patch/meta-bsp/conf/layer.conf?id=37201974dc8a35... 


I should either write a patch for this file, or put my local changes elsewhere.

[JohnKlug]

What change do you claim fixes this issue?  I gave you the results of our automated nightly build, which retrieves source from scratch.

Build Configuration:
BB_VERSION           = "1.44.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "ubuntu-18.04"
TARGET_SYS           = "arm-poky-linux-gnueabi"
MACHINE              = "imx6ull14x14evk"
DISTRO               = "fsl-imx-fb"
DISTRO_VERSION       = "5.4-zeus"
TUNE_FEATURES        = "arm vfp cortexa7 neon thumb callconvention-hard"
TARGET_FPU           = "hard"
meta                 
meta-poky            = "HEAD:cba967414370e195d109353e51510bd829aa86c3"
meta-oe              
meta-multimedia      
meta-python          = "HEAD:9e60d30669a2ad0598e9abf0cd15ee06b523986b"
meta-freescale       = "HEAD:c2a0d924f6200eea1fb1d1b61e7420ea5da2f8fb"
meta-freescale-3rdparty = "HEAD:dbcc686f52c3c84db8cb86aa8973a4e373651b98"
meta-freescale-distro = "HEAD:ca27d12e4964d1336e662bcc60184bbff526c857"
meta-bsp             
meta-sdk             
meta-ml              = "HEAD:2fe0ea17e86f040c5da48acf81c7e26ca4cd8ba9"
meta-browser         = "HEAD:5f365ef0f842ba4651efe88787cf9c63bc8b6cb3"
meta-rust            = "HEAD:a012a1027defe28495f06ed522a7a82bdd59a610"
meta-gnome           
meta-networking      
meta-filesystems     = "HEAD:9e60d30669a2ad0598e9abf0cd15ee06b523986b"
meta-qt5             = "HEAD:b8bcf8cb576d072f435a0177375e54424f67d1c9"
meta-python2         = "HEAD:231c3d74cfcf734c3415e86ea8dd97f73ddced9d"

I still have an older build that worked.  The following change broke the EULA for numerous builds:

This is the change that broke things (in meta-imx):

Author: Ann Thornton <ann.thornton@nxp.com>
Date: Tue Jun 16 09:35:36 2020 -0500

EULA.txt meta-bsp/conf/layer.conf: Update to v13

commit 0d1ae53326fd2d8c3cc50398e81fa1a96207c94f

Note that someone must have changed the XML for the release.  In older builds of imx-5.4.24-2.1.0.xml, this change was not included.

When I started working on this imx project, last November the release was here:

commit a083ffbbc3f4d1c02b1542746784d7f641a75b60 (HEAD, m/imx-linux-zeus, CAF/zeus-5.4.24-2.1.0)
Author: Jun Zhu <junzhu@nxp.com>
Date:   Tue Jul 7 19:56:54 2020 -0700

    iso-codes: Set branch as main in SRC_URI to fix fetch issue

    backport the patch from openembedded community
    -- https://github.com/openembedded/openembedded-core/commit/6e16ef0c2e0ec2bbb862231cd84e7650bd5789af

    Signed-off-by: Jun Zhu <junzhu@nxp.com>

New build:

commit 2fe0ea17e86f040c5da48acf81c7e26ca4cd8ba9 (HEAD, tag: rel_imx_5.4.24_2.1.0, m/imx-linux-zeus, CAF/zeus-5.4.24-2.1.0)
Author: Tom Hochstein <tom.hochstein@nxp.com>
Date:   Sat Feb 13 13:29:19 2021 -0600

[Zhiming_Liu]

Hi JohnKlug

Please try to reinstall repo .

BR

Zhiming