I am upgrading a product from MQX 4.0.1 to 188.8.131.52 and I think I may have come across a bug.
My understanding was that in order to enable a feature, you simply defined the feature's 'enable' define to 1 in the user_config.h.
I am using PPP in my project, so I defined RTCSCFG_ENABLE_PPP to 1, but the feature wasn't included.
On investigation it appears that the
lines in lots of files (ppp.c, pppfsm.c, pktrx.c, pkttx.c etc) is before any of the includes. This means that there is no way for the user_config ( and the 'enable' define ) to be included when these objects are compiled.
I have two options to make this work:
1) Move the #if in each file (which is what I chose)
2) Add -D RTCSCFG_ENABLE_PPP=1 to the compile flags.
Is this a mistake, or is the intention that compile flags now be used rather than the user_config?
Either way, I figured this observation would be useful for anyone else that can't figure out why it's not working.