Android 15 NXP BSP 1.2.0 and NFC support

[robertosartori]

Hi!

I'm following this document to integrate the changes needed to support the PN7160 NFC chip on Android:

https://www.nxp.com/docs/en/application-note/AN14608.pdf

I'm currently running Android 15 1.2.0 on a iMX8MP which is based on the Android 15 r14 tag

The document above includes the links to the software packages based on the Android 15 r1 release: unfortunately, it seems between the 2 releases there have been some change in the NFC Android stack which makes the two incompatible.

For example, I get these errors trying to build the packages/apps/Nfc repo:

packages/apps/Nfc/src/com/android/nfc/NfcService.java:1762: error: NfcService.NfcAdapterService is not abstract and does not override abstract method fetchActiveNfceeList() in INfcAdapter
    final class NfcAdapterService extends INfcAdapter.Stub {
          ^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2164: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2260: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2544: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2608: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:584: error: CardEmulationManager.CardEmulationInterface is not abstract and does not override abstract method isEuiccSupported() in INfcC
    final class CardEmulationInterface extends INfcCardEmulation.Stub {
          ^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:883: error: recoverRoutingTable(int) in CardEmulationManager.CardEmulationInterface cannot implement recoverRoutingTable(int) in INfcCard
        public boolean recoverRoutingTable(int userHandle) {
                       ^
  return type boolean is not compatible with void
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:855: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:882: error: method does not override or implement a method from a supertype
        @Override

The first error is caused by this commit which introduces an API not present on the Android 15 r1 release:

https://android.googlesource.com/platform/frameworks/base/+/9fa0481604f727087a7d752c32ff7789372fbb88

Are the latest BSPs from NXP not supported by the current NXP NFC software support package?

Thanks!

Roberto

[nicolalg]

@jimmychan is there any update on this topic? Any feedback is appreciated. Thank you.

[Arrow_AE_KingLiu]

@Jimmy 

Any update about this case. One of my customers encounter the same issue when they porting the PN7160 to android OS 15 .

Below is the log :

packages/apps/Launcher3/src/com/android/launcher3/responsive/HotseatSpecsProvider.kt:54:9: warning: parameter 'dimensionType' is never used
dimensionType: DimensionType,
^
packages/apps/Launcher3/src/com/android/launcher3/util/LauncherLayoutBuilder.kt:170:13: warning: the corresponding parameter in the supertype 'ItemTarget' is named 'children'. This may cause problems when calling this function with named arguments.
childrenIgnored: List<Node>?
^
[ 42% 55590/131966] //packages/apps/Nfc:NfcNci javac [common] (priority: 22)
FAILED: out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar
rm -rf "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar.tmp" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.tmp" && mkdir -p "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars" && out/host/linux-x86/bin/zipsync -d out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars -l out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars/list -f "*.java" out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/app/pendingintent.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/content/component_name.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/content/intent.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/aid_group.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/apdu_service_info.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/card_emulation.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/ndef.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/nfc_fservice_info.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/nfc/nfc_service.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/os/patternmatcher.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/os/persistablebundle.srcjar out/soong/.intermediates/frameworks/base/framework-nfc-javastream-protos/gen/gensrcs/frameworks/base/core/proto/android/privacy.srcjar out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/gen/android/R.srcjar && (if [ -s out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars/list ] || [ -s out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.rsp ] ; then out/host/linux-x86/bin/soong_javac_wrapper prebuilts/jdk/jdk21/linux-x86/bin/javac -J-Xmx4096M -J-XX:OnError="cat hs_err_pid%p.log" -J-XX:CICompilerCount=6 -J-XX:+UseDynamicNumberOfGCThreads -J-XX:+TieredCompilation -J-XX:TieredStopAtLevel=1 -Xmaxerrs 9999999 -encoding UTF-8 -sourcepath "" -g -XDskipDuplicateBridges=true -XDstringConcat=inline -proc:none -Xlint:-dep-ann --system=out/soong/.intermediates/build/soong/java/core-libraries/stable-core-platform-api-stubs-system-modules/android_common/system -classpath out/soong/.intermediates/vendor/nxp/frameworks/nfc/com.nxp.nfc/android_common/turbine-combined/com.nxp.nfc.jar:out/soong/.intermediates/vendor/nxp/frameworks/nfc/com.nxp.nfc/android_common/repackaged-jarjar/turbine/com.nxp.nfc.jar:out/soong/.intermediates/vendor/nxp/frameworks/emvco/com.nxp.emvco/android_common/turbine-combined/com.nxp.emvco.jar:out/soong/.intermediates/vendor/nxp/frameworks/emvco/com.nxp.emvco/android_common/repackaged-jarjar/turbine/com.nxp.emvco.jar:out/soong/.intermediates/frameworks/base/nfc/framework-nfc.impl/android_common/jarjar/turbine/framework-nfc.jar:out/soong/.intermediates/frameworks/base/framework/android_common/turbine-combined/framework.jar:out/soong/.intermediates/frameworks/base/framework/android_common/repackaged-jarjar/turbine/framework.jar:out/soong/.intermediates/frameworks/base/omapi/aidl/android.se.omapi-V1-java/android_common/turbine-combined/android.se.omapi-V1-java.jar:out/soong/.intermediates/prebuilts/sdk/current/androidx/m2repository/androidx/annotation/annotation-jvm/1.9.0-rc01/androidx.annotation_annotation/android_common/combined/androidx.annotation_annotation.jar:out/soong/.intermediates/prebuilts/sdk/current/androidx/m2repository/androidx/appcompat/appcompat/1.8.0-alpha01/androidx.appcompat_appcompat/android_common/turbine-combined/androidx.appcompat_appcompat.jar:out/soong/.intermediates/packages/apps/Nfc/bluetooth-protos-nfc-enums-java-gen/android_common/turbine-combined/bluetooth-protos-nfc-enums-java-gen.jar:out/soong/.intermediates/prebuilts/sdk/current/extras/material-design-x/com.google.android.material_material/android_common/turbine-combined/com.google.android.material_material.jar:out/soong/.intermediates/frameworks/libs/modules-utils/java/com/android/internal/util/modules-utils-fastxmlserializer/android_common/turbine-combined/modules-utils-fastxmlserializer.jar:out/soong/.intermediates/frameworks/libs/modules-utils/java/com/android/modules/utils/modules-utils-shell-command-handler/android_common/turbine-combined/modules-utils-shell-command-handler.jar:out/soong/.intermediates/system/libsysprop/srcs/PlatformProperties/android_common/turbine-combined/PlatformProperties.jar:out/soong/.intermediates/packages/apps/Nfc/proto/nfc-event-log-proto/android_common/turbine-combined/nfc-event-log-proto.jar:out/soong/.intermediates/packages/apps/Nfc/flags/nfc_flags_lib/android_common/turbine-combined/nfc_flags_lib.jar -source 17 -target 17 -d out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes -s out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno @out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.rsp @out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars/list ; fi ) && out/host/linux-x86/bin/soong_zip -jar -o out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar.tmp -C out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno -D out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno && out/host/linux-x86/bin/soong_zip -jar -o out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.tmp -C out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes -D out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes && if ! cmp -s "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.tmp" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar"; then mv "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar.tmp" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/NfcNci.jar"; fi && if ! cmp -s "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar.tmp" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar"; then mv "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar.tmp" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/anno.srcjar"; fi && rm -rf "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/srcjars" "out/soong/.intermediates/packages/apps/Nfc/NfcNci/android_common/javac/classes"
packages/apps/Nfc/src/com/android/nfc/NfcService.java:1762: error: NfcService.NfcAdapterService is not abstract and does not override abstract method fetchActiveNfceeList() in INfcAdapter
final class NfcAdapterService extends INfcAdapter.Stub {
^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2164: error: method does not override or implement a method from a supertype
@Override
^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2260: error: method does not override or implement a method from a supertype
@Override
^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2544: error: method does not override or implement a method from a supertype
@Override
^
packages/apps/Nfc/src/com/android/nfc/NfcService.java:2608: error: method does not override or implement a method from a supertype
@Override
^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:584: error: CardEmulationManager.CardEmulationInterface is not abstract and does not override abstract method isEuiccSupported() in INfcCardEmulation
final class CardEmulationInterface extends INfcCardEmulation.Stub {
^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:883: error: recoverRoutingTable(int) in CardEmulationManager.CardEmulationInterface cannot implement recoverRoutingTable(int) in INfcCardEmulation
public boolean recoverRoutingTable(int userHandle) {
^
return type boolean is not compatible with void
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:855: error: method does not override or implement a method from a supertype
@Override
^
packages/apps/Nfc/src/com/android/nfc/cardemulation/CardEmulationManager.java:882: error: method does not override or implement a method from a supertype
@Override
^
9 errors
06:13:52 ninja failed with: exit status 1

#### failed to build some targets (02:55:54 (hh:mm:ss)) ####

oranges@apple:~/work/Android15/gulukai/android15$
oranges@apple:~/work/Android15/gulukai/android15$
oranges@apple:~/work/Android15/gulukai/android15$

[jimmychan]

AE is trying to build the BSP try to reproduce the issue. Will let you know when I get any update.

[robertosartori]

Hi Jimmy, any update?

[robertosartori]

@jimmychan

[jimmychan]

The NXP official patch is for Android 15 r1 AOSP.  As there are many changes in the newer release compare with the r1, you may need to change it one by one. 

For example, for this error,

packages/apps/Nfc/src/com/android/nfc/NfcService.java:1762: error: NfcService.NfcAdapterService is not abstract and does not override abstract method fetchActiveNfceeList() in INfcAdapter
final class NfcAdapterService extends INfcAdapter.Stub {

Put the following function in final class NfcAdapterService extends INfcAdapter.Stub.

final class NfcAdapterService extends INfcAdapter.Stub {

@Override
public Map<String, Integer> fetchActiveNfceeList() throws RemoteException {
       Map<String, Integer> map = new HashMap<String, Integer>();
        if (isNfcEnabled()) {
                    map = mDeviceHost.dofetchActiveNfceeList();
        }
        return map;
}

..

..

FYI. You may copy it from NfcService.java - Android Code Search. 

You could compare the code different between the AOSP release so you could change the code accordingly. 

Another error:

packages/apps/Nfc/src/com/android/nfc/NfcService.java:2164: error: method does not override or implement a method from a supertype
@Override

For this error, the function at NfcService.java:2164 is not match in frameworks/base/nfc/java/android/nfc/INfcAdapter.aidl. 

You could find the same function in the newer release (for example: r30) and then replace the mismatch one in NfcService.java.

[jimmychan]

I will check this with the internal AE. I will let you know when I get any update.

[robertosartori]

Hi @jimmychan , any news? Thanks!

[jimmychan]

Sorry for the long waiting. I am still waiting for the AE reply. I will let you know ASAP when I get the update.