enet_ethernetif_kinetis.c change explaination

cancel
Showing results for 
Show  only  | Search instead for 
Did you mean: 

enet_ethernetif_kinetis.c change explaination

273 Views
mastupristi
Senior Contributor I

Hello,

thanks to @Gavin_Jia  (https://community.nxp.com/t5/MCUXpresso-SDK/github-repo-for-middleware/m-p/1842119#M4691) I found the lwip middleware repository containing enet_ethernetif_kinetis.c.
Analyzing the history of this file I noticed that at commit 4192f6c29 some sort of critical section was removed

commit.png

The commit message just says:

    NXP lwIP modifications for SDK version 2.13.0
    
    See ChangeLogKSDK.txt for more details.

and ChangeLogKSDK.txt is this:
https://github.com/nxp-mcuxpresso/lwip/blob/MCUX_2.13.0/ChangeLogKSDK.txt

To be honest I can't understand if it's explained why that critical section was removed.
Can you guys explain it to me? What problems were involved in having it? Or in other words, what problem does removing it solve?

 

best regards

Max

0 Kudos
1 Reply

183 Views
EdwinHz
NXP TechSupport
NXP TechSupport

Hi @mastupristi,

I'm afraid I wouldn't be able to tell you with complete certainty but believe the handling of Rx frame interruptions is already handled elsewhere, which means that there is no real necessity to handle this part as a critical section. It doesn't remove a specific issue, but rather a change for optimization. That said, if you experience any issue with this change, do let me know.

BR,
Edwin.

0 Kudos