Function missing after update to NXP::LPC54618_DFP 11.0.0

[gunnarbohlen]

Hello,

I updated my project based on LPC54618 to the latest NXP::LPC54618_DFP. This solved some problems, but now I get a new one:

The compiler can't find the function CTIMER_SetupCapture(...) any more.

In fsl_ctimer.c i see:

#if !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) && FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE

void CTIMER_SetupCapture(CTIMER_Type *base,
                         ctimer_capture_channel_t capture,
                         ctimer_capture_edge_t edge,
                         bool enableInt)

{

   ...

}

#endif

The editor µVision indicates that this function is not compiled.

"FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE" is not defined anywhere, additionally I added

#undef FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE - no change.

I don't really understand the expression. If FSL_... is not defined, is the second expresion "FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE"then really true?

if I do

#define FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE 0

then the second expression will be true, but the first one not any more because it is defined.

Initially I did have another similar problem with access to the ENUM

kCTIMER_Capture_3

This enum is only present if  the following expression is true:

#if defined(FSL_FEATURE_CTIMER_HAS_CCR_CAP3) && FSL_FEATURE_CTIMER_HAS_CCR_CAP3

In this case I was able to add

#define FSL_FEATURE_CTIMER_HAS_CCR_CAP3   1

I don't undestand why this #define is not already present in the file LPC_54618_features.h

Thank you.

[gunnarbohlen]

Hello,

I noticed that there is a new pack NXP::LPC54618_DFP V11.0.1 available.

Why does NXP publish a new pack while already reported bugs in the 11.0.0 are still present?

GB

[jeremyzhou]

Hi Gunnar Bohlen

Thank you for your interest in NXP Semiconductor products and for the opportunity to serve you.
NXP release the SDK2.5 REL in sync with released ARM CMSIS packs (version: 11.0.0).
Please go to download the SDK 2.5 via the following link.
https://www.nxp.com/support/developer-resources/software-development-tools/mcuxpresso-software-and-t...

Have a great day,
TIC

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

[gunnarbohlen]

Hi TIC,

I already have the latest sources which are included in the DFP that I want to use.

What I wanted to say is that I think there is a bug in the file fsl_ctimer.c

The expression

#if !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) && FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE

disables the function "CTIMER_SetupCapture(..)" because it will never be TRUE.

I think a bracket is missing and the expression should be like this:

#if !(defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) && FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) // extra brackets added GB 08.01.2019

...

#endif

I can modify my local version of fsl_ctimer.c, but this file is part of the pack and with the next pack-update the problem would be present again.

Regards,

 GB

[jeremyzhou]

Hi Gunnar Bohlen,

Thanks for your reply.
Yes, there's the typo in the SDK library.
Actually, it should be corrected as the below illustrates.

#if !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) && !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE)‍‍

Have a great day,
TIC

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

[gunnarbohlen]

Hello TIC,

why do you suggest to to a AND of the same expression?

#if !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE) && 
    !defined(FSL_FEATURE_CTIMER_HAS_NO_INPUT_CAPTURE)

My suggestion (see previous post) was to add a bracket.

Thank you.
GB