Processor Expert SoftwareのトピックRe: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Mon, 19 Dec 2011 05:47:34 GMT

For HCS08...

Why do TimerInt, FreeCnt, etc. components disable the entire TPM counter module when calling the Disable() method? This prevents other shared components on other channels from functioning correctly because the shared timer is stopped from clocking.

static void HWEnDi(void)
{
if (EnUser) {
    TPM2SC |= 0x10;                    /* Run counter (set CLKSB:CLKSA) */
} else {
    /* TPM2SC: CLKSB=0,CLKSA=0 */
    clrReg8Bits(TPM2SC, 0x18);         /* Stop counter (CLKSB:CLKSA = 00) */ <--This disables the clocking
    /* TPM2CNTH: BIT15=0,BIT14=0,BIT13=0,BIT12=0,BIT11=0,BIT10=0,BIT9=0,BIT8=0 */
    setReg8(TPM2CNTH, 0x00);           /* Clear counter register - any write clears complete counter */
}
}

Since these components use the Output Compare to generate their interrupts, why not just disable the compare operation using ELSnB:ELSnA bits and keep the timer running for other shared components?

I tried changing the property: [Component uses entire timer = No] ...and this doesn't help.

I also tried always keeping the component enabled and then using the EnableEvent() method to control the action. The problem with this is it still keeps the output compare interrupts running when the event is disabled. The event call is just blocked when disabled. This is very inefficient. If the envent is disabled, then why not disable the output compare altogether if it is not required?

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

ProcessorExpert — Wed, 21 Dec 2011 23:56:57 GMT

Hello,

I am sorry, I have not reproduced such behaviour. I have tried to use two TimerInt components in shared mode on the TPM2 (DZ128) and I have got this code:

static void HWEnDi(void)
{
word TmpCmpVal;                      /* Temporary variable for compare value */

if (EnUser) {
    TmpCmpVal = (word)(TPM2CNT + CmpVal); /* Count current value for the compare register */
    TPM2C1V = TmpCmpVal;               /* Set compare register */
    while (TPM2C1V != TmpCmpVal) {}    /* Wait for register update (because of Latching mechanism) */
    /* TPM2C1SC: CH1F=0 */
    clrReg8Bits(TPM2C1SC, 0x80U);      /* Reset request flag */
    /* TPM2C1SC: CH1IE=1 */
    setReg8Bits(TPM2C1SC, 0x40U);      /* Enable compare interrupt */
} else {
    /* TPM2C1SC: CH1IE=0 */
    clrReg8Bits(TPM2C1SC, 0x40U);      /* Disable Compare interrupt */
}
}

Could you please be more specific? What particular settings, compoennt leads you to your issue? What verison of PE are you using? Publishing a demonstration project would be the best.

Anyway, I agree with your last paragraph. I will pass this to developers to consider improving generated code in some next release.

best regards
Vojtech Filip
Processor Expert Support Team

Re: Timeline, Ferment, etc. calling Disable() method disables entire TPM module.

jgirard1 — Fri, 06 Jan 2012 02:08:07 GMT

I have duplicated the issue again. You need to use FreeCntr. If you use FreeCntr and source it to a TPM device that also has other counters sourced (TimerInt, etc.) on the other TPM devices, FreeCntr will no longer allow you to disable the component. It says that the component cannot be disabled because it is sourced from a shared timer. The only thing you can do with FreeCntr is to disable the event. The Output Compare interrupt will still occur in the background.

TPM10 - TimerIntt

TPM11 - Timeline

TPM12 - FreeCntr <-- (Cannot be disabled)

TPM13 - Unused

Since all these counters are based on the individual Output Compares of the TPM unit, they can easily be disabled by turning off the Output Compare interrupt. There is no issue doing this when you are only using all TimerInt components. As a matter of fact, you can disable the TimerInt's on the same TPM unit as the FreeCntr, but yet FreeCntr cannot be disabled? Why not?

I believe there is a design problem with the FreeCntr components. There is some major oversight here. Is there a good reason why these FreeCntr components act this way? Is there an easy way to get it fixed?

The problem could easily be resolved by creating my own FreeCntr componet that works, but the major issue here is there is no way to get access to the Processor Expert timer database for error checking, configuring etc. The only way to do that it is use inheritance and that has its own set of drawbacks. Primarily, you will usually need to inherit from a timer component or some other thing that is buggy, has limitations or some other stupid set of issues that ultimately make it impossible to acheive your goal. So either way, I lose.

Re: Timeline, Ferment, etc. calling Disable() method disables entire TPM module.

ProcessorExpert — Fri, 06 Jan 2012 17:18:24 GMT

Hello,

we are working on improvent of the behavior of Enable/DisableEvents in TimerInt, FreeCntr, TimerOut components for HCS08/CFV1 families. For now as a possible workaround you can disable code generation of selected component and change the code manually, see below:

/header/

#define TI1_EnableEvent() (TI1_EnEvent = TRUE, FTMxCxSC_CHxIE = 0x01, (byte)ERR_OK) /* Enable interrupt, set the flag "events enabled" */

In case it will not work for you, we can provide hot-fix for CW V10.2 (PE V5.3) that will contain the fix of Enable/DisableEvents.

Regarding disabling of the FreeCntr, the problem is that if the timer is shared, the counter cannot be stopped, which would be what ‘disable‘ method would need to do. So it’s not available in shared mode. It’s described in the hint of the method:

„Disable - This method disables the component, i.e. timer is disabled and the internal clocks are stopped. Last counter value is usually preserved in the counter (if it is supported by HW).
The method is not available if the counter is shared.“

best regards
Vojtech Filip
Processor Expert Support Team

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

jgirard1 — Tue, 17 Jan 2012 02:24:18 GMT

I am using CodeWarrior V6.3 PE with V3.09 Service Pack. Is there a HotFix for this version?

I understand that the Disable method stops the counter. My complaint is that it is wrong to do so. I believe there is no reason to stop the counter. Just stop the interrupts from occurring if it is an Output Compare. The TimerInt works this way.

I just had the issue again. I am using two FreeCntr components shared within the same TPM module and there are conflicts that prevent me from using the components the way I want to. So I try to use TimerInt instead for compatible functionality, but that doesn't work either because TimerInt does not give you direct access to setting the period based on raw timer ticks via a SetCompare(). All you get are these high-level math intensive calculating methods that are just not applicable and are inefficient.

One thing FreeCntr is missing is a method to get the compare value GetCompare(). If you have this method, you can read the last interrupt time add an offset then use SetCompare() to set a new periodic interval. As it stands now, the periodic interval is static and can only be established once from the component properties.

FreeCntr is pretty low-level to allow you to do many things at will, but it is lacking a couple of things to make it completely versatile at controlling a periodic interrupt simply and easily for anyone and any application. Perhaps this is not the purpose of FreeCntr, which I can accept, but please tell me of another component that is closer that allows me to freely set a variable periodic interrupt or create a simple variable timeout with optional interrupts that I can enable and disable. There is nothing.

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

ProcessorExpert — Thu, 19 Jan 2012 23:15:37 GMT

Hello,

please find the attached archive that contains the improved code of Enable/DisableEvent methods for FreeCntr, TimerInt, TimerOut components. These methods are influencing the interrupt directly now. I think that it should solve most of your problems.

The instruction how to apply the hot-fix are described in the readme.txt in the archive.

best regards
Vojtech Filip
Processor Expert Support Team

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

jgirard1 — Fri, 10 Feb 2012 06:31:00 GMT

This fix is a good attempt at the right approach, but it still has one major flaw.

Upon enabeling the event (which now re-enables the interrupt), you can get an immediate interrupt if a compare occured while the interrupt was disabled.

The Enable function needs to also clear the interrupt flag before enabeling the interrupts. There is no other method available to do this, other than GetStaus(), which of course is disabled when using interrupts, so it must come from the driver code itself.

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

ProcessorExpert — Fri, 10 Feb 2012 23:15:34 GMT

Hello,

yes, you are correct. I will prepare the update as soon as possible.

best regards
Vojtech Filip
Processor Expert Support Team

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

jgirard1 — Sat, 11 Feb 2012 01:18:52 GMT

The other thing you also need to add to the logic is an interlock to check if the event is already enabled. You can simply test the CHxIE bit. If the CHxIE bit is set, then do not clear the interrupt status flag. This is because the user code may always call the EnableEvent() method. There should be no side effects from calling the EnableEvent() method more than twice in a row if it is already enabled. You do not want to inadvertently clear the interrupt status flag before it can be serviced, especially when interrupts are disabled.

Please let me know how I can join the development team. I have many more ideas and I know how to develop new components using Component Wizard.

Re: TimerInt, FreeCntr, etc. calling Disable() method disables entire TPM module.

ProcessorExpert — Tue, 14 Feb 2012 21:22:04 GMT

Hello,

please find the attached updated hot-fix.

Regarding: "Please let me know how I can join the development team. I have many more ideas and I know how to develop new components using Component Wizard."

We appreciate your offer for cooperation, I have passed that to my manager.

best regards
Vojtech Filip
Processor Expert Support Team

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Thu, 08 Nov 2012 16:22:55 GMT

Hi. I appreciated this hot fix that you made for the HS(C)08 series. It worked well for me. My question is, can this same hot fix be applied to the S12(X) series processors? I have to port some of the same S08(C) code over to the the S12(X) and I am afraid that I will have the same issues as I had before with the timers sharing one single counter. If one shared timer component was disabled, then the whole timer counter register was disabled and it would no longer work for the other enabled shared timer components.

Here is what you gave me...

CodeWarrior for Microcontrollers V6.3 Processor Expert V3.09 hotfix for issue IM8614
====================================================================================

Description
-----------

- Enable/DisableEvent methods were optimized. These methods toggle the interrupt directly now. (#8702)

Installation
------------

1. Ensure you have an aministrator rights and the CodeWarrior is not running.
2. Copy the content of this archive (without readme.txt file) into the CodeWarrior
for MCUs V6.3 installation layout.

Do you know if I will run into the same problems using shared timers on the S12(X)?

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

vfilip — Fri, 09 Nov 2012 08:07:22 GMT

Hello,

from the code observation seems that in case you select ECT, TIM devices in TimerInt component you should be able use the component without any limitation.

Please let me know if I have overlooked something.

best regards

Vojtech Filip

Processor Expert Support Team

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Tue, 22 Jan 2013 04:39:37 GMT

Hi. I have begun to use the HCS12(X) for a program and I am now having the exact same issue for the FreeCnt as mentioned in this thread. I tried to use the hotfix for HC(S)08 that gave, but the package is not compatible with CodeWarrior 5.1 for S12(X).

Is there a possibility that you can do this same hotfix for me that I can integrate into CW5.1 for HC12?

Thank you.

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

vfilip — Tue, 22 Jan 2013 07:20:58 GMT

Hello,

Ok. Could you please just post here a demonstration project of the issue?

thanks & best regards

Vojtech Filip

Processor Expert Support Team

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Wed, 23 Jan 2013 02:08:41 GMT

This is for HC(S)08. This is a sample of the code before your hotfix. This FreeCnt bean is connected to a TPM in output compare mode.

These are the methods that enable/disable the event using a local variable.

#define DTE_Timeout_EnableEvent() (DTE_Timeout_EnEvent = TRUE, (byte)ERR_OK) /* Set the flag "events enabled" */

#define DTE_Timeout_DisableEvent() (DTE_Timeout_EnEvent = FALSE, (byte)ERR_OK) /* Set the flag "events disabled" */

Here is the interrupt function that tests the local variable to see if the event is enabled or not.

ISR(DTE_Timeout_Interrupt)

{

/* TPM1C3SC: CH3F=0 */

clrReg8Bits(TPM1C3SC, 0x80); /* Reset compare interrupt request flag */

if (DTE_Timeout_EnEvent) { /* Is a event allowed? */

DTE_Timeout_OnInterrupt(); /* Invoke user event */

}

This is inefficient coding as the output compare is still interrupting all the time, even when the event is disabled. My original proposal to disable the event was to clear the timer interrupt enable bit which also stops the output compare from interrupting.

So now here is the HC(S)08 code after using your "hot_fix_8702_CW_6_3_PE_3_09_CLASSIC.zip".

These new methods enable/disable the event by using the interrupt enable bit.

#define DTE3_Timeout_EnableEvent() (TPM1C3SC_CH3IE = 0x01, (byte)ERR_OK) /* Enable interrupt */
#define DTE3_Timeout_DisableEvent() (TPM1C3SC_CH3IE = 0x00, (byte)ERR_OK) /* Disable interrupt */

The ISR is different and does not have to test any local variable if the event is disabled or not.

ISR(DTE_Timeout_Interrupt)

{

/* TPM1C3SC: CH3F=0 */

clrReg8Bits(TPM1C3SC, 0x80); /* Reset compare interrupt request flag */

DTE_Timeout_OnInterrupt(); /* Invoke user event */

}

The only issue with this approach is that you need to clear the output compare interrupt flag before re-enabling the interrupt enable bit when re-enabling the event. This I mentioned in my previous post in this thread:

"The other thing you also need to add to the logic is an interlock to check if the event is already enabled. You can simply test the CHxIE bit. If the CHxIE bit is set, then do not clear the interrupt status flag. This is because the user code may always call the EnableEvent() method. There should be no side effects from calling the EnableEvent() method more than twice in a row if it is already enabled. You do not want to inadvertently clear the interrupt status flag before it can be serviced, especially when interrupts are disabled."

I know you made this improvement for me in another hot fix release, but I cannot find that version and I cannot seem to download it from this thread anymore. You gave me two hot fixes, I believe. I seemed to have lost the final version of this fix.

Anyway, my original question was can you do the same updates, but do it for the HCS12(X) for CW5.1 Classic? If you have the original final version of this hot fix for HC(S)08, I could use that as well. Thanks.

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

vfilip — Wed, 23 Jan 2013 07:43:11 GMT

Hello,

generally you cannot apply the original hot-fix for hcs08 to another family (and product). I would recommend to use the CW V10.3 instead of using classic CW with hot-fix. Anyway I have attached it again.

Regarding hot-fix for hcs12(x) - I would just need some demonstration project in order to reproduce the issue on HCS12(X) or at least details on timer device and MCU you use.

best regards

Vojtech Filip

Processor Expert Support Team

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Thu, 24 Jan 2013 02:08:57 GMT

Hi. Thank you again for all your efforts. I know this may seem like a pain to deal with and I'm sorry if it is.

I am now working with a MC9S12XA256 application using Processor Expert with classic interface. This is all I have the license for and cannot use the new Ecplise interface.

Here is the code that is generated for my FreeCntr bean:

volatile bool FSK_Out_IRQ_EnEvent; /* Used for Enable/Disable events */

#define FSK_Out_IRQ_EnableEvent() ( FSK_Out_IRQ_EnEvent = TRUE,          /* Set the flag "events enabled" */ \
ERR_OK                               /* Return result */ )
#define FSK_Out_IRQ_DisableEvent() ( FSK_Out_IRQ_EnEvent = FALSE,         /* Set the flag "events disabled" */ \
ERR_OK                               /* Return result */ )

ISR(FSK_Out_IRQ_Interrupt)

{

TFLG1 = 0x04U; /* Reset interrupt request flag */

if (FSK_Out_IRQ_EnEvent) { /* Are the events enabled? */

FSK_Out_IRQ_OnInterrupt(); /* Invoke user event */

}

It is the same code as HC(S)08 before applying your 8702 hot fix. It is the same inefficient code that keeps the timer output compare interrupting unneccesarily. It would be more efficient to just disable the timer interrupt as your hot fix does. However, the hot fix you provided is incomplete as I've already mentioned in the previous posts with respect to re-enabling the event:

Here is how your hot fix re-enables the event:

#define DTE3_Timeout_EnableEvent() (TPM1C3SC_CH3IE = 0x01, (byte)ERR_OK) /* Enable interrupt */

The enable event should look like this:

if (TPM1C3SC_CH3IE != 0x01) /* Test if event is already enabled */

{

clrReg8Bits(TPM1C3SC, 0x80); /* Clear any previous compare interrupt request flag */

TPM1C3SC_CH3IE = 0x01; /* Now enable the event */

}

I would like to have this functionality as a hot fix in both the HC(S)08 and the S12(X) for my applications. I thought for sure you added this additional 'enable event' functionality for me in a update to your original 8702 hot fix, but I cannot find it in my files. Maybe you can go back and look for a secondary update after Jan 19, 2012? The additional update, after we discussed it, and according to this thread, should be Feb 14, 2012.

Please let me know if you can do this for me and I would really appreciate it. I am sorry if this is a pain for you. If you do not understand the history, you can take time to re-read this entire thread as it has become pretty evolved. Everything you need to know is in this thread as you already addressed this issue once for me for the HC(S)08 application.

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

vfilip — Mon, 28 Jan 2013 11:04:00 GMT

Hello,

please find the attached patch from Feb 14, 2012. Regarding HCS12(X,Z): I have passed your requested to developers.

Could you please also specify which version of CW for HCS12 do you use?

best regards

Vojtech Filip

Processor Expert Support Team

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Tue, 29 Jan 2013 05:23:28 GMT

I am using CodeWarrior Development Studio S12(X) Version 5.1, Build 10221 (Professional).

If I can have this same fix for S12(X), that would perfect. Thank you for all your great help.

Re: TimerInt, FreeCnt, etc. calling Disable() method disables entire TPM module.

jgirard1 — Mon, 04 Feb 2013 03:00:23 GMT

Hi. Do you think you can have the same fix for S12(X) anytime soon? My project is sort of waiting on it.

I am also having more limitations with other PE components as I have posted in Embedded Components forum. I wish it was easier to make your own components that has acess to the PE databases.