Half Complete flag bug in DMAChannel_LDD

bowerymarc — Tue, 25 Feb 2014 20:36:23 GMT

looks like setting "Initialization->Half complete" to Enabled does not OR in DMA_CSR_INTHALF_MASK as it should.

Re: Half Complete flag bug in DMAChannel_LDD

Petr_H — Tue, 11 Mar 2014 16:26:29 GMT

Hi,

Yes, we confirm that it's a bug, this option doesn't work properly. We are working on the fix for the next release.

We are sorry for an inconvenience. For now, the following workaround can be applied:

1) Set properties according to your request.
2) Enable GetTransferCompleteStatus() method generation.
3) Generate code

4)Disable generation of DMAChannel_LDD and DMAController components using the context (pop-up) menu option Code geration > Don't Write Generated Code Modules.

5) Open DMACH1.c generated by DMAChannnel_LDD component

6) Find DMA1_TChnInit const DMACH1_ChInit structure and
add DMA_CSR_INTHALF_MASK constant to the TCD_CSR register initial value item.
(see attached picture)

7) Open DMA1.c generated by DMAController component.

8) Find static void HandleInterrupt(DMA1_TChnDevData *ChnDevDataPtr) and
add following code after last "} else {" statement: (see attached picture)

    DMA1__ClearChannelInterruptFlag(DmaMemMapPtr, ChnDevConstPtr->PhyChnNum);
    if (ChnDevDataPtr->Events.OnCompleteFnPtr != NULL) {
      ChnDevDataPtr->Events.OnCompleteFnPtr(ChnDevDataPtr->UserDataPtr);
    }

9) In DMACH1_OnComplete() event you can use following code in order to distinguish "Full complete" and "Half complete" event.

void DMACH1_OnComplete(LDD_TUserData *UserDataPtr)
{
if (DMACH1_GetTransferCompleteStatus(hDmaChn) == FALSE) {
/* FullComplete = FALSE; HalfComplete = TRUE; */
} else {
/* FullComplete = TRUE; HalfComplete = FALSE; */
}
}

Note: If interrupts are disabled or your code doesn't handle OnComplete event before all data are transferred by DMA peripheral, OnComplete event will be invoked only once and GetTransferCompleteStatus() called from this event will always return TRUE = "Full complete".

Best regards

Petr Hradsky

Processor Expert Support Team

Re: Half Complete flag bug in DMAChannel_LDD

bowerymarc — Tue, 11 Mar 2014 19:34:19 GMT

Thanks Petr for verifying.

You forgot to attach the picture...

Re: Half Complete flag bug in DMAChannel_LDD

Petr_H — Thu, 13 Mar 2014 15:26:49 GMT

I'm sorry, you are right, here it is:

Best regards

Petr Hradsky

Processor Expert Support Team

Re: Half Complete flag bug in DMAChannel_LDD

scottm — Thu, 29 Jun 2017 15:46:22 GMT

It's been 3 years and the component doesn't seem to be fixed yet. Was there a release that I missed? I'm running CW 10.7, and the component shows up as version 01.051.

Thanks,

Scott

topic Re: Half Complete flag bug in DMAChannel_LDD in Processor Expert Software

Half Complete flag bug in DMAChannel_LDD

Re: Half Complete flag bug in DMAChannel_LDD

Re: Half Complete flag bug in DMAChannel_LDD

Re: Half Complete flag bug in DMAChannel_LDD

Re: Half Complete flag bug in DMAChannel_LDD