topic P1020RDB-PD TDM tests and issues in P-Series

P1020RDB-PD TDM tests and issues

naumgrutman — Wed, 22 Feb 2017 18:56:27 GMT

In reference to the other thread:

TDM Driver Working in Internal Loopback mode During Validation

The document within it TDM Driver Working in Internal Loopback mode During Validation.pdf

described changes to the TDM driver more specifically

changing

#define TDM_CLK_DIV_VAL 0x85

#define TDM_CLK_DIV_VAL 0xC3

within TDM_FSL.c

In that previous thread I have pointed out that first of all the TDM_LOOPBACK_TEST.c

algorithm had major issue and was actually failing 99% of the time...

That test was fixed up ( algorithmwise ) and it was shown to be PASSing for P1010RDB

Under further scrutiny my findings are:

Looking/reviewing again the test logs/results that you performed back in January using P1010 show that you were using

external clock... I would like to see you rerun your tests using internal clock on P1010 and see that you a get positive results...

Since you were using external clock the value of 0xC3 for TDM_CLK_DIV_VAL was not even used...

I am using P1020RDB-PD

the TDM_TEST.c with the DTMF loopback and the freshly updated TDM_LOOPBACK_TEST.c are performing OK

as long as I am using the external clock...

if I use within TDM_FSL.c the following line

dev_node = of_find_compatible_node( NULL, NULL, "fsl,P1020RDB-PD" );

to force P1020 to use internal clock... then both of above tests are FAILing...

I have tried these tests with each of the below values with not much luck...

#define TDM_CLK_DIV_VAL 0x85

#define TDM_CLK_DIV_VAL 0xC3

Can you please run above tests on P1020RDB-PD using internal clock

and let me know what TDM_CLK_DIV_VAL should be set to...

and if there is any hope for these tests to PASS using INTERNAL CLOCK...

Thanks,

Naum Grutman

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Tue, 28 Feb 2017 22:32:01 GMT

I have reported this issue with the following thread:

https://community.nxp.com/docs/DOC-333351

TDM Driver Working in Internal Loopback mode During Validation

since the issue is related and is on the same subject etc... etc...

but I have been asked to create a new thread... so I have done that...

P1020RDB-PD TDM tests and issues

Would anybody please look into this issue...

Thanks,

Naum

Re: P1020RDB-PD TDM tests and issues

yipingwang — Thu, 09 Mar 2017 11:13:11 GMT

Hello Naum,

Please refer to the attached tdm source file and test log on T020RDB-PD board.

For using the external clock, please configure the following in the driver file tdm/device/tdm_fsl.c.

static int tdm_internal_clk = 0;

Have a great day,
Yiping

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Thu, 09 Mar 2017 15:33:20 GMT

Yiping,

You are missing my point completely...

I am saying that using External Clock these tests are PASSing...

before they were failing even under external clock because the algorithm was screwed up...

Now that algorithm was fixed they are PASSing under External Clock... so stipulated....!!!!

The problem is that these tests are FAILing

when one wants to use TDM_CLK_DIV_VAL which means that one has to use INTERNAL CLOCK

Please provide proof that these tests will PASS using INTERNAL CLOCK...!!!!!!!!!!!

You put together this thread:

TDM Driver Working in Internal Loopback mode During Validation

to point out that there are changes to the TDM driver with one of them being

TDM_CLK_DIV_VAL under Internal clock configuration... but in all your tests you were

using External Clock all along so this TDM_CLK_DIV_VAL is not being used...

Again and again and again I am saying...:

Please make these tests work using internal clock...

!!!!!!! Please provide proof that these tests will PASS using INTERNAL CLOCK...!!!!!!!!!!!

Thanks,

Naum

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Thu, 09 Mar 2017 16:50:17 GMT

Yiping,

Please show me that the highlighted code below executes and test is PASSing….!!!!!!!

if (tdm_internal_clk) {

//out_be32(&priv->tdm_regs->rir,

// RIR_RFWM(RIR_RFWM_VAL) | RIR_RFEN | RIR_RWEN | RIR_RDMA |

// RIR_RSO | RIR_RCOE | RIR_RRDO | RIR_RFSD(RIR_RFSD_VAL));

//out_be32(&priv->tdm_regs->tir,

// TIR_TFWM(TIR_RFWM_VAL) | TIR_TFEN | TIR_TWEN | TIR_TDMA |

// TIR_TCOE | TIR_TSL | TIR_TSO | TIR_TRDO |

// TIR_TFSD(TIR_RFSD_VAL));

out_be32(&priv->tdm_regs->rir,

RIR_RDMA | RIR_RFSD(RIR_RFSD_VAL) | RIR_RRDO);

out_be32(&priv->tdm_regs->tir,

TIR_TDMA | TIR_TFSD(TIR_RFSD_VAL) | TIR_TRDO);

out_be32(&priv->clk_regs->tx, TDM_CLK_DIV_VAL);

out_be32(&priv->clk_regs->rx, TDM_CLK_DIV_VAL);

pr_info("TDM configured to use internal clock");

} else {

Rx Water mark 0, FIFO enable, Wide fifo, DMA enable for RX,

Receive Sync out, syncwidth = ch width, Rx clk out,zero sync,

falling edge , data order

out_be32(&priv->tdm_regs->rir,

RIR_RFWM(RIR_RFWM_VAL) | RIR_RFEN | RIR_RWEN | RIR_RDMA |

RIR_RSL | RIR_RSO | RIR_RCOE | RIR_RRDO |

RIR_RFSD(RIR_RFSD_VAL));

out_be32(&priv->tdm_regs->tir,

TIR_TFWM(TIR_RFWM_VAL) | TIR_TFEN | TIR_TWEN | TIR_TDMA |

TIR_TSL | TIR_TSO | TIR_TRDO | TIR_TFSD(TIR_RFSD_VAL));

pr_info("TDM configured to use external clock");

}

<http://www.rugged.com/>

Naum Grutman

Tel: ( 818 ) 700-2000 Ext. 163

Fax: ( 818 ) 407-1502

Address: 19756 Prairie St. Chatsworth, CA.91311

E-mail: ngrutman@rugged.com<mailto:ngrutman@rugged.com>

Website: www.rugged.com<http://www.rugged.com/>;

Embedded Computing without Compromise

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Thu, 09 Mar 2017 18:16:24 GMT

Yiping,

1. Is INTERNAL CLOCK available on P1020RDB ???

2. Can this parameter "TDM_CLK_DIV_VAL" be used ?

If the answer to above is YES and YES then

Please show me that the highlighted code below executes and test is PASSing….!!!!!!!

if (tdm_internal_clk) {

//out_be32(&priv->tdm_regs->rir,

// RIR_RFWM(RIR_RFWM_VAL) | RIR_RFEN | RIR_RWEN | RIR_RDMA |

// RIR_RSO | RIR_RCOE | RIR_RRDO | RIR_RFSD(RIR_RFSD_VAL));

//out_be32(&priv->tdm_regs->tir,

// TIR_TFWM(TIR_RFWM_VAL) | TIR_TFEN | TIR_TWEN | TIR_TDMA |

// TIR_TCOE | TIR_TSL | TIR_TSO | TIR_TRDO |

// TIR_TFSD(TIR_RFSD_VAL));

out_be32(&priv->tdm_regs->rir,

RIR_RDMA | RIR_RFSD(RIR_RFSD_VAL) | RIR_RRDO);

out_be32(&priv->tdm_regs->tir,

TIR_TDMA | TIR_TFSD(TIR_RFSD_VAL) | TIR_TRDO);

out_be32(&priv->clk_regs->tx, TDM_CLK_DIV_VAL);

out_be32(&priv->clk_regs->rx, TDM_CLK_DIV_VAL);

pr_info("TDM configured to use internal clock");

} else {

Rx Water mark 0, FIFO enable, Wide fifo, DMA enable for RX,

Receive Sync out, syncwidth = ch width, Rx clk out,zero sync,

falling edge , data order

out_be32(&priv->tdm_regs->rir,

RIR_RFWM(RIR_RFWM_VAL) | RIR_RFEN | RIR_RWEN | RIR_RDMA |

RIR_RSL | RIR_RSO | RIR_RCOE | RIR_RRDO |

RIR_RFSD(RIR_RFSD_VAL));

out_be32(&priv->tdm_regs->tir,

TIR_TFWM(TIR_RFWM_VAL) | TIR_TFEN | TIR_TWEN | TIR_TDMA |

TIR_TSL | TIR_TSO | TIR_TRDO | TIR_TFSD(TIR_RFSD_VAL));

pr_info("TDM configured to use external clock");

}

Re: P1020RDB-PD TDM tests and issues

ZhangJennie — Fri, 17 Mar 2017 03:33:39 GMT

Hi Naum,

We are very sorry we overlooked this issue, Yiping is a bit overloaded this week.

Yiping is now working on your question and will reply you as early as she can. We will take this issue with highest priority.

Have a great day,
Jennie Zhang

Re: P1020RDB-PD TDM tests and issues

yipingwang — Mon, 20 Mar 2017 14:59:41 GMT

Hello Naum,

I also got failed result on P1020RDB for the internal clock testing.

It seems that TDM_CLK_DIV_VAL value is not correct for P1020, I need to do more investigation, will give you feedback later.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Mon, 20 Mar 2017 20:13:26 GMT

Hello Yiping,

Now,

that you finally agree with me… and see for yourself that TDM_LOOPBACK_TEST

is FAILing using internal clock… please respond to our requirements for P1020…!!!

We need to see that this TDM_LOOPBACK_TEST is gonna PASS

using TDM_CLK_DIV_VAL that will produce 10MHz bit clock on the TDM

So again the following TWO STEPS are essential for us…!!!

1. What is the TDM_CLK_DIV_VAL that will produce10MHz bit clock on the TDM…???

2. And to see the PASSing results for TDM_LOOPBACK_TEST with TDM_CLK_DIV_VAL

from above Step 1 applied…

Thanks again,

<http://www.rugged.com/>

Naum Grutman

Tel: ( 818 ) 700-2000 Ext. 163

Fax: ( 818 ) 407-1502

Address: 19756 Prairie St. Chatsworth, CA.91311

E-mail: ngrutman@rugged.com<mailto:ngrutman@rugged.com>

Website: www.rugged.com<http://www.rugged.com/>;

Embedded Computing without Compromise

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Mon, 20 Mar 2017 20:15:28 GMT

Hello Yiping,

Now,

that you finally agree with me… and see for yourself that TDM_LOOPBACK_TEST

is FAILing using internal clock… please respond to our requirements for P1020…!!!

We need to see that this TDM_LOOPBACK_TEST is gonna PASS

using TDM_CLK_DIV_VAL that will produce 10MHz bit clock on the TDM

So again the following TWO STEPS are essential for us…!!!

What is the TDM_CLK_DIV_VAL that will produce10MHz bit clock on the TDM…???

And to see the PASSing results for TDM_LOOPBACK_TEST with TDM_CLK_DIV_VAL

from above Step 1 applied…

Thanks again,

Naum

Re: P1020RDB-PD TDM tests and issues

yipingwang — Tue, 21 Mar 2017 07:20:36 GMT

Hello Naum,

I just verified the TDM internal clock loopback testing on P1010RDB-PB, it passed without any problem.

When run the internal clock testing code on P1020RDB-PD, the TDM channel cannot receive any data, I am afraid the internal clock mode is not supported by P1020, because I cannot find these registers TDM_CLOCK_TDMCLK_DIV_VAL_RX/TDM_CLOCK_TDMCLK_DIV_VAL_TX definition in P1020 Reference Manual at all, at least this testing code working in internal clock mode is not suitable for P1020.

Have a great day,
Yiping

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Tue, 21 Mar 2017 16:18:02 GMT

Yiping,

I would like to see the current log file showing that you have TDM_P1010

PASSing the TDM_LOOPBACK_TEST under Internal Clock....!!!!

and its TDM_CLK_DIV_VAL value...!!!

Please attach it to your response... !!!

Thanks,

Naum

Re: P1020RDB-PD TDM tests and issues

yipingwang — Wed, 22 Mar 2017 03:31:15 GMT

Hello Naum,

Please refer to the attached source code, dts and testing log for P1010RDB-PB platform.

You could find "TDM configured to use internal clock" in the console log.

I am not sure whether TDM internal clock mode is support on P1020RDB-PD and how to decide TDM Division Value for P1020, I have confirmed with the hardware AE team, am still waiting for the feedback.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

yipingwang — Wed, 22 Mar 2017 07:57:43 GMT

Hello Naum,

According to the information which I provided previously, indeed TDM internal clock mode loopback test succeed on P1010RDB-PB, but failed on P1020RDB-PD, I have made many test on this issue these days. I also contacted one of the TDM driver author, but this driver was designed 7 years ago, he couldn't remember much. I also asked for the hardware AE team to confirm TDM hardware on P1020RDB-PD still am waiting for for the result.

This morning the factory team informed me that your issue had been escalated to them, they are investigating your problem parallel.

I will still keep tracking this issue, if I have any outcome or get any feedback from AE team, I will let you know in my first time.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

yipingwang — Thu, 23 Mar 2017 05:45:31 GMT

Hello Naum,

I searched from our internal Data base today, found a service request on 5/23/2012, it states "The internal clocking mechanism of TDM was de-featured in P1020".

Anyway, I am still waiting for the authoritative confirmation from USA hardware AE team, will give you more update later.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

yipingwang — Fri, 24 Mar 2017 15:04:18 GMT

Hello Naum,

Please refer to the following update from the AE team, would you please also provide more information about a question from them?

<AE Team>:

We looked at the Ref Manuals of P1020, P1010 and T1040. There is a section of TDM Clock control <see snips below, It is there in P1010RM and T1040RM but NOT in P1020RM

So a question to understand the customer requirement better:

What is the customer looking for? I mean will they be using this in their product as a feature? Or it is being used by them for some validation purpose?

Meanwhile we are looking for some person in design team to check if these registers are there in P1020 or not.And also try to get the validation/verification status of this feature.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Fri, 24 Mar 2017 18:00:14 GMT

Hello Yipping

Please find answers to yours and/or AE’s questions:

What is the customer looking for?

-> We are in the process of building a product that is gonna be very much

depending on P1020’s TDM and its abilities and capabilities…

I mean will they be using this in their product as a feature?

-> Yes, we will be using TDM in our product extensively

and need for P1020 to produce 10Mbps clock on the TDM

It clearly states that 50Mbps should be handled…

We are just looking for 1/5 of that 10Mbps

Or it is being used by them for some validation purpose?

-> Obviously, currently we are trying to validate above

that is why we are using the P1020RDB product and are looking for

TDM_LOOPBACK_TEST to PASS using Internal clock

And also want Internal clock configured correctly

to produce 10Mbps bit clock on the TDM

I have provided excerpts for P1020 and P1010 Reference manuals

Obviously you can see that they offer same TDM features.

We definitely want all the TDM features listed on P1020

and have TDM validated via TDM_LOOPBACK_TEST

using internal clock configured to produce 10Mbps

<http://www.rugged.com/>

Naum Grutman

Tel: ( 818 ) 700-2000 Ext. 163

Fax: ( 818 ) 407-1502

Address: 19756 Prairie St. Chatsworth, CA.91311

E-mail: ngrutman@rugged.com<mailto:ngrutman@rugged.com>

Website: www.rugged.com<http://www.rugged.com/>;

Embedded Computing without Compromise

Re: P1020RDB-PD TDM tests and issues

naumgrutman — Fri, 24 Mar 2017 18:08:01 GMT

Hello Yipping

Please find answers to yours and/or AE’s questions:

What is the customer looking for?

-> We are in the process of building a product that is gonna be very much

depending on P1020’s TDM and its abilities and capabilities…

I mean will they be using this in their product as a feature?

-> Yes, we will be using TDM in our product extensively

and need for P1020 to produce 10Mbps clock on the TDM

It clearly states that 50Mbps should be handled…

We are just looking for 1/5 of that 10Mbps

Or it is being used by them for some validation purpose?

-> Obviously, currently we are trying to validate above

that is why we are using the P1020RDB product and are looking for

TDM_LOOPBACK_TEST to PASS using Internal clock

And also want Internal clock configured correctly

to produce 10Mbps bit clock on the TDM

I have provided excerpts for P1020 and P1010 Reference manuals

Obviously you can see that they offer same TDM features.

We definitely want all the TDM features listed on P1020

and have TDM validated via TDM_LOOPBACK_TEST

using internal clock configured to produce 10Mbps

Re: P1020RDB-PD TDM tests and issues

yipingwang — Mon, 27 Mar 2017 03:37:35 GMT

Hello Naum Grutman,

Thank you for your detailed information, we need to contact the processor design team to do further confirmation regarding TDM internal clock feature on P1020, will give you feedback as soon as possible.

Thanks,

Yiping

Re: P1020RDB-PD TDM tests and issues

yipingwang — Wed, 29 Mar 2017 10:51:16 GMT

Hello Naum Grutman,

Please refer to the following information which I got from our hardware team.

P1010 and P1020 are different devices, with different silicon inside, so TDM function is not guaranteed to be identical.

For P1010: This is a copy of Figure 23-7 from P1010 Reference Manual:

You can see “On-Chip Clock Source” and gate controller by TCOE bit (this bit is in TDM_SB_TDMTIR register, see Section 23.5.3)

Now similar Figure from P1020 Manual – Figure 19-37:

No “On-Chip Clock Source” path and no TCOE bit. The same in TDM_SB_TDMTIR register – bit 22 is reserved.

So – yes, P1020 TDM block is different in regards to internal clock, according to P1020 Reference Manual.

In addition, probably we need to do further discussion about what you are doing now, actually this should not be public in the community, this should be private as normal. So I suggest you create a ticket(case) from Sales and Support|NXP to describe your current problem in details. Your Ticket will be addressed in our internal system, you will get timely reply through email from our TIC support team. The email is sent out from "NXP Technical Support", if you reply to this email, your update will be addressed in our system automatically.

Thanks,

Yiping