Bug in Chip_LCD_Init() in lcd_17xx_40xx.c?

giusloq — Fri, 16 Feb 2018 07:46:01 GMT

void Chip_LCD_Init(LPC_LCD_T *pLCD, LCD_CONFIG_T *LCD_ConfigStruct)
{

/* ... */

/* set bits per pixel */
regValue = LCD_ConfigStruct->BPP << 1;

   /* set color format RGB */
   regValue |= LCD_ConfigStruct->color_format << 8;
   regValue |= LCD_ConfigStruct->LCD << 4;
   if (LCD_ConfigStruct->Dual == 1) {
      regValue |= 1 << 7;
   }
   pLCD->CTRL = regValue;

/* ... */

}

The field BPP (CTRL[3:1]) is: 0=1bpp, 1=2bpp, 2=4bpp, 3=8bpp, 4=16bpp, 5=24bpp, 6=16bpp, 7=12bpp. So you need to assign the value 5 (if you need 24bpp) to the BPP field of LCD_CONFIG_T struct. However this is not clear and it seems you can assign directly 24 to BPP. Maybe an enumeration is better in this case.

Re: Bug in Chip_LCD_Init() in lcd_17xx_40xx.c?

soledad — Fri, 16 Feb 2018 22:54:04 GMT

Hi,

Thank you for your feedback, we will check this issue.

Have a great day,
Sol

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

LPC Microcontrollers中的主题 Bug in Chip_LCD_Init() in lcd_17xx_40xx.c?

Bug in Chip_LCD_Init() in lcd_17xx_40xx.c?

Re: Bug in Chip_LCD_Init() in lcd_17xx_40xx.c?