LPC546xx SDK2.2 Ethernet: code mistake

hlsamts — Wed, 30 Aug 2017 09:59:26 GMT

There is a mistake in the function ENET_DescriptorInit of SDK2.2:

The original order is:

Determine, whether the RX interrupt is enabled:
intRxEnable = (base->DMA_CH[channel].DMA_CHX_INT_EN & ENET_DMA_CH_DMA_CHX_INT_EN_RIE_MASK) ? true : false;
Initialize TX descriptors:
if (ENET_TxDescriptorsInit(base, bufferConfig, intTxEnable, channel) != kStatus_Success) ...
Determine, whether the TX interrupt is enabled:
intTxEnable = (base->DMA_CH[channel].DMA_CHX_INT_EN & ENET_DMA_CH_DMA_CHX_INT_EN_TIE_MASK) ? true : false;
Initialize RX descriptors:
if (ENET_RxDescriptorsInit(base, bufferConfig, intRxEnable, channel, doubleBuffEnable) != kStatus_Success) ...

The problem is: in step 2 the variable intTxEnable is used uninitialized.

One possible order of the steps would be: 3-2-1-4

Best regards,

Holger Sachs

Re: LPC546xx SDK2.2 Ethernet: code mistake

jeremyzhou — Thu, 31 Aug 2017 07:42:05 GMT

Thank you for your interest in NXP Semiconductor products and

for the opportunity to serve you.

I'll contact with the AE team about this 'issue'.

Have a great day,

TIC