topic Re: LPCOpen bug report in LPC Microcontrollers

LPCOpen bug report

MindBender — Wed, 23 Nov 2016 16:50:17 GMT

There's a bug in LPCOpen, switching all peripherals on when trying to switch off one:

lpc_chip_40xx/src/clock_17xx_40xx.c, line 111:

/* Disables power and clocking for a peripheral */
void Chip_Clock_DisablePeriphClock(CHIP_SYSCTL_CLOCK_T clk) {
uint32_t bs = (uint32_t) clk;

#if defined(CHIP_LPC40XX)
   if (bs >= 32) {
       LPC_SYSCTL->PCONP1 &= ~(1 << (bs - 32));
   }
   else {
       LPC_SYSCTL->PCONP |= ~(1 << bs);
   }
#else
   LPC_SYSCTL->PCONP |= ~(1 << bs);
#endif
}

Index: lpc_chip_40xx/src/clock_17xx_40xx.c
===================================================================
--- lpc_chip_40xx/src/clock_17xx_40xx.c   (revision 440)
+++ lpc_chip_40xx/src/clock_17xx_40xx.c   (working copy)
@@ -117,7 +117,7 @@
        LPC_SYSCTL->PCONP1 &= ~(1 << (bs - 32));
    }
    else {
-       LPC_SYSCTL->PCONP |= ~(1 << bs);
+       LPC_SYSCTL->PCONP &= ~(1 << bs);
    }
#else
    LPC_SYSCTL->PCONP |= ~(1 << bs);

Re: LPCOpen bug report

jeremyzhou — Thu, 24 Nov 2016 06:25:51 GMT

Hi Robert Delien,

Thanks for your sharing, and I will transfer the report to the AE for checking.

Thanks again.
Have a great day,
Ping

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

Re: LPCOpen bug report

MindBender — Thu, 24 Nov 2016 12:26:39 GMT

The patch above was incomplete and inadvertently posted by my wonky browser. The version attached to this post is complete. It patches two instances in two files in LPCOpen v2.10.