topic Re: shell_printf() shell.c KSDK 1.1.0 in Kinetis Software Development Kit

shell_printf() shell.c KSDK 1.1.0

tomasvanek — Wed, 11 Mar 2015 04:41:37 GMT

Shell code uses shell_printf for output. However standard printf is used at two places. It is a problem when you use context->ops->send_data for output.

--- a/KSDK-1.1.0/utilities/shell/src/shell.c 2014-12-17 11:42:10.000000000 +0100

+++ b/KSDK-1.1.0/utilities/shell/src/shell.c 2015-03-10 22:19:58.152395878 +0100

@@ -250,7 +250,7 @@

int i;

memmove(&context->line[context->c_pos],&context->line[context->c_pos + 1],context->l_pos - context->c_pos);

context->line[context->l_pos] = 0;

- printf("\b%s \b", &context->line[context->c_pos]);

+ shell_printf(context, "\b%s \b", &context->line[context->c_pos]);

/* reset postion */

for (i = context->c_pos; i <= context->l_pos; i++)

@@ -296,7 +296,7 @@

/* move the cursor to new position */

for (i = context->c_pos; i < context->l_pos; i++)

{

- printf("\b");

+ shell_printf(context, "\b");

}

else

Re: shell_printf() shell.c KSDK 1.1.0

Kan_Li — Thu, 12 Mar 2015 08:01:48 GMT

Hi Tomas,

Thanks for the reporting! I have passed it to the software team, and will let you know when I have any more information.

Have a great day!

Kan

Re: shell_printf() shell.c KSDK 1.1.0

tomasvanek — Tue, 06 Oct 2015 08:41:48 GMT

I downloaded KSDK 1.3.0 and the reported problem is still there untouched. Why sw team has not accepted even so clear and trivial patch?

Re: shell_printf() shell.c KSDK 1.1.0

DavidS — Tue, 13 Oct 2015 16:23:21 GMT

Hi Tomas,

Thanks for re-reporting.

I have submitted formal trouble ticket:

Issue KPSDK-7285 - shell printf coding error has been successfully created.

Regards,

David