topic Re: KW40Z_Connectivity_Software_1.0.1 review in Kinetis Software Development Kit

KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:04:31 GMT

KW40Z_Connectivity_Software_1.0.1 (KSDK_1.3.0); IAR 7.50

Some observed potential code issues list:

1. \ConnSw\framework\Bootloader MKW40Z160_cfg.h contains:
* \file MKW40Z160.h
...
/** Kinetis ARM Cortex-M4 model */
#ifndef _MK21D256_CFG_H
#define _MK21D256_CFG_H
...
#endif//MK21D5_CFG_H
expected:
* \file MKW40Z160_cfg.h
....
/** Kinetis ARM Cortex-M0+ model */
#ifndef _MKW40Z160_CFG_H
#define _MKW40Z160_CFG_H
...
#endif//_MKW40Z160_CFG_H

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:06:33 GMT

2. BOARD_LTC_INSTANCE is defined in board.h and not in SecLib.h
add in SecLib.h
#ifndef BOARD_LTC_INSTANCE
#define BOARD_LTC_INSTANCE 0
#endif

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:08:50 GMT

3. TimersManager.h missed osNumberOfTimers count

#define gTmrTotalTimers_c ( gTmrApplicationTimers_c + gTmrStackTimers_c )
should become (?):
gTmrTotalTimers_c ( gTmrApplicationTimers_c + gTmrStackTimers_c + osNumberOfTimers )

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:10:58 GMT

4. app_preinclude.h total stack usage, overflow check (?), and how to dimension:

Stack Size values found in project:
#define gTmrTaskStackSize_c               500
#define gSerialTaskStackSize_c            1024
#define gMainThreadStackSize_c          1024
#define gControllerTaskStackSize_c       900
#define gHost_TaskStackSize_c             1300
#define gL2ca_TaskStackSize_c 600
#define gAppIdleTaskStackSize_c         (400)
#define gFwkCommonStackSize_c

#define gMacTaskStackSize_c 1280
#define gPhyTaskStackSize_c 600

#define USB_OTG_TASK_STACKSIZE             2000
#define USB_KHCI_TASK_STACKSIZE            3500
#define USB_KHCI_TASK_STACKSIZE            3500
#define USB_KHCI_TASK_STACKSIZE            3500
#define USB_KHCI_TASK_STACKSIZE            3500

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:13:43 GMT

5. #ifdef gXcvrXtalTrimEnabled_d to #if (gXcvrXtalTrimEnabled_d) in KW4xXcvrDrv.c and KW3xXcvrDrv.c

#if (gXcvrXtalTrimEnabled_d)
#include "Flash_Adapter.h"
#endif
...
void XcvrInit ( radio_mode_t radioMode )
{
XcvrInit_ModeChg_Common(radioMode,FIRST_INIT);
#if (gXcvrXtalTrimEnabled_d)
if( 0xFFFFFFFF != gHardwareParameters.xtalTrim )
{
XcvrSetXtalTrim( (uint8_t)gHardwareParameters.xtalTrim );
}
#endif

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:15:56 GMT

6. file Eeprom_Boot.h contains:
* \file Eeprom.h
...
#ifndef _EEPROM_H_
#define _EEPROM_H_
...
#endif /* _EEPROM_H_ */
expected
* \file Eeprom_Boot.h
...
#ifndef _EEPROM_BOOT_H_
#define _EEPROM_BOOT_H_
...
#endif /* _EEPROM_BOOT_H_ */

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 10:24:48 GMT

7. Keyboard.h should include EmbeddedTypes.h if LED.h is not used
#ifndef _KEYBOARD_INTERFACE_H_
#define _KEYBOARD_INTERFACE_H_

#include "EmbeddedTypes.h"

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 16:20:29 GMT

8. ble_sig_defines.h should include DESCRIPTOR support for gatt_db.h
https://www.bluetooth.com/specifications/gatt/descriptors
https://www.bluetooth.com/specifications/gatt/viewer?attributeXmlFile=org.bluetooth.descriptor.gatt.characteristic_presentation_format.xml
example:
CHARACTERISTIC(char_temperature, gBleSig_Temperature_d, (gGattCharPropRead_c | gGattCharPropNotify_c))
   VALUE(value_temperature, gBleSig_Temperature_d, (gPermissionFlagReadable_c), 2, 0x00, 0xB4)
   DESCRIPTOR(desc_temperature, gBleSig_CharPresFormatDescriptor_d, (gPermissionFlagReadable_c), gBleSig_CharPresFormatDescriptorBytes_d, gBleSig_signed_16_bit_integer_d, gBleSig_Exponent_neg2_d, gBleSig_Celsius_temperature_d, gBleSig_No_Namespaces_d, gBleSig_unknown_d)
   CCCD(cccd_core_temperature)

based on:
/* DESCRIPTOR(.., gBleSig_CharPresFormatDescriptor_d, .., 7, Format, Exponent, Unit, Namespace, Description)
* https://www.bluetooth.com/specifications/gatt/viewer?attributeXmlFile=org.bluetooth.descriptor.gatt.characteristic_presentation_format.xml
* The actual value = Characteristic Value * 10^Exponent. */
#define gBleSig_CharPresFormatDescriptorBytes_d         7
/* Format Mandatory 8bit    range 0x00    0x1B */
/* https://www.bluetooth.com/specifications/assigned-numbers/format-types */
    /* 4    unsigned 8-bit integer */
    #define gBleSig_unsigned_8_bit_integer   0x04
    /* 14    signed 16-bit integer */
    #define gBleSig_signed_16_bit_integer_d 0x0E

/* Exponent Mandatory sint8    -128 0 127 */
    /* 10^Exponent: 0 =1 */
    #define gBleSig_Exponent_0_d    0x00
    /* 10^Exponent: -2 */
    #define gBleSig_Exponent_neg2_d 0xFE
    /* 10^Exponent: -3 */
    #define gBleSig_Exponent_neg3_d 0xFD

/* Unit The Unit is a UUID. Mandatory uint16    N/A    N/A */
/* https://www.bluetooth.com/specifications/assigned-numbers/units */
    /* 0x2700   unitless   org.bluetooth.unit.unitless */
    #define gBleSig_unitless_d                       0x00, 0x27
    /* 0x272F   Celsius temperature (degree Celsius)   org.bluetooth.unit.thermodynamic_temperature.degree_celsius */
    #define gBleSig_Celsius_temperature_d            0x2F, 0x27
    /* 0x2728   electric potential difference (volt)   org.bluetooth.unit.electric_potential_difference.volt */
    #define gBleSig_electric_potential_difference_d 0x28, 0x27

/* Namespace (organization) Mandatory 8bit    0    1 */
    /* 0    No Namespace */
    #define gBleSig_No_Namespaces_d                   0x00
    /* 1    Bluetooth SIG Assigned Numbers */
    #define gBleSig_Bluetooth_SIG_Assigned_Numbers_d 0x01

/* Description Name Space field. Mandatory 16bit    N/A    N/A    */
/* https://www.bluetooth.com/specifications/assigned-numbers/gatt-namespace-descriptors */
    /* unknown   0x0000 */
    #define gBleSig_unknown_d 0x00, 0x00

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 14 Feb 2017 16:22:37 GMT

9. LED inverse output setting (LED1..LED4)
LED.h
/*
* Name: mLEDInvertedOut
* Description: Led outpus inverted. Default value TRUE.
*               TRUE
*                LedOn -> GPIO_DRV_ClearPinOutput(kGpioLEDx)
*                LedOff -> GPIO_DRV_SetPinOutput(kGpioLEDx)
*               FALSE
*                LedOn   -> GPIO_DRV_SetPinOutput(kGpioLEDx)
*                LedOff -> GPIO_DRV_ClearPinOutput(kGpioLEDx)
*/
#ifndef mLEDInvertedOut_c
#define mLEDInvertedOut_c                TRUE
#endif

LED.c
void LED_Operate
...
case gLedOn_c:
   #if (mLEDInvertedOut_c)
      GPIO_DRV_ClearPinOutput(kGpioLED1);
   #else
      GPIO_DRV_SetPinOutput(kGpioLED1);
   #endif /* mLEDInvertedOut_c */
   break;
case gLedOff_c:
   #if (mLEDInvertedOut_c)
      GPIO_DRV_SetPinOutput(kGpioLED1);
   #else
      GPIO_DRV_ClearPinOutput(kGpioLED1);
   #endif /* mLEDInvertedOut_c */
   break;
....

* \file LED.h
* LED export interface file for ARM CORTEX-M4 processor
should be updated to ARM Cortex-M0+

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Fri, 17 Feb 2017 02:15:05 GMT

10. missing _FWKINIT_H_ in FwkInit.c
should add:

...
#ifndef _FWKINIT_H_
#define _FWKINIT_H_
...
#endif /* _FWKINIT_ */

and
* TIMER implementation file for the ARM CORTEX-M4 processor
should be:
* TIMER implementation file for the ARM CORTEX-M0+ processor

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Fri, 17 Feb 2017 02:32:10 GMT

11. how to set private static Bluetooth MAC address in ble_controller_task.c

very strange const definition; stack is pre-compiled (hope for the best and remove the const...)

const uint8_t gBDAddress_c[6] = {BD_ADDR};

.....

static void clone_RSIM_private_static_MAC(void)
{
    uint32_t *ptr;

    ptr = (uint32_t *)(RSIM_BASE + 0x0C); // RSIM_MAC_LSB
    gBDAddress_c[0] = (uint8_t) *ptr;
    gBDAddress_c[1] = (uint8_t) ( *ptr >> 8);
    gBDAddress_c[2] = (uint8_t) ( *ptr >> 16);
    gBDAddress_c[3] = (uint8_t) ( *ptr >> 24);
    ptr = (uint32_t *)(RSIM_BASE + 0x08); // RSIM_MAC_MSB
    gBDAddress_c[4] = (uint8_t) *ptr;
    gBDAddress_c[5] = 0xC0;   // MSB is 11xx xxxx
}

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Fri, 17 Feb 2017 02:46:59 GMT

12. MKW40Z160_cfg.h why define KINETIS_MODEL_STR is "KL46"
#define KINETIS_MODEL KW40_48MHz

/* Description string */
#define KINETIS_MODEL_STR "KL46"

is used in UartBootloader.c

expected something like "KW40" or "KW30Z" ...

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Fri, 17 Feb 2017 14:48:38 GMT

13. fsl_mcg_hal_modes.h

/*! @brief
* Check parameter or not during MCG mode switching. It is recommend to enable
* this macro when debug. After debug, disable this macro for code size
* optimization.
*/
#define MCG_MODE_CHECK_PARAM 0

someone could follow the suggestion like:

#if DEBUG
#define MCG_MODE_CHECK_PARAM TRUE
#else
#define MCG_MODE_CHECK_PARAM FALSE
#endif

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Sat, 18 Feb 2017 10:35:45 GMT

14. possible uncorrelated gUseNVMLink_d linker set and mAppUseNvm_d define

if gUseNVMLink_d=0 and mAppUseNvm_d TRUE linker fails:

Error[Li005]: no definition for "NV_STORAGE_END_ADDRESS" [referenced from D:\....\debug\obj\ApplMain.o]

\platform\devices\MKW30Z4\linker\iar\MKW30Z160xxx4_connectivity.icf
if( gUseNVMLink_d )
{
define exported symbol NV_STORAGE_SECTOR_SIZE = m_sector_size;
define exported symbol NV_STORAGE_MAX_SECTORS = gNVMSectorCountLink_d; /* NV_STORAGE_MAX_SECTORS * NV_STORAGE_SECTOR_SIZE = total NV Storage space */

define exported symbol NV_STORAGE_START_ADDRESS = m_fsl_prodInfo_start - 1;
define exported symbol NV_STORAGE_END_ADDRESS = NV_STORAGE_START_ADDRESS - (NV_STORAGE_MAX_SECTORS * NV_STORAGE_SECTOR_SIZE) + 1;
}

ApplMain.c
....
#ifndef mAppUseNvm_d
#define mAppUseNvm_d    TRUE
#endif
....
extern uint32_t NV_STORAGE_END_ADDRESS[];
...
void main_task(uint32_t param)
{
...
#if mAppUseNvm_d
        /* Initialize NV module */
        NV_Init();

        /* NV_STORAGE_END_ADDRESS from linker file is used as NV Start Address */
        gNvmStartAddress_c = (uint32_t)((uint8_t*)NV_STORAGE_END_ADDRESS);
#endif

\framework\NVM\Source\NV_Flash.c

#if gNvStorageIncluded_d
#if (gNvUseFlexNVM_d == FALSE) || ((gNvUseFlexNVM_d == TRUE) && (DEBLOCK_SIZE == 0)) /* no FlexNVM */

       /*
       * Name: NV_STORAGE_END_ADDRESS
       * Description: NV_STORAGE_END_ADDRESS from linker command file is used by this code
       *              as Raw Sector Start Address. This should not be misleading because
       *              ENVM module writes meta information in address-ascending order
       *              and records in address-descending order.
       */
       extern uint32_t NV_STORAGE_END_ADDRESS[];

       /*
       * Name: NV_STORAGE_SECTOR_SIZE
       * Description: external symbol from linker command file, it represents the size
       *              of a FLASH sector
       */
       extern uint32_t NV_STORAGE_SECTOR_SIZE[];

       /*
       * Name: NV_STORAGE_MAX_SECTORS
       * Description: external symbol from linker command file, it represents the sectors
       *              count used by the ENVM storage system; it has to be a multiple of 2
       */
       extern uint32_t NV_STORAGE_MAX_SECTORS[];

#endif /* no FlexNVM */
#endif /* gNvStorageIncluded_d */

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Sat, 18 Feb 2017 19:56:53 GMT

15. gHardwareParameters.gInternalStorageAddr used only once, and never before after

\framework\OtaSupport\Source\OtaSupport.c

/*****************************************************************************
* OTA_InitExternalMemory
*
* This function is called in order to initialize all elements needed for
* external memory access
*
*****************************************************************************/
otaResult_t OTA_InitExternalMemory(void)
{
#if (gEepromType_d != gEepromDevice_None_c)
    static bool_t mEepromInitStatus = FALSE;

    if( !mEepromInitStatus )
    {
        if(EEPROM_Init() != ee_ok)
        {
            return gOtaExternalFlashError_c;
        }

        /* Update the offset to the internal storage if necessary */
        NV_ReadHWParameters(&gHardwareParameters);
        if( gHardwareParameters.gInternalStorageAddr != gEepromParams_StartOffset_c )
        {
            gHardwareParameters.gInternalStorageAddr = gEepromParams_StartOffset_c;
            NV_WriteHWParameters(&gHardwareParameters);
        }

        mEepromInitStatus = TRUE;
    }

    return gOtaSucess_c;
#else
    return gOtaExternalFlashError_c;
#endif
}

same definition:
\framework\Flash\External\Interface\Eeprom.h
\framework\Bootloader\Bootloader_OTAP_Serial\src\eeprom\Eeprom_Boot.h

#ifndef gEepromParams_StartOffset_c
#define gEepromParams_StartOffset_c 0xFFFFFFFF /* Not defined */
#endif

the variable gHardwareParameters.gInternalStorageAddr is used only in this function.

defined in \framework\Flash\Internal\Flash_Adapter.c

/* Hardware parameters */
hardwareParameters_t gHardwareParameters;

The variable reads from FREESCALE_PROD_DATA (m_fsl_prodInfo_start) zone 0xFFFFFFFF most likely already filled with 0xFF

As read & write 1K flash block's consume some time and some flash, the code in bold may be removed.

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Sat, 18 Feb 2017 22:06:41 GMT

16. OtapBootloader project build
\framework\Bootloader
path does not exist as expected in Post-build command line:

$TOOLKIT_DIR$\bin\ielftool "$PROJ_DIR$\BootloaderOTAP_KW40Z4\exe\BootloaderOTAP_KW40Z4.out" "$PROJ_DIR$\Binaries\BootloaderOTAP_KW40Z4.bin" --bin --silent

either create folder Binaries (then copy to Bin folder)
\framework\Bootloader\Bootloader_OTAP_Serial\Binaries

or better update command to:
$TOOLKIT_DIR$\bin\ielftool "$PROJ_DIR$\BootloaderOTAP_KW40Z4\exe\BootloaderOTAP_KW40Z4.out"

"$PROJ_DIR$\..\Bin\BootloaderOTAP_KW40Z4.bin" --bin --silent

as the image is needed in \framework\Bootloader\Bin\ for main project to link:

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Sun, 19 Feb 2017 00:24:30 GMT

15. gHardwareParameters.gInternalStorageAddr zone should be kept !

as a non-intuitive naming is available in boot-loader to check if external storage should be used:

\framework\Bootloader\Bootloader_OTAP_Serial\src\OtapSerialBootloader\OtapBootloader.c

/*! *********************************************************************************
* \brief   This function determines the start address of the internal sorage.
*          If value is 0xFFFFFFFF then external storage should be used!
*
* \return the start address of the internal storage
*
********************************************************************************** */
uint32_t Boot_GetInternalStorageStartAddr(void)
{
    return *((uint32_t*)(gBootProductInfoAddress_c + gInternalStorageStartAddressOffset_c));
}

OtapBootloader.h

/*
* Name: gBootProductInfoAddress_c
* Description: Address of the ProductInfo
* The Product info is located in the last sector of the FLASH
*/
#define gBootProductInfoAddress_c (gMcuFlashSize_c - gFlashErasePage_c)
/*
* Name: gInternalStorageStartAddress_c
* Description: The start address of the internal storage
*/
#define gInternalStorageStartAddressOffset_c (0x44)

in this case gBootProductInfoAddress_c should be equal FREESCALE_PROD_DATA_BASE_ADDR

and the offset gInternalStorageStartAddressOffset_c matches gInternalStorageAddr

Flash_Adapter.h

typedef PACKED_STRUCT hardwareParameters_tag
{
    uint8_t reserved[42];             /* for backward compatibillity */
    uint8_t ieee_802_15_4_address[8]; /* IEEE 802.15.4 MAC address   - not used */
    uint8_t bluetooth_address[6];     /* Bluetooth address */
    uint32_t xtalTrim;                 /* KW4x only */
    uint32_t edCalibrationOffset;      /* KW01 ED offset - not used */
    uint32_t pllFStepOffset;           /* KW01 fine tune pll   - not used */
    uint32_t gInternalStorageAddr;     /* The start address of the internal storage used for OTA update.
                                          A value of 0xFFFFFFFF means that the External storage is used. */
} hardwareParameters_t;

Flash_Adapter.c

/* Hardware parameters */
hardwareParameters_t gHardwareParameters;

Application use 2 points to communicate with boot-loader, as general approach to confirm image location and image parameters:

MKW30Z ROM map

Bluetooth® Low Energy Application Developer’s Guide Rev. 1, 10/2015 (page 113 - 114)

The BOOT_FLAGS section contains bootloader flags and the target bootloader version. The OTAP Bootloader looks

for this section immediately after the ISR_TABLE

The FSL_PROD_DATA section contains the location of the upgrade image. The location is a 32bit number

which is set at compile time. It is set to 0xFFFFFFFF if external SPI FLASH storage is used or to a location

inside the internal FLASH memory (which is always smaller than 0xFFFFFFFF) if internal image storage is used.

This is necessary for the OTAP Bootloader to know the source of the upgrade image.

In this case MKW30Z as the images hardly fits internally one flash parameter can be sufficient

and could decrease program size.

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 21 Feb 2017 08:38:44 GMT

17. /framework/Bootloader/Bootloader_OTAP_Serial/Linker_cfg/BootloaderOTAP.icf

define exported symbol __BOOT_STACK_ADDRESS = __region_RAM_end__ - 7; //0x20007FF8;

this comment should be // 0x20001FF8

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Tue, 21 Feb 2017 12:54:25 GMT

18. An observed OTAP update behaviour:
- if new .srec image does not contain bootloader structure, the bootloader fails to start, or update, and the PCB is stuck
- if new .srec image contains bootloader structure it works.

- if bootloader does not find right bootFlags data in ROM area 000014C0 to 000014C7 (gpBootInfo <-> app gBootFlags structure)
    ((gpBootInfo->newBootImageAvailable[0] != gBootValueForTRUE_c) && (gpBootInfo->bootProcessCompleted[0] == gBootValueForTRUE_c))
    than the bootloader does not start and tries to update the image.

- if bootloader tries to update from already stored image he should find where the image is stored - internal vs external flash.
    Here it checks the content of address (gBootProductInfoAddress_c + gInternalStorageStartAddressOffset_c) in application stored by
gHardwareParameters.gInternalStorageAddr is eqiual to 0xFFFFFFFF if external SPI EEPROM is used.

Suggestions:
First
I think for this chip MKW30Z using internal storage is not an feasible option (OTAP + BLE stack + bootloader is quite large)
By default external storage should be used -> so the check for internal/external data is not necessary; only external image should be used.

Second - bootloader entry check - can be updated to:

    gpBootInfo = (bootInfo_t*)gBootImageFlagsAddress_c;
    if ((gpBootInfo->newBootImageAvailable[0] == gBootValueForTRUE_c) &&
        (gpBootInfo->bootProcessCompleted[0] == gBootValueForTRUE_c))
    {
        /* Write the new image */
        Boot_LoadImage();
    }
    else
    {
        /* Set the start address of the interrupt vector*/
        SCB_VTOR = gUserFlashStart_d;
        JumpToApplication(gUserFlashStart_d);
    }

/framework/Bootloader/Bootloader_OTAP_Serial/src/OtapSerialBootloader/OtapBootloader.c

int main(int argc, char **argv)
{
.....
    /* Check if there is no boot image available in the external EEPROM and if eventually
    the booting of the previous one has been completed. If both conditions are met, start
    running the application in the internal Flash. Else, start the process of booting from
    external EEPROM */
    gpBootInfo = (bootInfo_t*)gBootImageFlagsAddress_c;
    /*
    if( (gpBootInfo->newBootImageAvailable == gBootValueForTRUE_c) &&
    (gpBootInfo->bootProcessCompleted == gBootValueForFALSE_c) )
    */
    if ((gpBootInfo->newBootImageAvailable[0] != gBootValueForTRUE_c) &&
        (gpBootInfo->bootProcessCompleted[0] == gBootValueForTRUE_c))
    {
        /* Set the start address of the interrupt vector*/
        SCB_VTOR = gUserFlashStart_d;
        JumpToApplication(gUserFlashStart_d);
    }
    else
    {
        /* Write the new image */
        Boot_LoadImage();
    }
.....
/*! *********************************************************************************
* \brief   This function will copy the User Application from the external memory
*          into the program Flash
*
********************************************************************************** */
void Boot_LoadImage (void)
.....
    /* Check if we have a valid internal storage start address. */
    gBootStorageStartAddress = Boot_GetInternalStorageStartAddr();

/*! *********************************************************************************
* \brief   This function determines the start address of the internal sorage.
*          If value is 0xFFFFFFFF then external storage should be used!
*
* \return the start address of the internal storage
*
********************************************************************************** */
uint32_t Boot_GetInternalStorageStartAddr(void)
{
    return *((uint32_t*)(gBootProductInfoAddress_c + gInternalStorageStartAddressOffset_c));
}

/framework/Bootloader/Bootloader_OTAP_Serial/src/OtapSerialBootloader/OtapBootloader.h

/* Defines used for implementing the boolean types when working with Flash */
#define gBootInvalidAddress_c          0xFFFFFFFF
#define gBootValueForTRUE_c            0x00
#define gBootValueForFALSE_c           0xFF

\framework\OtaSupport\Source\OtaSupport.c

gBootFlags is initialized to {{gBootValueForFALSE_c}, {gBootValueForTRUE_c}, {0x00, 0x02}};

void OTA_SetNewImageFlag(void)

...

if new image ready gBootFlags.newBootImageAvailable is updated to gBootValueForTRUE_c

bootProcessCompleted already true, not used

Re: KW40Z_Connectivity_Software_1.0.1 review

lucianfiran — Sat, 04 Mar 2017 10:49:57 GMT

19. FwkInit.c

#ifndef _FWKINIT_H_
#define _FWKINIT_H_
...
#endif /* _FWKINIT_ */

It does not have separate h, but h looks.

#if defined(FWK_SMALL_RAM_CONFIG)
better be changed to
#if (FWK_SMALL_RAM_CONFIG)

so FWK_SMALL_RAM_CONFIG can be set to 0 or 1 (or TRUE/FALSE) easily in app_preinclude.h

* TIMER implementation file for the ARM CORTEX-M4 processor
should be ARM CORTEX-M0+