topic Re: KSDK UART_Adapter Typo in Kinetis Software Development Kit

KSDK UART_Adapter Typo

ryanbryngelson — Mon, 03 Oct 2016 13:13:56 GMT

I noticed what looks like a copy/paste error in UART_Adapter.c. In the LPUART_Initialize, UART_Initialize, and LPSCI_Initialize functions, the initialization of the state doesn't assign NULL to pTxData (but instead assigns pRxData twice). For example...

base = mLpuartBase[instance];
pLpuartStates[instance] = pState;
pState->rxCbParam = 0;
pState->txCbParam = 0;
pState->pRxData = NULL;
pState->pRxData = NULL;
pState->rxSize = 0;
pState->txSize = 0;

I believe the line in red should read:

pState->pTxData = NULL;

Ryan

Re: KSDK UART_Adapter Typo

DavidS — Mon, 03 Oct 2016 14:41:28 GMT

Hi Ryan,

Can you post your project?

If not please let us know which processor, which version of KSDK (1.1/1.2/1.3/2.0), and any other information that may help use look into this.

Regards,

David

Re: KSDK UART_Adapter Typo

ryanbryngelson — Mon, 03 Oct 2016 14:46:08 GMT

KSDK 2.0.

Re: KSDK UART_Adapter Typo

DavidS — Mon, 03 Oct 2016 15:00:03 GMT

Hi Ryan,

What processor?

Any other verbose information helpful.

Regards,

David

Re: KSDK UART_Adapter Typo

ryanbryngelson — Mon, 03 Oct 2016 15:05:41 GMT

David,

Please READ the initial post. I'm pointing out an issue in the source code of KSDK 2.0. It's not causing me any problems, it's just something I noticed. If it matters I'm using a KW41Z512, however, I suspect the line of source in question doesn't depend on the MCU I'm using.

Ryan

Re: KSDK UART_Adapter Typo

DavidS — Mon, 03 Oct 2016 17:19:33 GMT

Hi Ryan,

It did matter so thank you for letting me know it was the KW41 MCU which is part of an alpha program and not available yet to public.

The source you are referring too is in the connection wireless framework code base and not part of KSDK specifically. That is why I had trouble finding it and your reply helped me to figure out where that code was located.

I will notify the correct team with your observation.

Thank you again for posting it.

Regards,

David

Re: KSDK UART_Adapter Typo

ryanbryngelson — Mon, 03 Oct 2016 18:55:10 GMT

Ah, gotcha. I should have realized it wasn't in the SDK proper since the source file is in the frame directory... my bad.