topic Re: i.MX28 Linux BSP I2C source codes bug in i.MX Processors

i.MX28 Linux BSP I2C source codes bug

jackyliu — Wed, 28 Mar 2012 08:17:36 GMT

in drivers/i2c/busses/i2c-mxs.c, mxs_i2c_xfer_msg() function:
below codes are not correct:
err = wait_for_completion_interruptible_timeout(&dev->cmd_complete,
       msecs_to_jiffies(1000)
     );
if (err <= 0) {
  mxs_i2c_reset(dev);
  dev_dbg(dev->dev, "controller is timed out\n");
  return -ETIMEDOUT;
}

Re: i.MX28 Linux BSP I2C source codes bug

jackyliu — Wed, 28 Mar 2012 08:17:46 GMT

It should be changed as belows:
err = wait_for_completion_interruptible_timeout(&dev->cmd_complete, msecs_to_jiffies(1000));
      if (err == 0) {
              mxs_i2c_reset(dev);
              printk("I2C timeout\n");
              return -ETIMEDOUT;
      }
      else if (err==(-ERESTARTSYS)) {
              printk("I2C ERESTARTSYS\n");
          for (i = 0; i < _NSIG_WORDS ; i++) printk("I2C signal:%d\n",current->pending.signal.sig[i]);
              return -ETIMEDOUT;
      }
      else if (err<0){
              printk("I2C unknown err:%d\n",err);
              return -ETIMEDOUT;
      }

Re: i.MX28 Linux BSP I2C source codes bug

samuelsalas — Fri, 14 Dec 2012 17:32:24 GMT

Hi Jacky,

Have you got a last version of "i2c-mxs.c" I could use to solve my two issues :

I2C frequency on 2 buses

Conflict on 2 I2C buses

Regards,

Sam.

Re: i.MX28 Linux BSP I2C source codes bug

ArtyomKamshilin — Wed, 13 Feb 2013 17:25:26 GMT

Sam,

> Have you got a last version of "i2c-mxs.c"

I also have issues with I2C - where can I get this latest version? I've got all patches applied. Thanks in advance!

Arty

Re: i.MX28 Linux BSP I2C source codes bug

samuelsalas — Thu, 14 Feb 2013 09:48:22 GMT

Hi Artem,

there is no last version of "i2c-mxs.c" for the kernel 2.6.35, but there is a new version with kernel 3.7. That's what we are doing now, passing to 3.7 in order to benefit from the new kernel.

Samuel

Re: i.MX28 Linux BSP I2C source codes bug

ArtyomKamshilin — Thu, 14 Feb 2013 17:52:45 GMT

Thanks, I look forward for the update!