topic Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive in i.MX Processors

Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Tue, 24 Jul 2012 06:11:12 GMT

Freescale Android BSP doesn't support TVin chips, this patch enabled the adv7180 chip for Android.

The followed functions are supported:

    1) Android camera application can preview the tvin.
    2) De-interlace was supported in Android overlay.
    3) VDI split mode was support to preview TVin on high resolution display.
    4) Support auto-detect PAL and NTSC mode.

Some limitation for the patch:

-- The android camera applition doesn't support PAL/NTSC switch on the fly.
(After switched the input signal, stop camera application and re-start it; unit test
application "mxc_v4l2_tvin" supports the on the fly switch.)

-- For VDI split mode, only high motion was supported. When output preview
Resolution is high than 968*1024, only high motion (-m 2) can be used.

-- Android camera applition video recording was not supported.

For more information, please reference to the readme file.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

JackyHuang — Fri, 27 Jul 2012 08:25:29 GMT

Li, I have used your patch,

It's very good, mx53 have a great improvement in deinterlace

Thank you, you have solved a big issue

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

vincent_rtk — Mon, 10 Sep 2012 05:50:42 GMT

The attached files cannot be download. it shows:

Not Found

The item does not exist. It may have been deleted.

Could you put them back, I have some problem in running mxc_v4l2_tvin on BSP10.4

Thanks.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

admin — Mon, 10 Sep 2012 16:48:10 GMT

Vincent, I'm going to look into what happened to the attached files during our move from the old site. If I can recover them, I will post them.

Regards,

Grant

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

admin — Mon, 10 Sep 2012 18:22:08 GMT

Files attached.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

stevetsai — Tue, 11 Sep 2012 12:06:25 GMT

Hi,

It support 16 bits CSI or 8 bits CSI? Thanks. I am looking for 16 bits CSI driver.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Fri, 21 Sep 2012 01:57:24 GMT

It can support both 16bits and 8bits CSI, for 16bits CSI, it was verified with adv7842 (BT1120 mode, the 16bits CSI data lines should be CSI_D_19 ~ CSI_D_12, CSI_D9 ~ CSI_D_2).

But I can't release the adv7842 driver code, because it was implemented by another customer.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

GaoJianzhong — Fri, 05 Oct 2012 04:40:43 GMT

Hi , I want to enable the adv7180 16bit mode, my board is imx53 AI.

Could you give me some ideas about this?

Thank you very much.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Mon, 08 Oct 2012 01:18:55 GMT

The IMX53 AI hardware only supports 8bits CSI input from adv7180. For 16 bits CSI input, you should make sure the hardware link is correct and make adv7180 output 16bits YUV data correctly. Then the unit test application mxc_v4l2_tvin.zip can work directly.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

GaoJianzhong — Tue, 09 Oct 2012 10:50:48 GMT

Hi, Li Qiang

I have let the adv7180 to output 16bit (13.5MHz) data.

But I don’t know how to modify the BSP to receive 16bit data.

Can you give me some ideas about this?

The IMX53 AI Hardware seems support 16bit, but the bsp only supports the 8bit.

I modified the mxc_v4l2_capture.c file

Set

csi_param.data_width = IPU_CSI_DATA_WIDTH_16, but it is not work,

Is there other places to modify?

Thank you!

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Wed, 10 Oct 2012 01:41:48 GMT

If your 16bits data output from adv7180 is BT1120 format (on 16 bits data bus, the 8 MSB is always the Y and SAV/EAV, the 8 LSB is U,V,U,V ......), then you don't need modify the mxc_v4l2_capture.c, in adv7180 driver, function ioctl_g_ifparm(), you should return the followed parameters:

p->if_type = V4L2_IF_TYPE_BT1120;

p->u.bt1120.mode = V4L2_IF_TYPE_BT1120_MODE_BT_8BIT;

p->u.bt1120.nobt_hs_inv = 0;

p->u.bt1120.nobt_vs_inv = 0;

p->u.bt1120.latch_clk_inv = 0;

p->u.bt1120.clock_curr = 0;

p->u.bt1120.bt_sync_correct = 0;

For V4L2_IF_TYPE_BT1120_MODE_BT_8BIT, that means each Y,U,V data is 8bits, so the IPU_CSI_DATA_WIDTH is till set to 8, not 16.

And for BT1120 16bits mode, in function adv7180_probe(), adv7180_data.pix.pixelformat should be changed from V4L2_PIX_FMT_UYVY to V4L2_PIX_FMT_YUYV.

No code modification was needed in mxc_v4l2_capture.c, my patch had already tuned that file well to support 8bits BT565 and 16bits BT1120.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

GaoJianzhong — Wed, 10 Oct 2012 02:37:41 GMT

Hi Li Qiang,

Thank you very much for your help!

When I compile the modified source code, I found that there is no “V4L2_IF_TYPE_BT1120“ and “bt1120” data struct in my kernel source.

My kernel is linux-2.6.35.3. Do you mean I must creat it by myself?

And, In mxc_v4l2_capture.c, there is no process of bt1120(only bt656), is that OK?

Thanks again.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Wed, 10 Oct 2012 02:45:32 GMT

The default BSP doesn't support BT1120 16 bits mode, in my patch file "TVin_Patches_for_R10.4.zip", there is a kernel patch "tvin_kernel_imx.patch" added the BT1120 16bits support for mxc_v4l2_capture, please reference to it for your BSP.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

GaoJianzhong — Wed, 10 Oct 2012 03:02:53 GMT

Thank you!

I will try it.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

GaoJianzhong — Wed, 10 Oct 2012 06:04:41 GMT

Hi Li Qiang,

I reference the tvin_kernel_imx.patch and modify my kernel.

Below are my changed poits:

1. And bt1120 data struct to kernel/include/media/v4l2-init-device.h (I think this is no problem)

2. Modify the kernel/drivers/media/video/mxc/capture/mxc_v4l2_capture.c

3. Modify the kernel/drivers/mxc/ipu3/ipu_capture.c

4. Modify the kernel/driver/media/video/mxc/capture/adv7180.c (In this file, I want to let adv7180 to output 16bit data with define the ADV7180_16BIT macro)

#if 0

// This is the BSP original source code

#else

//This is modified source code

#endif

But, the mxc_v4l2_tvin is still not work now, error is

ERROR: v4l2 capture: mxc_v4l_dqueue timeout enc_counter 0

VIDIOC_DQBUF failed.

I attached the source codes I modified, could you please check it,

And tell me what should I do.

Thank you very much!

Best regards

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

sanjeevsharma — Mon, 15 Jul 2013 13:03:55 GMT

Hi All,

I would like to support this functionality on Imx6Q on Android where Adv7180 is connected via CSI0.would these change will be applicable to imx6 Q too ?

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Tue, 16 Jul 2013 01:09:13 GMT

It can't be used in iMX6 BSP, because iMX6 Android BSP hasn't use the IPU overlay, it used GPU.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

sanjeevsharma — Fri, 19 Jul 2013 05:31:02 GMT

Thanks Qiang but AFAIK Free-scale added support of TV-in in ICS branch too and attaching patch for your reference(Please review) and i can found change in libcamera directory too where I can leverage this functionality and libcamera2 is introduced in Jellybeans and right now I don't have plan to move to jelly beans however want to add support of adv7180 in ICS only.

Let me know your suggestion/comment.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

qiang_li-mpu_se — Fri, 19 Jul 2013 06:25:56 GMT

iMX6 BSP is different with iMX53 Android BSP, it doesn't used IPU lib, it doesn't used overlay lib, so you should not reference to this patch for iMX6 TVin support. This iMX53 patch is based on IPU lib and overlayer.

Re: Patch to support adv7180 TVin chip for Freescale Android R10.4 BSP on iMX53 -blog archive

sanjeevsharma — Fri, 19 Jul 2013 07:12:54 GMT

Thanks for your comment but the patch I attached in my last comment is from jb4.2.2_1.0.0-ga release which is Android release and i am not talking here imx53 patch.So would like to know your suggestion regarding the change which provide Tv-In support on Android framework.For Kernel support of adv7180 I will refer i.MX 6Quad BSP L3.0.35_4.0.0 GA release candidate.I have sabre-auto board with adv7180 chip on it so need to add this support in Android ICS version I have been using.