i.MX Processors中的主题 Re: iMX6 ESAI TDM with underrun and overrun support

iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Wed, 17 Dec 2014 12:23:51 GMT

I am trying to use the ESAI of the iMX6...

I need to use 2x 32 slots of 8 bits at 8Khz, and I am in slave mode since i am listenning Frame Synchro and Tx Clock

I am testing the interface simply sending a word of 0xAA on slot 0 and slot 15, the others are 0x00

I am probably facing the underrun and overrun chip errata (ERR008000) on ESAI since my channels are switching randomly ...

I already tested the kernel from :

-> git://git.freescale.com/imx/linux-2.6-imx.git --- branch : imx_3.10.31_1.1.0_alpha

-> git://git.freescale.com/imx/linux-2.6-imx.git --- branch : imx_3.10.31_1.1.0_beta2

And now I am trying to use the main kernel stable git :

-> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git --- branch master

But I have some trouble actually with the mailine kernel :

[ 745.648380] fsl-esai-dai 2024000.esai: Missing dma channel for stream: 0

[ 745.655198] fsl-esai-dai 2024000.esai: ASoC: pcm constructor failed: -22

I figured out that the imx6qdl.dtsi was not giving enough information to use the ESAI so I add to my own dts :

pinctrl_esai_gip2: esaigrp-gip2 {

fsl,pins = <

MX6QDL_PAD_GPIO_2__ESAI_TX_FS 0x1b030

MX6QDL_PAD_GPIO_3__XTALOSC_REF_CLK_24M 0x1b030

MX6QDL_PAD_GPIO_1__ESAI_RX_CLK 0x1b030

MX6QDL_PAD_GPIO_6__ESAI_TX_CLK 0x1b030

MX6QDL_PAD_GPIO_17__ESAI_TX0 0x1b030

MX6QDL_PAD_GPIO_8__ESAI_TX5_RX0 0x1b030

MX6QDL_PAD_GPIO_9__ESAI_RX_FS 0x1b030

MX6QDL_PAD_GPIO_18__ESAI_TX1 0x1b030

MX6QDL_PAD_GPIO_7__ESAI_TX4_RX1 0x1b030

&esai {

dma-names = "rx", "tx";

clocks = <&clks 228>, <&clks 229>, <&clks 118>, <&clks 228>, <&clks 156>;

clock-names = "core", "mem", "extal", "fsys", "dma";

compatible = "fsl,imx35-esai";

fsl,esai-dma-events = <24 23>;

pinctrl-names = "default";

pinctrl-0 = <&pinctrl_esai_gip2>;

fsl,esai-synchronous;

fsl,fifo-depth = <64>; /* Transmit FIFO watermark => the Transmit FIFO Empty flag will set => 32 slots * 2 bus of TX the same for RX */

status = "okay";

};

sound {

compatible = "fsl,imx6q-gipc-generic-esai",

"fsl,imx-audio-generic-esai";

model = "generic-esai-audio";

esai-controller = <&esai>;

};

I do have in my .config :

# SoC Audio for Freescale CPUs

# Common SoC Audio options for Freescale CPUs:

# CONFIG_SND_SOC_FSL_ASRC is not set

CONFIG_SND_SOC_FSL_SAI=y

CONFIG_SND_SOC_FSL_SSI=y

CONFIG_SND_SOC_FSL_SPDIF=y

CONFIG_SND_SOC_FSL_ESAI=y

CONFIG_SND_SOC_FSL_UTILS=y

CONFIG_SND_SOC_IMX_PCM_DMA=y

CONFIG_SND_SOC_IMX_AUDMUX=y

CONFIG_SND_IMX_SOC=y

CONFIG_SND_SOC_IMX_PCM_FIQ=y

I simply make a module that connect to a dummy codec the dai interface ESAI to use it in a generic way : http://pastebin.com/CupYva7Z

thank you for your return

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Wed, 17 Dec 2014 12:40:30 GMT

You missed to add the dma nodes for esai.

Take a look at Documentation/devicetree/bindings/sound/fsl,esai.txt for an example on how to pass the dma nodes.

Also, you don't need to create a "fsl,imx6q-gipc-generic-esai". You can use "simple-card" instead or "fsl-asoc-card".

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Wed, 17 Dec 2014 13:36:12 GMT

Thank you for the dma nodes !!

I didn't know about simple-card, seems like a powerful tool !!

But it seems hard to get the right parameters !!

For the moment I am at :

	sound {
	compatible = "simple-audio-card";
	simple-audio-card,name = "Generic-ESAI-Sound-Card";
	simple-audio-card,bitclock-master = <&link0_cpu>;
	simple-audio-card,frame-master = <&link0_cpu>;
	simple-audio-card,format = "left_j";
	link0_cpu: simple-audio-card,cpu {
		sound-dai = <&esai>;
		dai-tdm-slot-num = <32>;
		dai-tdm-slot-width = <8>;
/*		system-clock-frequency = <2000000>; */
		};
	simple-audio-card,codec {
		sound-dai = <&codec>;
		frame-master;
		bitclock-master;
		};
	};

But I don't see where I can use a fake codec ...

I have an extra question : Do you think that it could be possible to get a different pcm for each slot of the TDM (2x32 in my case)

Thank you very much for your help !!!

Regards,

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Wed, 17 Dec 2014 13:57:28 GMT

Hi Aurelien,

Not sure what you mean by "fake" codec.

I personally haven't used the esai driver in mainline yet. I would recommend you to post this in the alsa-devel mailing list with Nicolin Chen <nicoleotsuka@gmail.com>, who is the driver maintainer on Cc.

Regards,

Fabio Estevam

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Wed, 17 Dec 2014 14:10:12 GMT

Hi again,

When I speak about fake codec I am actually speaking about the snd-soc-dummy that I declared on my module : http://pastebin.com/CupYva7Z :

static struct snd_soc_dai_link snd_soc_dapm_route[] = {
{
.name = "HiFi",
.stream_name = "HiFi",
.codec_name = "snd-soc-dummy",
.codec_dai_name = "snd-soc-dummy-dai",
.ignore_pmdown_time = 1,
.ops = &imx_generic_esai_surround_ops,
},
};

I feel like I won't be able to do the same, just with the devicetree ?!

Thank you for your reply,

Regards,

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Wed, 17 Dec 2014 14:13:23 GMT

why do you need the snd-soc-dummy?

Don't you have a real audio codec connected in your hardware?

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Wed, 17 Dec 2014 14:15:34 GMT

Nope I don't ! I directly connect my ESAI bus to another processor ... They just exchange audio datas directly ...

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Wed, 17 Dec 2014 14:17:48 GMT

Ok, got it. I think people in alsa-devel list would be able to give you some good guidance on this.

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Wed, 17 Dec 2014 15:18:56 GMT

So I am using the ESAI with the master branch of the main git git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git

And I can see that my channels are randomly switching ... seems like the ESAI chip errata is here ...

On the fallowing pictures you can see in blue datas, in yellow frame synchro

You can see on the first attached picture the initial situation : channel[0] et channel[16] have 0xAA, and others 0x0

And after sometimes we get that :

I don't see any debug message concerning xrun or underrrun ...

Thank you for your help,

Regards

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Thu, 18 Dec 2014 16:52:07 GMT

Why the problem is marked as solved ??? it is definitely not the case ...

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Thu, 18 Dec 2014 16:58:39 GMT

Hello,

I get back to linux branch imx_3.10.31_1.1.0_beta2 at git://git.freescale.com/imx/linux-2.6-imx.git

I figured out that the TIE and TEIE bits in the TCR register are not set at any moment ...

So I add in the fsl_esai_set_dai_fmt

#define MAKE_TCR_INTERRUPTIBLE

#ifdef MAKE_TCR_INTERRUPTIBLE

//make it interruptible

printk(KERN_ERR"%s(%d)\n",__func__,__LINE__);

mask |= ESAI_xCR_xEIE_MASK | ESAI_xCR_xIE_MASK;

xcr |= ESAI_xCR_xEIE | ESAI_xCR_xIE;

//make it interruptible

#endif /* MAKE_TCR_INTERRUPTIBLE */

I also add a dump function that show the register at fsl_esai_hw_params : ESAI_TCR 0x00728100

I also add debug in the function fsl_esai_check_xrun that show the saisr register

When underrun occured (when I see that with an oscilloscope)

There is no interrupt generated ...

FYI here is my fsl_esai.c modified : fsl_esai.c - Pastebin.com

Thank you for your help,

Sincerely,

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Mon, 05 Jan 2015 14:35:30 GMT

For your information the problem occured only in slave mode ... (Clock and Frame Synchro is in input)

It is working correctly apparently in master mode ... but the clock and the frame synchro are not correct ... When I ask 2048000Hz I get 2207000 hz

If you have any suggestion ...

Thank you for your help

Re: iMX6 ESAI TDM with underrun and overrun support

ZeeFrench — Thu, 15 Jan 2015 09:33:56 GMT

Bonjour Aurélien,

Your problem seems to have multiple aspects, setting dma was one of it and the oscilloscope above looks like a channel swapping issue (in case of overrun) that is supposed to be fixed by an other group of patches in Yocto http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/log/sound/soc/fsl/fsl_esai.c?h=imx_3.10.53_1.1.0_ga (apparently not in the mainline kernel). This is becoming difficult to follow (do you still have swapping now you are back on beta2 ?), especially if you add a new issue below that is not your use case (looking at our alsa driver documentation, 22 kHz is a standard frequency but no trace of 20 kHz).

I think we need to dig the root cause of underun (and / or overrun ?), not necessary in the esai driver but maybe in dma, since you open a new thread, i propose to follow on that one if that ofk with you ?

Best regards, Philippe.

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Thu, 15 Jan 2015 09:56:53 GMT

Yes, Philippe's suggestion is a good one. Could you please try 3.10.53 GA kernel?

http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/log/?h=imx_3.10.53_1.1.0_ga

Regards,

Fabio Estevam

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Thu, 15 Jan 2015 10:06:13 GMT

Hello Philippe and Fabio,

I keep getting swapping channels with the linux branch imx_3.10.31_1.1.0_beta2 at git://git.freescale.com/imx/linux-2.6-imx.git and it is the same implementation that the one you give me (http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/log/sound/soc/fsl/fsl_esai.c?h=imx_3.10.53_1.1.0_ga)

Again in this driver the implementation is limited to 16 channels (why ?)

FYI here is my fsl_esai.c modified :[C] fsl_esai_updated.c - Pastebin.com

I don't understand 20KHz trace ?

I am using 64 slots of 8 bits word at 8000Hz => mclk=2048000Hz

Thank you for your interest in my problem, I really appreciate it

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

fabio_estevam — Thu, 15 Jan 2015 10:08:26 GMT

Hi Aurelien,

3.10.53 has some additional esai patches that seem to be important for your case.

Please see this one about channel swap:

linux-2.6-imx.git - Freescale i.MX Linux Tree

I would suggest you to try 3.10.53.

Regards,

Fabio Estevam

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Thu, 15 Jan 2015 10:50:13 GMT

Hi again,

I add the patch (http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/commit/sound/soc/fsl/fsl_esai.c?h=imx_3.10.53_1.1.0_ga&id=0e0f397289742141ec9811aa449d033e52b44cd9) but i keep getting swapping

My new code is now http://pastebin.com/66GkXME2

Regards,

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

ZeeFrench — Thu, 15 Jan 2015 13:08:13 GMT

The patch set is not only affecting esai driver, I haven't locate something (need to dig in the sdma) that could explain this phenomenum but it would still be interresting to test a complete kernel. The workaround to the hardware errata is to manage startup condition and reset esai in case of overrun but I don't see any fix in case of underrun : your message below seems to indicate you are experiencing both over and underruns ?

Cheers, Philippe.

Re: iMX6 ESAI TDM with underrun and overrun support

aurelienbouin — Thu, 15 Jan 2015 15:03:59 GMT

Hello,

So I git clone the linux branch imx_3.10.53_1.1.0_ga on git://git.freescale.com/imx/linux-2.6-imx.git

I patched it with this : http://pastebin.com/RM8pyUSA

It makes 64 slots available and set a correct clock to pll4 to get 2048000Hz

Unfortunetaly I also get swapping without anything un debug that can help me detect it ...

Thank you again for your suggestions,

Regards

Aurelien BOUIN

Re: iMX6 ESAI TDM with underrun and overrun support

leige-b42127 — Fri, 16 Jan 2015 03:20:31 GMT

hi, i have a way to use different pcms for each slot. It is from the alsa_lib side, you can use deshare plug-in to do this.