i.MX ProcessorsのトピックRe: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Fri, 28 Apr 2023 08:21:29 GMT

Hi everybody,

referring to:

https://github.com/NXP/vizn3d_smartlock_oobe/tree/rt117x/smart_lockhttps://github.com/NXP/vizn3d_smartlock_oobe

I correctly see that, because of XIP, sln_flash.c and related have been relocated to SRAM_ITC_cm7 through linkscripts and that during erase, write, etc. operations interrupts and D-Cache are disabled:

SpoonMan_0-1682669669975.png

But then I noticed that, because this project is based on RTOS, SysTick ISR is suspended during relatively long calls (sector erase may be 300 ms long according to the datasheet):

SpoonMan_2-1682669855570.png

I know we're talking about 300 ms, which are not a lifetime but anyway are equivalent to 300 ticks skipped at every erase operation (and because of the filesystem we may have a lot of consecutive erase operation).

So the questions are:

- how this would affect RTOS scheduling?

- disabling ALL interrupts during such long operation is good practice?

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Thu, 04 May 2023 05:22:23 GMT

Hi @SpoonMan ,

Answer your questions:

1 how this would affect RTOS scheduling?

=>Answer: It won't influence the RTOS schedule, if you design your RTOS properly. Just make sure your API which use erase function can more than 300ms.

2 disabling ALL interrupts during such long operation is good practice?

=>Answer: To this application, which need to do the flash operation in the flash code, disable ALL interrupt just make sure no issue happens. Otherwise, the flash operation may meet issues.

Wish it helps you!

Best Regards,

kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Thu, 04 May 2023 07:11:30 GMT

Hi @kerryzhou! Thank you very much for participating in this discussion, your contribution to this forum is very important for me.

Just make sure your API which use erase function can more than 300ms.

Can more than 300ms... what? Execute? If yes, I think this is not a problem at all, because while erasing IRQs are disabled; consequently, SysTick is disabled, which means RTOS scheduling is disabled too, so there's no risk the operation is interrupted...

disable ALL interrupt just make sure no issue happens. Otherwise, the flash operation may meet issues.

Yes, I know this very well... my question was if it's good practice to disable IRQs for so long operations (not what we intend for "atomic" I say) without taking care of consequences on scheduling times due to the disabling of SysTick IRQ.

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Thu, 04 May 2023 08:40:06 GMT

Hi @SpoonMan ,

Thanks for your updated information.

You can check the related flash operation, whether it is the flexSPI API method, not the ROM, if yes, it needs to disable the interrupt.

In fact, that application you mentioned, also can make the application work, so you can refer to it.

For the flash operation, I think you also can try the ROM API method. ROM code will not be very sensitive like the flexSPI direct operation code.

About the interrupt disable, the freertos also have the related API which some code don't need to break by the interrupt, eg. taskENETER_CRITICAL_FROM_ISR();

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Thu, 04 May 2023 09:31:29 GMT

For the flash operation, I think you also can try the ROM API method. ROM code will not be very sensitive like the flexSPI direct operation code.

I'm on i.MX RT1052 so I think that ROM API is not available for my platform, even if I really don't know the details about which benefits would I have if using ROM API instead of FlexSPI API.

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Fri, 05 May 2023 05:12:02 GMT

Hi @SpoonMan ,

RT1050 is really not the complete ROM API.

But you still can refer to:

SDK_2_13_0_EVKB-IMXRT1050\boards\evkbimxrt1050\driver_examples\fsl_romapi

You can check it on your side.

Wish it helps you!

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Fri, 05 May 2023 07:42:41 GMT

This sounds interesting, even if it looks like it works only on HyperFlash (some serial NOR structures and methods are missing in fsl_romapi.c/.h for 1050) while I'm oriented on QSPI Flash... am I right?

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Tue, 09 May 2023 03:14:47 GMT

Hi @SpoonMan ,

So sorry for my later reply!

Yes, if you use the QSPI flash, you also can refer to that code, just do the FLEXSPI_NorFlash_GetConfig modification with the QSPI flash.

Maybe you don't know how to modify it, one example for you is the RT1060 flexspi polling code, that is the QSPI flash.

Wish it helps you!

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Tue, 09 May 2023 08:36:30 GMT

Hi @kerryzhou

Don't worry about reply time... I'm also very busy on other topics, so it's not vital if I have no answer in minutes!

one example for you is the RT1060 flexspi polling code, that is the QSPI flash.

Yes, in fact when I said:

some serial NOR structures and methods are missing in fsl_romapi.c/.h for 1050

I was intending that I already tried to port 1060 example on 1050, but then I noticed that some serial NOR structures and methods was missing in fsl_romapi.c/.h for 1050. What I've done is the following:

populate my workspace with "evkbimxrt1050_fsl_romapi" example
changed project memory details to adapt to QSPI Flash:

SpoonMan_1-1683618177433.png

updated BOARD_FLASH_SIZE macro in "board.h":

/*! @brief The board flash size */ #define BOARD_FLASH_SIZE (0x800000U)

(brutally) replaced XIP folder content, picking files from "evkbimxrt1060_fsl_romapi" example
(brutally) replaced flexspi_romapi.c (main.c), picking file from "evkbimxrt1060_fsl_romapi" example
removed "flexspi_romapi_ops.c" file

At this point, methods like ROM_FLEXSPI_NorFlash_GetConfig() are not present in ROM API implementation for 1050, and if I also brutally replace fsl_romapi.c/.h files from "evkbimxrt1060_fsl_romapi" example then I fall into Hard Fault runtime exception due to ROM API code incompatibility:

SpoonMan_2-1683621008747.png

just do the FLEXSPI_NorFlash_GetConfig modification with the QSPI flash

Could you please better explain what do you mean I have to do when you say that?

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Tue, 09 May 2023 08:45:42 GMT

Basically, what I notice it's wrong when replacing ROM API implementation from 1060 to 1050, are "bootloader_api_entry_t" and "flexspi_nor_driver_interface_t" definitions which are quite different and not providing get_config() method on 1050.

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Thu, 11 May 2023 05:11:07 GMT

Hi @SpoonMan ,

Yes, RT1050, RT1060 ROM API is not the same.

As the RT1060 ROM support the get_config, but RT1050 can't support it.

kerryzhou_0-1683781668255.png

You need to manually configure the get_config in the RT1050, just this API:

void FLEXSPI_NorFlash_GetConfig(flexspi_nor_config_t *config)

I mean, you need to modify the API internal related configuration, the config-> LUT, etc.

For the detail content, you can refer to the flexspi_polling in :

SDK_2_13_0_EVKB-IMXRT1050\boards\evkbimxrt1050\driver_examples\flexspi\nor

It's not difficult, you can try it, if you still meet issues, let me know, I may find time to help you to modify it. But for this part, it's better to create a new question post about it, as this post is a little old.

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Thu, 11 May 2023 07:29:08 GMT

You need to manually configure the get_config in the RT1050, just this API:
void FLEXSPI_NorFlash_GetConfig(flexspi_nor_config_t *config)
I mean, you need to modify the API internal related configuration, the config-> LUT, etc.

I think it's not necessary at all, we already have the correct flexspi_nor_config_t structure defined in evkbimxrt1050_flexspi_nor_config.c! I mean this:

SpoonMan_0-1683790133048.png

Let me give it a try to confirm...

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Thu, 11 May 2023 13:54:20 GMT

Yessss! I succeeded!

FLEXSPI NOR example started! Successfully init FLEXSPI serial NOR flash HyperFlash Information: Total program flash size: 8192 KB, Hex: (0x800000) Program flash sector size: 4 KB, Hex: (0x1000) Program flash page size: 256 B, Hex: (0x100) Erasing serial NOR flash over FLEXSPI Successfully erased one sector of NOR flash device 0x7ff000 -> 0x800000 Program a buffer to a page of NOR flash Successfully programmed and verified location FLEXSPI memory 0x607ff000 -> 0x607ff100 End of FLEXSPI NOR Example!

In the following, I'll report what I modified in 1050 ROM API example project to make it working with QSPI Flash, instead of HyperFlash. In all the screenshots I'm going to post, left side is always MODIFIED code, right side is ORIGINAL EXAMPLE code.

First, I adjusted BOARD_FLASH_SIZE macro in board.h to reflect QSPI Flash total size:

SpoonMan_0-1683811229316.png

Then I basically replaced evkbimxrt1050_flexspi_nor_config.h and evkbimxrt1050_flexspi_nor_config.c content with code from evkbimxrt1060_fsl_romapi example project; in evkbimxrt1050_flexspi_nor_config.h file, the only difference is the following:

SpoonMan_1-1683811378224.png

while for evkbimxrt1050_flexspi_nor_config.c file basically EVERYTHING is different; in this case, let me just copy-paste modified file content:

/* * Copyright 2021 NXP * All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause */ #include "evkbimxrt1050_flexspi_nor_config.h" /* Component ID definition, used by tools. */ #ifndef FSL_COMPONENT_ID #define FSL_COMPONENT_ID "platform.drivers.xip_board" #endif /******************************************************************************* * Code ******************************************************************************/ #if defined(XIP_BOOT_HEADER_ENABLE) && (XIP_BOOT_HEADER_ENABLE == 1) #if defined(__CC_ARM) || defined(__ARMCC_VERSION) || defined(__GNUC__) __attribute__((section(".boot_hdr.conf"), used)) #elif defined(__ICCARM__) #pragma location = ".boot_hdr.conf" #endif const flexspi_nor_config_t qspiflash_config = { .memConfig = { .tag = FLEXSPI_CFG_BLK_TAG, .version = FLEXSPI_CFG_BLK_VERSION, .readSampleClksrc=kFlexSPIReadSampleClk_LoopbackFromDqsPad, .csHoldTime = 3u, .csSetupTime = 3u, .controllerMiscOption = (1u << kFlexSpiMiscOffset_SafeConfigFreqEnable), .deviceType = kFlexSpiDeviceType_SerialNOR, .sflashPadType = kSerialFlash_4Pads, .serialClkFreq = kFlexSpiSerialClk_120MHz, .sflashA1Size = 8u * 1024u * 1024u, .lookupTable = { // Read LUTs [0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0xEB, RADDR_SDR, FLEXSPI_4PAD, 0x18), [1] = FLEXSPI_LUT_SEQ(DUMMY_SDR, FLEXSPI_4PAD, 0x06, READ_SDR, FLEXSPI_4PAD, 0x04), // Read Status LUTs [4 * 1 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0x05, READ_SDR, FLEXSPI_1PAD, 0x04), // Write Enable LUTs [4 * 3 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0x06, STOP, FLEXSPI_1PAD, 0x0), // Erase Sector LUTs [4 * 5 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0x20, RADDR_SDR, FLEXSPI_1PAD, 0x18), // Erase Block LUTs [4 * 8 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0xD8, RADDR_SDR, FLEXSPI_1PAD, 0x18), // Page Program LUTs [4 * 9 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0x02, RADDR_SDR, FLEXSPI_1PAD, 0x18), [4 * 9 + 1] = FLEXSPI_LUT_SEQ(WRITE_SDR, FLEXSPI_1PAD, 0x04, STOP, FLEXSPI_1PAD, 0x0), // Erase Chip LUTs [4 * 11 + 0] = FLEXSPI_LUT_SEQ(CMD_SDR, FLEXSPI_1PAD, 0x60, STOP, FLEXSPI_1PAD, 0x0), }, }, .pageSize = 256u, .sectorSize = 4u * 1024u, .ipcmdSerialClkFreq = 1u, .blockSize = 64u * 1024u, .isUniformBlockSize = false, }; #endif /* XIP_BOOT_HEADER_ENABLE */

In main source file (flexspi_romapi.c, don't ask me why NXP is not simply calling it main...) I commented out FLEXSPI_NorFlash_GetConfig() method because, as explained in my previous post, the idea is to read FLASH configuration from qspiflash_config instance already defined in evkbimxrt1050_flexspi_nor_config.c file:

SpoonMan_0-1683811884162.png

[...]

SpoonMan_1-1683811920910.png

I commented out everything related to local norConfig copy in main() method:

SpoonMan_2-1683812031791.png

then, in each call involving norConfig pointer, I substituted it with (flexspi_nor_config_t*)&qspiflash_config. Let me post just some examples and not the entire code, you can do it by yourself easily:

SpoonMan_3-1683812578974.png

SpoonMan_4-1683812659935.png

Also local variables used for total FLASH size calculation etc. should take memory geometry information from qspiflash_config instead of norConfig:

SpoonMan_6-1683812829671.png

and, more than this, qspiflash_config should be visible from main source file:

SpoonMan_7-1683812922956.png

Last but not least, some macros related to memory geometry defined in main file (don't ask me why NXP is defining here and there macros reporting again and again always the same memory geometry information...) are no more necessary because related to FLEXSPI_NorFlash_GetConfig() method which we will not use anymore, but FLASH_PAGE_SIZE should be adapted because used by the sample code as read and write size:

SpoonMan_8-1683813153154.png

That's it! Hope that my contribution will be appreciated, obviously thanks to @kerryzhou for giving some hint!

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Thu, 11 May 2023 15:19:57 GMT

Sorry @kerryzhou but you said:

You can check the related flash operation, whether it is the flexSPI API method, not the ROM, if yes, it needs to disable the interrupt.

But if I configure and enable GPT2 to generate a periodic interrupt (in which I toggle USER_LED state, this doesn't matter) and I loop in a while (1) erase/program/read/verify code from ROM API example, I then fall into hard fault as with FLEXSPI API if I don't disable interrupts while performing FLASH operations.........

SpoonMan_0-1683815013622.png

SpoonMan_1-1683815045390.png

This is not what you mentioned in the quoted sentence... could you please help? I'm a little bit disappointed... Here is where I'm looping forever:

SpoonMan_0-1683818304012.png

[...]

SpoonMan_1-1683818385394.png

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Fri, 12 May 2023 10:29:48 GMT

Please give me more time to check your issues, really so long.

These days, really a lot of cases in the queue, we are a little overflow, please keep patient, thanks a lot for your understanding.

Best Regards,

kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Fri, 12 May 2023 10:35:52 GMT

Don't worry for the delay, I'll wait... I have a lot of tasks waiting in my queue too, so I understand and I can can block current task in the meanwhile and schedule another one.

Let me know when you have some news, thanks in advance!

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Tue, 16 May 2023 09:15:13 GMT

HI @SpoonMan ,

Just conform with you, with the ROM API, if you don't open the GPT interrupt, the write, erase, read are all working now, right?

But, when enable the GPT interrupt, it is failed, whether my understanding is correct or not?

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Tue, 16 May 2023 09:23:49 GMT

Hi @kerryzhou

Yes, your understanding of my behavior is 100% correct. But please check my project, it'll help you to kickstart straight to the problem.

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

kerryzhou — Fri, 19 May 2023 03:11:23 GMT

Hi @SpoonMan ，

Sorry for the misleading previously.

I talked about your issues without an internal expert, and get the information that:

1. vector table in the flash need to copy to the internal RAM, and redirect the VTOR to the internal RAM.

2. copy the interrupt service function to the internal RAM. eg, your GPT2 interrupt Handler function to the internal RAM.

Then, you will do the flash operation.

Some blog from our expert may useful to you, but it is in Chinese, you can translate it, and try it on your side.

If you still meet issues, I will find time, to design one MCUXPresso project for it.

https://www.nxpic.org.cn/module/forum/forum.php?mod=viewthread&tid=622919&highlight=%E9%87%8D%E5%AE%9A%E5%90%91

https://www.nxpic.org.cn/module/forum/forum.php?mod=viewthread&tid=623079&highlight=%E9%87%8D%E5%AE%9A%E5%90%91

This post is also useful to you:

https://community.nxp.com/t5/i-MX-Processors/i-MXRT1021-amp-amp-MCUPresso-IDE-Interrupt-the-method-of/td-p/1542220

Best Regards,

Kerry

Re: Disabling IRQ during FlexSPI operations (erase, write, etc.) stops SysTick

SpoonMan — Fri, 19 May 2023 09:54:43 GMT

Hi @kerryzhou

Thanks for your feedback, I have at least two questions:

described method of moving vector table and ISRs to RAM is also valid for fsl_flexspi API, not only for ROM API, so what are the benefits of using ROM API instead of FlexSPI API?
described method of moving vector table and ISRs to RAM looks to be not sufficient when applied in a time-division scheduling RTOS scenario, in which SysTick ISR may schedule another task while active task is still reading/writing/erasing the FLASH, consequently all tasks must be moved to RAM, and all functions called by all task must be moved to RAM.... or briefly, all the code must be moved to RAM.