i.MX Processors中的主题 Re: TP2850 de-interlace driver for iMX8MP boards

TP2850 de-interlace driver for iMX8MP boards

FredTsai — Tue, 04 Oct 2022 09:45:15 GMT

After referring to the website you provided, there will be a problem that mx8_v4l2_cap_drm_64 cannot be recorded, please help analyze this issue, thank you.

Here is my environment:

HW platform: IMX8MP

Video-In: TP2850

Linux Version: 5.10.52

Android Version: 11

Refer to your previous article on de-interlace:

https://community.nxp.com/t5/i-MX-Processors-Knowledge-Base/ISL79987-and-adv7180-de-interlace-driver-for-iMX8QXP-boards/ta-p/1124075

1. Refer to the Patch provided by your article (L5.4.0_2.3.0_ISL7998x_Patch.7z)

2. After unzip, I refer to 0001-ISI-Add-de-interlace-support.patch to Patch to my BSP

3. DTS isi_0 settings are as follows (NTSC weave mode):

4. After applying PATCH, use mx8_v4l2_cap_drm_64 to verify, the result cannot be recorded, it will always stop at (v4l2_device_streamon:1478): channel[0] v4l_dev=0x4 start capturing.

(command: mx8_v4l2_cap_drm_64 -cam 1 -d "/dev/video1" -fmt YUYV -ow 1280 -oh 720 –of)

5. The attached file is the LOG of the video recorded by mx8_v4l2_cap_drm_64, and the ISI0 register has been dumped.

Please help to analyze this issue, thank you.

Thanks

Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Wed, 12 Oct 2022 01:53:18 GMT

What's the camera's input resolution? If it is 1280*720, it should a progressive signal, no de-interlace is needed.

If it is not 1280*720, then in ISI, you must set the same resolution as the camera original resolution, de-interlace can't work with scaling or CSC.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Wed, 12 Oct 2022 03:15:18 GMT

Hi @qiang_li-mpu_se ,

Input resolution: CVBS (NTSC de-interlace)

The attached file is the LOG of the video recorded by mx8_v4l2_cap_drm_64, and the ISI0 CSI register has been dumped, resolution set to 720*480.

it will always stop at (v4l2_device_streamon:1478): channel[0] v4l_dev=0x4 start capturing.

Please help to analyze this issue, thank you.

Thanks

Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Mon, 17 Oct 2022 10:03:57 GMT

From "CSIS_INTSRC[14]: 0x00000010", there is no MIPI FRAME_START and FRAME_END bits appear, that means no valid MIPI packages received.

For different camera sensor, the "csis-hs-settle" value in device tree should be adjusted basded on MIPI CSI2 data rate.

And before debug the de-interlace mode, you need make sure the normal camera capture works first. If there are no FE(Frame End) and FS(Frame Start) between the two fields, then software can capture it as a normal 720*480@30fps camera. Two fields will be captured in to one buffer.

If there are FE and FS between the two fields, then software can capture it as a normal 720*240@60fps camera.

When no de-interlace mode works, then you can debug the de-interlace mode.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Tue, 18 Oct 2022 05:57:40 GMT

Hi @qiang_li-mpu_se ,

1. Through oscilloscope measurement, TP2850 has MIPI signal output, as shown in the figure below.

MIPI Clock

MIPI Data

2. Below is the tp2850 mipi csi DTS setting.
When the TP2850 is set to progressive and remove de-interlaced patch, capture works.

3. Make sure the normal camera capture works first.
(Use mx8_v4l2_cap_drm_64 to verify the OV5640 camera)

Do you have any suggestions for DEBUG?

Thanks

Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Tue, 18 Oct 2022 06:47:30 GMT

For iMX8MP de-interlace, imx8-mipi-csi2-sam.c should be updated for de-interlace, this is different to iMX8QXP.

diff --git a/drivers/staging/media/imx/imx8-mipi-csi2-sam.c b/drivers/staging/media/imx/imx8-mipi-csi2-sam.c
index 1d12365520a6..ddfe30fb2a0a 100644
--- a/drivers/staging/media/imx/imx8-mipi-csi2-sam.c
+++ b/drivers/staging/media/imx/imx8-mipi-csi2-sam.c
@@ -228,6 +228,9 @@

/* display_mix_clk_en_csr */
#define DISP_MIX_GASKET_0_CTRL 0x00
+#define GASKET_0_CTRL_INTERLACE_MODE(x) (((x) & (0x3)) << 6)
+#define GASKET_0_CTRL_INTERLACE_MODE_MASK ((0x3UL) << (6))
+
#define GASKET_0_CTRL_DATA_TYPE(x) (((x) & (0x3F)) <<
#define GASKET_0_CTRL_DATA_TYPE_MASK ((0x3FUL) << (8))

@@ -988,6 +991,13 @@ static void disp_mix_gasket_config(struct csi_state *state)
if (fmt_val == GASKET_0_CTRL_DATA_TYPE_YUV422_8)
val |= GASKET_0_CTRL_DUAL_COMP_ENABLE;
val |= GASKET_0_CTRL_DATA_TYPE(fmt_val);
+
+ val &= ~GASKET_0_CTRL_INTERLACE_MODE_MASK;
+
+ printk("%s, field interlaced=%d\n", __func__, (state->format.field == V4L2_FIELD_INTERLACED? 1 : 0));
+ if (state->format.field == V4L2_FIELD_INTERLACED)
+ val |= GASKET_0_CTRL_INTERLACE_MODE(0x2);
+
regmap_write(gasket, DISP_MIX_GASKET_0_CTRL, val);

if (WARN_ON(!mf->width || !mf->height))
--

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Tue, 18 Oct 2022 08:51:02 GMT

Hi @qiang_li-mpu_se ,

After adding the patch to the BSP, the situation is the same, the attachment is Failed LOG, I have added LOG for DEBUG.

Thanks

Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Tue, 18 Oct 2022 13:57:05 GMT

The verified working patch is attached, we used the ov5640 camera for test, and handle its frame (1280*720) as field, then after de-interlace, the capture frame is 1280*1440.

You can reference to it and identify is there any difference. By the way, to debug the driver, I think you'd better use the unit test application "mx8_v4l2_cap_drm.out" first.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Fri, 21 Oct 2022 07:28:27 GMT

Hi @qiang_li-mpu_se ,

The attached file is the LOG and recorded video of OV5640 and TP2850.

Removed L5.4.0_2.3.0_ISL7998x_Patch.7z, use
0001-Add-ISI-weaving-deinterlace-support-for-i.MX8MP.patch,
The result can be recorded to video through mx8_v4l2_cap_drm,
It should be correct to output a blue picture, but currently only see a blue line.

DTS:

Please analyze or provide suggestions, thank you.

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Fri, 21 Oct 2022 07:42:22 GMT

Can you capture the stream to file and attach here?

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Fri, 21 Oct 2022 08:25:07 GMT

Hi @qiang_li-mpu_se ,

The attached file is the captured stream.

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Fri, 21 Oct 2022 08:57:49 GMT

I think you can check is there any other interrupt happens in ISI_CHNL_STS register.

And in isi_capture driver code, is there any code skip some frames. This is BSP version related.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Mon, 24 Oct 2022 05:20:56 GMT

Hi @qiang_li-mpu_se ,

As attached file LOG.

CHNL_STS is 0x100.
[ 64.904867][ T1793] mxc-isi 32e00000.isi: CHNL_STS[0x14]: 100

imx8-isi-cap.c: only skip frame once
[ 89.369850][ C0] isi-capture 32e00000.isi:cap_device: Skip frame when buffer number is not match ISI trigger buffer

Do you have any suggestions for DEBUG?

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Mon, 24 Oct 2022 08:03:58 GMT

These codes should be removed, for de-interlace mode, each buffer will generate two interrupts, so it will not align with buffer buffer number.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Thu, 27 Oct 2022 06:24:11 GMT

Hi @qiang_li-mpu_se ,

I have removed these codes, but the output still does not improve.

Remove code: (imx8-isi-cap.c -> mxc_isi_cap_frame_write_done)

output:

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Thu, 27 Oct 2022 08:16:06 GMT

Please print out the CHNL_STS register value for each interrupt in function mxc_isi_irq_handler():

status = mxc_isi_get_irq_status(mxc_isi);

+ printk("STS = 0x%x.\n", status);

And in mxc_isi_enable_irq() function, you can just enable RCVD interrupt to try:

void mxc_isi_enable_irq(struct mxc_isi_dev *mxc_isi)
{
u32 val;

val = CHNL_IER_FRM_RCVD_EN_MASK;
writel(val, mxc_isi->regs + CHNL_IER);
}

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Thu, 27 Oct 2022 08:38:42 GMT

Hi @qiang_li-mpu_se ,

The code has been modified as you suggested,

imx8-isi-hw.c

imx8-isi-core.c

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Thu, 27 Oct 2022 09:01:48 GMT

Bit 17 EARLY_VSYNC_ERR appears in each interrupt, that means before ISI received 720 lines of video, VSYNC appears. So the TP2850 output field data is not 1280*720, you need identify the correct resolution for TP2850, and set it into ISI.

For example, if the TP2850's output is 720*240 field size, and you set 1280*720 in ISI, then you will get current issue, EARLY_VSYNC_ERR appears, and in capture buffer, there is only video data at the start of the buffers.

Re: TP2850 de-interlace driver for iMX8MP boards

FredTsai — Fri, 28 Oct 2022 03:11:36 GMT

Hi @qiang_li-mpu_se ,

The output of TP2850 is NTSC signal with a resolution of 720x480.
I modified camera_metadata(720X480), but the result is still the same, is there anything else that needs to be confirmed??

The attached file is the camera metadata and the test LOG after modifying the camera metadata.

Thanks
Fred

Re: TP2850 de-interlace driver for iMX8MP boards

qiang_li-mpu_se — Fri, 28 Oct 2022 07:18:53 GMT

From register "CHNL_IMG_CFG[0x0c]: 2d00500", it is still 1280*720.