[LF-5.15.32-2.0.0] Add RAW10 support

khang_letruong — Thu, 11 Aug 2022 06:22:44 GMT

Dear NXP Team,

I am migrating to the latest BSP release :

In drivers/staging/media/imx/imx8-isi-cap.c :

/* * Pixel link input format */ struct mxc_isi_fmt mxc_isi_src_formats[] = { { .name = "RGB32", .fourcc = V4L2_PIX_FMT_RGB32, .depth = { 32 }, .memplanes = 1, .colplanes = 1, .align = 2, }, { .name = "YUV32 (X-Y-U-V)", .fourcc = V4L2_PIX_FMT_YUV32, .depth = { 32 }, .memplanes = 1, .colplanes = 1, .align = 2, + }, { + .name = "RAWRGB10 (SRGGB10)", + .fourcc = V4L2_PIX_FMT_SRGGB10, + .depth = { 16 }, + .memplanes = 1, + .colplanes = 1, + .align = 3, } };

And in drivers/staging/media/imx/imx8-isi-fmt.c

struct mxc_isi_fmt mxc_isi_out_formats[] = { { .name = "RGB565", .fourcc = V4L2_PIX_FMT_RGB565, .depth = { 16 }, .color = MXC_ISI_OUT_FMT_RGB565, .memplanes = 1, .colplanes = 1, .align = 3, .mbus_code = MEDIA_BUS_FMT_RGB565_1X16, }, { .name = "RGB24", .fourcc = V4L2_PIX_FMT_RGB24, .depth = { 24 }, .color = MXC_ISI_OUT_FMT_BGR32P, .memplanes = 1, .colplanes = 1, .align = 2, .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, }, { .name = "BGR24", .fourcc = V4L2_PIX_FMT_BGR24, .depth = { 24 }, .color = MXC_ISI_OUT_FMT_RGB32P, .memplanes = 1, .colplanes = 1, .align = 2, .mbus_code = MEDIA_BUS_FMT_BGR888_1X24, }, { .name = "YUYV-16", .fourcc = V4L2_PIX_FMT_YUYV, .depth = { 16 }, .color = MXC_ISI_OUT_FMT_YUV422_1P8P, .memplanes = 1, .colplanes = 1, .align = 3, .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16, }, { .name = "YUV32 (X-Y-U-V)", .fourcc = V4L2_PIX_FMT_YUV32, .depth = { 32 }, .color = MXC_ISI_OUT_FMT_YUV444_1P8, .memplanes = 1, .colplanes = 1, .align = 2, .mbus_code = MEDIA_BUS_FMT_AYUV8_1X32, }, { .name = "NV12 (YUYV)", .fourcc = V4L2_PIX_FMT_NV12, .depth = { 8, 8 }, .color = MXC_ISI_OUT_FMT_YUV420_2P8P, .memplanes = 2, .colplanes = 2, .align = 4, .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16, }, { .name = "YUV444M (Y-U-V)", .fourcc = V4L2_PIX_FMT_YUV444M, .depth = { 8, 8, 8 }, .color = MXC_ISI_OUT_FMT_YUV444_3P8P, .memplanes = 3, .colplanes = 3, .align = 4, .mbus_code = MEDIA_BUS_FMT_YUV8_1X24, }, { .name = "xBGR32", .fourcc = V4L2_PIX_FMT_XBGR32, .depth = { 32 }, .color = MXC_ISI_OUT_FMT_XRGB32, .memplanes = 1, .colplanes = 1, .align = 2, .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, }, { .name = "ABGR32", .fourcc = V4L2_PIX_FMT_ABGR32, .depth = { 32 }, .color = MXC_ISI_OUT_FMT_ARGB32, .memplanes = 1, .colplanes = 1, .align = 2, .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, + }, { + .name = "RAWRGB10 (SRGGB10)", + .fourcc = V4L2_PIX_FMT_SRGGB10, + .depth = { 16 }, + .color = MXC_ISI_OUT_FMT_RAW16, + .memplanes = 1, + .colplanes = 1, + .align = 3, + .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10, } };

Compared to previous 5.10 releases, there''s additional .align field. I would like to know what is the suitable value for the RAW10 format as in the code snippet, please ?

Thanks in advance and best regards,
Khang

Re: [LF-5.15.32-2.0.0] Add RAW10 support

joanxie — Fri, 19 Aug 2022 08:22:19 GMT

let me double check this and tell you later

Re: [LF-5.15.32-2.0.0] Add RAW10 support

khang_letruong — Mon, 29 Aug 2022 04:29:33 GMT

Dear @joanxie ,

Have you had any update on this, please ?

Best Regards,

Khang

Re: [LF-5.15.32-2.0.0] Add RAW10 support

joanxie — Wed, 31 Aug 2022 09:03:01 GMT

I still don't get any feedback from internal team

Re: [LF-5.15.32-2.0.0] Add RAW10 support

joanxie — Thu, 01 Sep 2022 09:32:05 GMT

I don't get reply, but I read the code and found the patch for align is that bsp team a

4l_bound_align_image, then you can find this function is defined in the

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/media/v4l2-core/v4l2-common.c?h=lf-5.15.y

you can focus on the function *w = clamp_align(*w, wmin, wmax, walign), you can to find how to define the clamp_align then figure out what walign is for

topic Re: [LF-5.15.32-2.0.0] Add RAW10 support in i.MX Processors

[LF-5.15.32-2.0.0] Add RAW10 support

Re: [LF-5.15.32-2.0.0] Add RAW10 support

Re: [LF-5.15.32-2.0.0] Add RAW10 support

Re: [LF-5.15.32-2.0.0] Add RAW10 support

Re: [LF-5.15.32-2.0.0] Add RAW10 support