topic Re: Android 10 - i.MX8MMini - g2d rotation issue in i.MX Processors

Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Wed, 06 May 2020 14:52:48 GMT

Hi,

I've found an issue with the G2D HWC layer on i.MX8M Mini, here is my setup:

- Android 10.0.0-1.0.0 release

- i.MX8M Mini EVK platform

- MIPI display (1280x800 in my case)

- SF_PRIMARY_DISPLAY_ORIENTATION set to 90 (standard AOSP orientation variable)

That last variable changes the default display orientation from landscape to portrait in my case.

When using the default hwcomposer setting ("g2d 2D composition enabled!") rotation fails as you can see in the pictures attached:

- android10-imx8mm-portrait-g2dcompose.png = screencap output, looks correct/expected

- android10-imx8mm-portrait-g2dcompose-real-life.jpg = what I actually get on the screen

Now if I disable g2d hwc ("Opengl ES 3D composition enabled!"), it works as expected, it looks exactly like the screencap picture.

Let me know if you need any other info.

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Mon, 11 May 2020 13:33:24 GMT

Hello Gary,

This issue can be reproduced on 8mm-evk + 10.0.0_1.0.0 ga with build in rotation setting.

But with cmd line , it work well. We will check this issue.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Mon, 11 May 2020 13:41:09 GMT

Hi,

Thanks for your feedback, looking forward to the fix.

In the meantime, can you explain this sentence: "with cmd line, it work well", what cmdline argument do you use to rotate the display?

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Mon, 11 May 2020 14:36:14 GMT

Hi Gary,

Try at Console, with this cmd:

content insert --uri content://settings/system --bind name:s:user_rotation --bind value:i:1

it will rotate 90 and display output is correct.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Mon, 11 May 2020 14:40:32 GMT

Hi,

Oh ok I see, yes I confirm this kind of rotation works ok, I thought you meant "cmd line" like in kernel "cmdline".

I believe those 2 rotations are not handled the same in SurfaceFlinger.

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Wed, 20 May 2020 08:21:21 GMT

Hi,

Do you have any update on this issue?

Thanks,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Wed, 20 May 2020 13:39:28 GMT

Hello,

I found the cause that composer layer should also rotate 90 when build in SF_PRIMARY_DISPLAY_ORIENTATION=90,

can you try :

vendor\nxp-opensource\imx\display\display\Composer.cpp
int Composer::composeLayer(Layer* layer, bool bypass)
{
    if (layer == NULL || mTarget == NULL) {
        ALOGE("composeLayer: invalid layer or target");
        return -EINVAL;
    }

// test composer rot90 // adding below code
layer->transform = 4;

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Thu, 21 May 2020 08:51:46 GMT

Hi,

I confirm that it fixes part of the problem, but then it breaks the user rotation:

content insert --uri content://settings/system --bind name:s:user_rotation --bind value:i:1

Do you have any timeframe on the proper solution?

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Fri, 22 May 2020 13:44:03 GMT

Hello,

it can't rotate both these two methods.

if they want to build in rotation , to use this way, others please use cmd line to ration.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Mon, 25 May 2020 07:19:58 GMT

Hi,

I'm not sure i understand your reply.

But yes both rotation can happen, the one I'm talking about is the display orientation, that sets the display "default" rotation for a user rotation of 0. But then user can still rotate the display (via accelerometer or content command) that "adds" the rotation to original display orientation. That is how it works for 3G GPU rendering or with hwcomposer of other vendors.

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Fri, 05 Jun 2020 13:27:01 GMT

Hi,

some update: android framework design not consider it support in HWC， now the only hack way can rotate with buildin SF_PRIMARY_DISPLAY_ORIENTATION=90 or "content insert " cmd control at run time.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Sun, 07 Jun 2020 18:59:49 GMT

Hi,

As replied before the "hack" from before is an unacceptable solution as it breaks user rotation.

So NXP plan is just to deliver a broken HWC and not care about it? Pushing customers to use OpenGL rendering instead as it behaves properly?

Will this be added to the known issue list of next release?

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Wed, 10 Jun 2020 13:21:23 GMT

Hi,

This is not NXP HWC issue. framework doesn't consider it support in HWC. there is only a workround to meet this rotation anywhere request.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Wed, 10 Jun 2020 13:31:58 GMT

Hi,

How come the "framework doesn't consider it support in HWC"? It must be something missing in the HWC declaration.

Can you point to the source code?

Why does it work on HWC of other vendors like Qualcomm?

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Wed, 10 Jun 2020 16:55:10 GMT

Hello Gary,

I forgot copy the above patch “rotation_anyway_0610.patch.zip ” Can you try it?

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Wed, 10 Jun 2020 16:59:56 GMT

Hi,

It says "Unauthorized".

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Wed, 10 Jun 2020 17:07:52 GMT

Here is

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Thu, 11 Jun 2020 13:26:34 GMT

Hi,

That is indeed a workaround that works for 1 value. Will NXP integrate such approach for all possibilities (switch case basically)?

Regards,

Gary

Re: Android 10 - i.MX8MMini - g2d rotation issue

Bio_TICFSL — Thu, 02 Jul 2020 21:16:27 GMT

Hi,

"It is framework not pass the rotation information to HWC, no formal way to fix it." Please use work round method now. Internal team will update if there will be HWC public code introduced the rotation information.

Regards

Re: Android 10 - i.MX8MMini - g2d rotation issue

gary_bisson — Fri, 03 Jul 2020 08:53:05 GMT

Hi,

Thank you for your feedback although I highly doubt this sentence is true as I know for a fact such rotation works fine with HWC from other silicon vendors. Let me know if you want the name of a platform that has HWC working as expected.

Regards,

Gary