topic Re: tw9992 de-interlace blending mode with imx8qm in i.MX Processors

tw9992 de-interlace blending mode with imx8qm

simonlin — Thu, 30 Jul 2020 07:13:56 GMT

I take below article as reference for support tw9992 blending mode, and refer attachment ISL79987&adv7180_reference_driver_for_iMX8QXP.7z

ISL79987 and adv7180 de-interlace driver for iMX8QXP boards

In my case, camera links to isi0, TV links to isi4

The TV weaving mode is OK.

But TV blending mode is fail

This is blending mode setting in dts file

Does anyone has suggestion?

Thanks

&i2c0_mipi_csi1 {
      clock-frequency = <100000>;
      pinctrl-names = "default";
      pinctrl-0 = <&pinctrl_mipi_csi1_i2c0>;
      status = "okay";

      tw9992_mipi:tw9992_mipi@44 {
            compatible = "renesas,tw9992_mipi";
            reg = <0x44>;
            pinctrl-names = "default";
            /* pinctrl-0 = <&pinctrl_mipi_csi1>; */
            pinctrl-0 = <&pinctrl_mipi_csi1_en_rst>;
            clocks = <&clk IMX8QM_24MHZ>;
            clock-names = "csi_mclk";
            csi_id = <1>;
            rst-gpios = <&gpio1 30 GPIO_ACTIVE_LOW>;

            video1en_gpio = <&gpio2 30 GPIO_ACTIVE_LOW>;
            digtr2_gpio = <&gpio0 1 GPIO_ACTIVE_HIGH>;
            digo2_gpio = <&gpio0 2 GPIO_ACTIVE_LOW>;

            video2en_gpio = <&gpio2 31 GPIO_ACTIVE_LOW>;
            digtr3_gpio = <&gpio2 17 GPIO_ACTIVE_HIGH>;
            digo3_gpio = <&gpio0 16 GPIO_ACTIVE_LOW>;

            mclk = <27000000>;
            mclk_source = <0>;
            mipi_csi;
            status = "okay";
            port {
                  tw9992_mipi_ep: endpoint {
                  remote-endpoint = <&mipi_csi1_ep>;
                  };
            };
      };
};

&mipi_csi_1 {
/delete-property/virtual-channel;
status = "okay";

      port@1 {
            reg = <1>;
            mipi_csi1_ep: endpoint {
                  remote-endpoint = <&tw9992_mipi_ep>;
                  data-lanes = <1 2>;
            };
      };
};

&isi_4 {

            interface = <3 0 2>;
            deinterlace_mode = <4>;
            /* 0 ~ 1: No de-interlacing,
            2: Odd even weave, 3: Even odd weave
            4: Odd even blending, 5: Even odd blending
            6 ~ 7: Line doubling */

deinterlace_blending;
status = "okay";
};

Re: tw9992 de-interlace blending mode with imx8qm

igorpadykov — Fri, 31 Jul 2020 00:39:41 GMT

Hi Simon

reason may be ISI errata since i.MX8QM has similar ISI errata as iMX8QXP B0.

As described on article:

"blending mode de-interlace can only work on iMX8QXP C0 chips"

Best regards
igor
-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

Re: tw9992 de-interlace blending mode with imx8qm

simonlin — Fri, 31 Jul 2020 05:22:17 GMT

Hi igorpadykov

Thanks for your response

Do you have any suggestion for weaving mode issue as below photo

Thanks

Re: tw9992 de-interlace blending mode with imx8qm

simonlin — Fri, 31 Jul 2020 11:20:50 GMT

Hi igorpadykov

I check p.7224 in iMX8QM_RM_Rev_F.pdf

It support blend de-interlace mode

System always repeat below log and doesn't display preview after I set blending mode

[ 85.771754] ---> mxc_isi_capture_open
[ 85.775474] ---> mxc_isi_get_remote_source_pad
[ 85.780220] ---> mxc_isi_cap_querycap
[ 85.784005] ---> mxc_isi_cap_g_chip_ident
[ 85.790170] ---> mxc_isi_get_remote_source_pad
[ 85.800440] ---> mxc_isi_capture_release
[ 85.804746] ---> mxc_isi_get_remote_source_pad

This is my current dts file

&isi_4 {

deinterlace_mode = <5>;
/* 0 ~ 1: No de-interlacing,
  2: Odd even weave, for PAL
  3: Even odd weave, for NTSC
  4: Odd even blending, for PAL
  5: Even odd blending, for NTSC
  6 ~ 7: Line doubling */
  deinterlace_blending;
  ntsc_top = <0>;
  status = "okay";
}

Do you have any suggestion?

Thanks

Re: tw9992 de-interlace blending mode with imx8qm

mablabs — Fri, 31 Dec 2021 12:10:05 GMT

Hi @simonlin,

I'm trying to get weaving based de-interlacing working for the TW9992. Can you share the necessary steps that you used to get it working?