topic Re: Compiler generate wrong code when making index programming S08QD4. in CodeWarrior for MCU

Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Mon, 07 May 2018 16:01:01 GMT

Compiler does not clear H register so returned result is unpredictable.

Solution to clear H register before using index programing.

Eksample:

unsigned char A;

unsigned char B;

#define LOOKUP = 0xF000

A = LOOKUP[B];

Assembler code.

LDX B;

LDA 0xF000,X

STA A;

Makes an unpredictable result.

Solution.

asm CLRH;

A = LOOKUP[B];

Assembler code.

LDX B;

CLRH;

LDA 0xF000,X

STA A;

Makes right result.

Took a little while to figure that one out because no compiler error was reported.

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Tue, 08 May 2018 06:27:50 GMT

Hi Per,

Thank you for contacting us.

To avoid misunderstanding, can you please send us more information:

1. your CW version.

2. demo project

Thanks for your cooperation.

Have a great day,
Jennie Zhang

-----------------------------------------------------------------------------------------------------------------------
Note: If this post answers your question, please click the Correct Answer button. Thank you!
-----------------------------------------------------------------------------------------------------------------------

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Tue, 08 May 2018 06:50:11 GMT

Hello Jennie,

The Codewarrior version is 11.0.

I attached the project which is a part of a Lithium-ion project to equalize

battery cells to even level for space/aircraft use.

The problem occurred in the file atd.c in the procedure ReadTemperature();

See attached project. Simple fix with one line of assembler code but

compiler should have done that using the Indexed, 16-Bit Offset (IX2)

format.

Best regards

Per Højfeldt

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Tue, 08 May 2018 07:12:59 GMT

Hi Per,

I see you attach some C files but not demo project?

Can you please create a demo project thus I can debug it directly ?

Have a great day,
Jennie Zhang

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Tue, 08 May 2018 08:00:22 GMT

I can only attach files and not the whole project folder. Its quit big for

a little processor.

How can I attach the project folder with all the files?

Regards

Per Højfeldt

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Tue, 08 May 2018 15:40:02 GMT

Hi Jenny,

I created a zip file with the whole project so if you unzip the attached

file to your computer you should be able to recompile and take a look at

the atd.c and atd.lst file to see the problem.

If you comment out the line asm CLRH; in the atd.c file and recompile you

can see that the CLRH disappear in the resulting assempler code for cT_Corr

= caTempCorr[ucDummy]; and will create an unknown result.

Tried also instead of asm CLRH; to asm LDHX #0; and CLRH return in the

code. Check it out. Must be some strange compiler error but at least there

is a solution.

Best regards and good luck

Per Højfeldt

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Tue, 08 May 2018 15:52:02 GMT

P.S

Forgot to say that the unzipped files should be placed in path C:\Battery

Manager\unzipped project for the linker and compiler to look at right path.

Per

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Thu, 10 May 2018 09:48:54 GMT

I tried to make a simple demo code on my side. but can't reproduce the issue. I wonder the problem is not on index.

Can you please check my code? I wonder how to modify my demo code to reproduce your problem.

I did the demo because I want to narrow down the problem to the right point.

Jennie Zhang

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Thu, 10 May 2018 14:11:51 GMT

Hi Jennie

I created a small demo program to recreate the error. Was tough to create

the error in cValue = caValues[ucPtr]; but after a while I found out it's a

macro that remove the CLRH in the assembler code.

I attached the demo project as a zip file and it have to be installed in

C:\Battery manager or you can just add the main.c, corrtable.c, corrtable.h

and the linker file Project.prm to you own project.

By comment out the macro the compiler generate correct code but with the

macro the compiler generate wrong code. Check it in the list file main.lst.

Can be fixed by adding asm CLRH; before cValue = caValues[ucPtr];.

Real weird.

Good luck and best regards

Per Højfeldt

On Thu, May 10, 2018 at 11:49 AM, ZhangJennie <admin@community.nxp.com>

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Thu, 10 May 2018 14:23:19 GMT

Hi Jennie

After a couple of beers I found the problem. In the first macro in the file

corrtable.h CELL_TEMP_VOLT return a long. Seem to give problems in second

macro CELL_TEMPERATURE. By casting CELL_TEMP_VOLT to an int everything is

fine and CLRH return in assembler code.

Welcome to the wonderful world of C programming.

Thanks for looking into this strange problem.

I attached the solution.

Beast regards

Per Højfeldt

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Fri, 11 May 2018 06:01:32 GMT

Hi Jennie

Good morning or what time it is where You are. I'm in Denmark.

Anyhow. I created the error in the project you send me. You can see the

problem in the main.lst if you compile with the different definitions of

CELL_TEMPERATURE. Just set your project up to generate list files in build

setup and right click Output. Add %n.lst in the list output.

Don't know of it's really a compiler error that a subtract of a long from

an int gives the different but wort to know.

Have a great morning.

Per

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Fri, 11 May 2018 06:05:08 GMT

Hi Per Hojfeldt.

I also wonder the problem may be on data type conversion in MACRO. Because if I don't assign MACRO to uiRawBandgap and uiRawTempValue, there is no error.

Anyway, Good to know the problem got solved. Thanks for the sharing.

Have a great day,
Jennie Zhang

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Fri, 11 May 2018 06:06:08 GMT

Hi Per Hojfeldt.

I also wonder the problem may be on data type conversion in MACRO. Because if I don't assign MACRO to uiRawBandgap and uiRawTempValue, there is no error.

Anyway, Good to know the problem got solved. Thanks for the sharing.

Have a great day,
Jennie Zhang

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Fri, 11 May 2018 07:18:57 GMT

Hi Jennie

Yes. Just wonder. I will try to use your demo project and make it without

macros and see of it all come down to the calculation of a long with and

int.

Stay tuned.

Enjoy,

Per.

On Fri, May 11, 2018 at 8:06 AM, ZhangJennie <admin@community.nxp.com>

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Fri, 11 May 2018 08:31:34 GMT

Hi Jennie

Take a look at the main.c and resulting asm list file. Is this a compiler

error?

Let me know

Per

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Fri, 11 May 2018 08:39:58 GMT

Hi Jennie

Just a little heads up. I disabled all optimization in the compiler. Made

no different. So it's not the optimizer.

Per

On Fri, May 11, 2018 at 10:30 AM, Per Hojfeldt <perhojfeldt@gmail.com>

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Mon, 14 May 2018 04:41:35 GMT

Sorry I am on trip this week. I will check your issue once I am back.

Jennie.

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Wed, 23 May 2018 05:13:14 GMT

Hi Per,

I tested your QD4.zip with ucDummy = (25 - (ulTemp / 33)); But I didn't get wrong result for ucDummy.

Does this affect ucDummy result on your side?

Have a great day,
Jennie Zhang

Re: Compiler generate wrong code when making index programming S08QD4.

perhojfeldt — Thu, 31 May 2018 09:23:18 GMT

Hi Jennie,

Been on vacation so haven't looked into it yet. Also got a new desktop so had to set everything up. I will get back to you on your question. Though still look like the problem is there with the missing CLRH in the assembler list file. Anyhow. Can I get the Codewarrior 11.0 in a Linux version for install in Ubuntu because on my new desktop I have dualboot for windows and Ubuntu and would like to do my development under Linux.

Regards

Per Højfeldt

Re: Compiler generate wrong code when making index programming S08QD4.

ZhangJennie — Tue, 05 Jun 2018 09:54:16 GMT

Hi Per,

CodeWarrior for linux supporting was dropped. CW 10.2 for linux is the last version.

CW11 doesn't support linux. the support system:

Microsoft® Windows XP 32-bit and 64-bit
(Professional Edition),
Microsoft Windows Vista® 32-bit and 64-bit (Home
Premium Edition and Business Edition), or
Microsoft Windows 7 32-bit and 64-bit (Home
Premium Edition and Professional Edition)
Microsoft Windows 8 32-bit and 64-bit (Home
Premium Edition and Professional Edition)
Microsoft Windows 8.1 32-bit and 64-bit (Home
Premium Edition and Professional Edition)
Microsoft Windows 10 32-bit and 64-bit (Home
Premium Edition and Professional Edition)

I suggest you use CW11+windows platform instead. if any code issue with CW11 on windows, let's discuss.

Have a great day,
Jennie Zhang