topic Re: C calculation Error in Classic/Legacy CodeWarrior

C calculation Error

v_dave — Thu, 29 Oct 2020 09:03:14 GMT

Using:

Codewarrior 8.1.1a build 7168 for the DSC56800/E

Target = 56F8323

USB Tap as debugger

I am having an interesting issue:

Code:

#define ONE_REV     200         //1.8deg per Full Step = 200 Steps for 1 Rev#define HALF_STEP_MULTIPLY            2    //Each Step = 1/2 Step#define NINE_EIGHTFIVE      985     //9.85typedef struct MOT_PARAM{ unsigned char  Mode;   // CW, CCW, Shortest unsigned char  Step_Mode;  //Full, Half, etc.. unsigned char Port_Position; //Current Position 0=Home unsigned char Port_Total;  //Total Ports on the Valve unsigned int    GearRatio;      //This is the Gear Ratio of the Motor unsigned int    Port_Deg;       // this is how many degree's between ports unsigned int QOffset;  //Quadrature Decoder Offset long            TotalSteps;     //Estimated number of steps for 1 revolution}mot_param;extern mot_param UA_Param;UA_Param.GearRatio = NINE_EIGHTFIVE;UA_Param.TotalSteps = (((UA_Param.GearRatio * ONE_REV) * HALF_STEP_MULTIPLY) / 100);

When this calculation is complete UA_Param.TotalSteps = 7

Should be 3940

I must be doing something wrong but not sure what yet. Any ideas?

Re: C calculation Error

Problem99 — Wed, 31 Oct 2007 20:12:33 GMT

A separate "cast" operator is required, I think

UA_Param.TotalSteps = (( (long) UA_Param.GearRatio * ONE_REV * HALF_STEP_MULTIPLY) / 100 );

Re: C calculation Error

CompilerGuru — Thu, 01 Nov 2007 14:49:35 GMT

Without that cast, the compiler will use the int type to do all computations. With it, everything is done with longs. Basically ANSI always uses the types of the arguments of the operators, and as there were only ints involved, all computations are based on them. Well, the real rule is a bit more complex also caring about the signed vs unsigned types and more.

Daniel

Re: C calculation Error

v_dave — Thu, 15 Nov 2007 03:23:16 GMT

Hello,

I just wanted to follow-up with the solution in case someone else has this problem.

The final result was to cast every variable:

UA_Param.TotalSteps = (((long)UA_Param.GearRatio * (long)ONE_REV * (long)HALF_STEP_MULTIPLY) / 100);