MQX Software Solutions中的主题 MFS Cache Bug

MFS Cache Bug

leifzars — Fri, 23 Dec 2016 19:49:19 GMT

Provide MFS_sector_cache_invalidate with args first_sector = X and sectors = 1. Insure cache includes sector X.

The cache_record will not be invalidated!

Check the current code out...

last_sector = first_sector + sectors - 1; // so last_sector now equals X

....
if ((cache_record->SECTOR_NUM >= first_sector) && (cache_record->SECTOR_NUM < last_sector))
{

//Do invalidation

}

The above evaluates to false, but the intent was for it to be true. Changing the second condition from < to <= fixes the issue.

Re: MFS Cache Bug

danielchen — Tue, 27 Dec 2016 02:59:36 GMT

Hi Leif:

Minimum number of sectors which MFS is able to keep in cache at a time is 2 sectors. There is a macro in mfs_cnfg.h.

#define MFSCFG_SECTOR_CACHE_SIZE 2

You also can refer to the section 2.5 in MQX_MFS_User_Guide.pdf for more details.

I will forward your solution to the develop team. Thanks for your feedback.

Regards

Daniel

Re: MFS Cache Bug

leifzars — Tue, 27 Dec 2016 03:33:13 GMT

Daniel,

I am not sure that the sector cache size has anything to do with the invalidate function failing to invalidate a cached sector? A cached record is comprised of one sector, no matter the number of records (MFSCFG_SECTOR_CACHE_SIZE ).

MFSCFG_SECTOR_CACHE_SIZE defines the number of cache records, one sector per record.

The MFS_sector_cache_invalidate function allows you to request 1 or a region of sectors to be invalidated. In the case of trying to invalidate 1, it fails.

Thanks Leif

Re: MFS Cache Bug

leifzars — Tue, 03 Jan 2017 20:49:55 GMT

Daniel,

What do you think?

Re: MFS Cache Bug

danielchen — Wed, 04 Jan 2017 09:23:00 GMT

Hi Leif:

Yes , you are right. from function MFS_sector_cache_invalidate_record we can see it is one sector per record. This is an issue we need to fix.

Regards

Daniel

Re: MFS Cache Bug

leifzars — Wed, 04 Jan 2017 14:25:07 GMT

Good deal, thanks

Re: MFS Cache Bug

leifzars — Thu, 06 Apr 2017 18:34:23 GMT

Found same issue in MFS_sector_cache_flush.