topic Re: Memory leak in MQX 4.2 timer.c in MQX Software Solutions

Memory leak in MQX 4.2 timer.c

fcw — Mon, 12 Dec 2016 05:47:49 GMT

Line 417 states "timer_entry_ptr = (TIMER_ENTRY_STRUCT_PTR)_mem_alloc_system_zero( ......."

Then lines 448 and following state:

        "if (_lwsem_wait(&timer_component_ptr->TIMER_ENTRIES_LWSEM) != MQX_OK)
        {
            _task_set_error(MQX_INVALID_LWSEM);
            return(TIMER_NULL_ID);
        }"

... thus exiting without freeing timer_entry_ptr.

Re: Memory leak in MQX 4.2 timer.c

EAI — Tue, 13 Dec 2016 20:42:23 GMT

Fred;

You are correct. This same error also occurs elsewhere in the file (on each of the _timer_start_..._internal functions). The timer code has been refactored for MQXv5, and this has been fixed.

Craig

Re: Memory leak in MQX 4.2 timer.c

fcw — Fri, 27 Jan 2017 00:38:37 GMT

OK, great, but what about a fix for 4.2?