8-bit MicrocontrollersのトピックRe: BRCLR, BRSET, and TAX not working

BRCLR, BRSET, and TAX not working

SILKS — Thu, 05 Mar 2009 08:08:20 GMT

Hello All,

Have a problem with a short assembly language program

running on a M98S08AC32-64

CodeWarrior is killing me by throwing errors on what looks like legit code.

Thank you all,

Code is below.

Randall

Doofus(void) {

asm {

brclr 6,cmdsave,scan_2
brclr 6,soundop,scan_11

brset 6,command,scan

}

CodeWarrior 6.2

Throwing unknown opcode 45. It does this with TAX and other instructions

Re: BRCLR, BRSET, and TAX not working

bigmac — Thu, 05 Mar 2009 08:31:35 GMT

Hello Randall,

The BRSET and BRCLR instructions are applicable to a page zero location only. Therefore, your cmdsave, soundop and command variables will need to be explicitly allocated to Z_RAM segment. Additionally, the branch addresses scan_2, scan_11 and scan require to be within range for relative addressing mode.

I cannot comment about your TAX problem without knowing the context.

Regards,

Mac

Re: BRCLR, BRSET, and TAX not working

peg — Thu, 05 Mar 2009 17:06:58 GMT

Hi,

Surely Codewarrior would issue a more relevant error than this for such simple things as " not in page zero" and " too big a relative branch" if these where the only problems???

There should be no limitation whatsoever on TAX

Re: BRCLR, BRSET, and TAX not working

bigmac — Thu, 05 Mar 2009 19:21:18 GMT

Hello,

The OP is a little unclear about the specifics of the error messages. However, since inline assembly code is used, I presume that the error messages are generated by the compiler, rather than the assembler. Therefore I guess the messages are likely to be more C orientated, and less specific for the assembly code content.

The error message that refers to opcode 45 (not sure whether hex or decimal) does not make sense. The opcode for TAX instruction is 0x97.

Regards,

Mac

Re: BRCLR, BRSET, and TAX not working

SILKS — Sat, 07 Mar 2009 04:21:59 GMT

MAC,

Worked perfectly, moving things into zero page with the #pragma worked. Thanks to you all.

Having another crazy problem, the code below is a small project that results in an error C18000

Label not set, however, as you can see the label clearly is set. Am I having another zero page error here?

Thanks, Randall.

#include <hidef.h> /* for EnableInterrupts macro */
#include "derivative.h" /* include peripheral declarations */
// memvar declarations
#pragma DATA_SEG __SHORT_SEG MY_ZEROPAGE

char flag1 = 0x01;
char soundop = 0xFF;
char modesave = 0x01;
char modeflag = 0x00;

// function prototype
int restore(void);

void main(void) {

EnableInterrupts; /* enable interrupts */
/* include your code here */

for(; {
__RESET_WATCHDOG(); /* feeds the dog */
} /* loop forever */
/* please make sure that you never leave main */
}
/* function for Restore sounds in operation */

#pragma DATA_SEG DEFAULT

restore(void){

asm (

              brclr   7,flag1,rstor1;         //for the special case of interrupting !error C18000
              rts;
rstor1:
              lda     modesave;               //find mode when interrupted
              sta     modeflag;               //restore the flag
              lda     soundop;
              and     #$07f;                  //if these all off, nothing was operating
              bne     rstor2;                 //b/ something on, go figure it out
              rts;

rstor2:

return 0;
}

Re: BRCLR, BRSET, and TAX not working

peg — Sat, 07 Mar 2009 06:11:34 GMT

Hello Randall,

Seems you have to pretty much figure your inline assembly problems out for yourself, the compiler is not much help.

What about the TAX problem? It went away too? This was leading me to think the problem was something else.

I've never used inline assembly so don't know much about it. I can see you don't have a closing parenthesis for the asm( or maybe it's the stupid smilies. Use a code box inyour post to stop this happening.

Re: BRCLR, BRSET, and TAX not working

SILKS — Sat, 07 Mar 2009 08:43:48 GMT

Peg,

Thanks for the help, Umm code box, gotta figure that out on the forum.

I put the stupid smilies in there because I wanted to kill small woodland creatures when legit code did not run. (sorry). Talk to you Monday.

Regards

Randall

Re: BRCLR, BRSET, and TAX not working

CompilerGuru — Sat, 07 Mar 2009 09:17:34 GMT

Try to use

__asm {

nop

}

(and not "asm(")

Also there must be a correspoding closing brace, of course.

The restore function should also have a return type, otherwise it defaults to int and the HLI code only returns a char.

Daniel

Re: BRCLR, BRSET, and TAX not working

bigmac — Sun, 08 Mar 2009 02:21:50 GMT

Hello Randall,

I can also see another issue with your function. You have used two intermediate RTS instructions. This is probably not a good idea when you need to return a value, since the actual value returned could be quite confusing if one of the RTS exits occurs.

Regards,

Mac